Commit Graph

2534 Commits

Author SHA1 Message Date
Justin M. Keyes
d7a1665785 Merge pull request #1718 from jonaias/master
Transform global variable really_exiting into static.
2014-12-26 08:30:15 -05:00
Justin M. Keyes
4840f59272 Merge pull request #1741 from oni-link/fix_cid_90712
coverity/90712: Remove unnecessary check for NULL.
2014-12-26 08:17:54 -05:00
oni-link
ce03171323 coverity/90712: Remove unnecessary check for NULL.
** CID 90712:  Dereference after null check  (FORWARD_NULL)
/src/nvim/getchar.c: 3654 in check_abbr()

vim_strsave() never returns NULL, so q is never NULL. Removing the
NULL check for q should fix this warning.
2014-12-26 12:26:09 +01:00
Jonas Dourado
a00c2e0ecb Transform global variable really_exiting into static. 2014-12-26 01:46:21 -02:00
Justin M. Keyes
e241b0ba09 Merge pull request #1740 from fwalch/improve-vimpatch
Minor improvements to vim-patch script.
2014-12-25 21:44:35 -05:00
Florian Walch
0ae2acdc86 Improvements to vim-patch script. 2014-12-25 23:32:40 +01:00
Justin M. Keyes
7231a23cf6 Merge pull request #1722 from fwalch/vim-7.4.488
vim-patch:7.4.483, vim-patch:7.4.485, vim-patch:7.4.488
2014-12-25 12:57:09 -05:00
Justin M. Keyes
f13b90c064 Merge pull request #1715 from elmart/remove-long_u-3
Remove project-specific integer types: long_u. (3)
2014-12-24 16:07:49 -05:00
Eliseo Martínez
516405b601 Remove long_u: Passing-by: put_time(): Refactor implementation.
put_time() had a complicated implementation, because of having to shift
an 8-byte value in a portable way with old means.
That can be greatly simplified now, using a C99 fixed-size type.
2014-12-24 20:00:05 +01:00
Eliseo Martínez
ec09f4488f Remove long_u: Passing-by: undo.c: Add to -Wconversion.
Previous commit dropped many -Wconversion warnings in both spell.c and
undo.c. spell.c still has a lot of them (200+). But in undo.c, only a
handful of them remain. Take the chance to eliminate those, too, and add
undo.c to -Wconversion checked files.
2014-12-24 20:00:05 +01:00
Eliseo Martínez
d2745a59f8 Remove long_u: put_bytes(): Refactor.
Remove all long_u instances due to put_bytes() function.

First, function signature is changed this way:
- nr  : long_u --> uintmax_t
    uintmax_t is chosen so that invocations can use any unsigned integer
    type (including size_t) without needing to cast.
- len : int    --> unsigned int
    This is to pass the size in bytes of the previous param, thus an
    unsigned int is enough. All invocations use positive integer
    literals, so change is safe without the need for casts.

Then, function implementation is adapted accordingly.

Last, all invocation points are refactored this way:
- Refactor types to minimize casts.
- Inline declarations (C99 style) in containing function.

All this changes were done with -Wconversion temporarily activated for
spell.c and undo.c, so that we can assert changes are type-safe and do
not introduce any warnings to that respect.
2014-12-24 20:00:04 +01:00
Justin M. Keyes
59985523b8 Merge pull request #1732 from fwalch/small-patches
vim-patch: Small patches (3)
2014-12-24 00:53:00 -05:00
Justin M. Keyes
11a3eba72c Merge #1493: enable linting by default 2014-12-24 00:34:00 -05:00
Florian Walch
ed9828140a Linting: Suppress warnings in os/users.c. 2014-12-24 00:32:26 -05:00
Florian Walch
0f258e4453 Linting: Fix strcpy warning. 2014-12-24 00:32:26 -05:00
Florian Walch
73a970ccd9 Linting: Fix header guards, add whitespace. 2014-12-24 00:32:26 -05:00
Florian Walch
e21f6e754d Linting: Integrate into CMake, enable by default. 2014-12-24 00:32:26 -05:00
Florian Walch
05b2f01f6a vim-patch:7.4.518
Problem:    Using status line height in width computations.
Solution:   Use one instead. (Hirohito Higashi)

https://code.google.com/p/vim/source/detail?r=v7-4-518
2014-12-24 00:32:55 +01:00
Florian Walch
3286176406 vim-patch:7.4.516
Problem:    Completing a function name containing a # does not work.  Issue
	    253.
Solution:   Recognize the # character. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-516
2014-12-24 00:32:53 +01:00
Florian Walch
5e542ba56e vim-patch:7.4.513
Problem:    Crash because reference count is wrong for list returned by
	    getreg().
Solution:   Increment the reference count. (Kimmy Lindvall)

https://code.google.com/p/vim/source/detail?r=v7-4-513
2014-12-23 21:48:22 +01:00
Florian Walch
89bab9b90e vim-patch:7.4.520
Problem:    Sun PCK locale is not recognzed.
Solution:   Add PCK in the table. (Keiichi Oono)

https://code.google.com/p/vim/source/detail?r=v7-4-520
2014-12-23 21:35:50 +01:00
Florian Walch
df05574c97 vim-patch:7.4.508
Problem:    When generating ja.sjis.po the header is not correctly adjusted.
Solution:   Check for the right header string. (Ken Takata)

https://code.google.com/p/vim/source/detail?r=v7-4-508
2014-12-23 21:34:38 +01:00
Florian Walch
e06159e6ae vim-patch:7.4.488
Problem:    test_mapping fails for some people.
Solution:   Set the 'encoding' option. (Ken Takata)

https://code.google.com/p/vim/source/detail?r=v7-4-488
2014-12-23 21:23:49 +01:00
Florian Walch
0b192bf990 vim-patch:7.4.485
Problem:    Abbreviations don't work. (Toothpik)
Solution:   Move the length computation inside the for loop.  Compare against
	    the unescaped key.

https://code.google.com/p/vim/source/detail?r=v7-4-485
2014-12-23 21:23:32 +01:00
Florian Walch
6aecbbebfd vim-patch:7.4.483
Problem:    A 0x80 byte is not handled correctly in abbreviations.
Solution:   Unescape special characters. Add a test. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-483
2014-12-23 21:23:32 +01:00
Justin M. Keyes
aa08632caf Merge pull request #1728 from fwalch/small-patches2
vim-patch: Multiple small patches (2)
2014-12-23 15:19:07 -05:00
Florian Walch
fc0be5b79d vim-patch:7.4.474
Problem:    AIX compiler can't handle // comment.  Issue 265.
Solution:   Remove that line.

https://code.google.com/p/vim/source/detail?r=v7-4-474
2014-12-23 21:17:01 +01:00
Florian Walch
5b98a4338f vim-patch:7.4.477
Problem:    When using ":%diffput" and the other file is empty an extra empty
	    line remains.
Solution:   Set the buf_empty flag.

https://code.google.com/p/vim/source/detail?r=v7-4-477
2014-12-23 21:17:01 +01:00
Florian Walch
0a20cd7f50 vim-patch:7.4.489
Problem:    Cursor movement still wrong when 'lbr' is set and there is a
	    number column. (Hirohito Higashi)
Solution:   Add correction for number column. (Hiroyuki Takagi)

https://code.google.com/p/vim/source/detail?r=v7-4-489
2014-12-23 21:17:00 +01:00
Florian Walch
598f69b05e vim-patch:7.4.491
Problem:    When winrestview() has a negative "topline" value there are
	    display errors.
Solution:   Correct a negative value to 1. (Hirohito Higashi)

https://code.google.com/p/vim/source/detail?r=v7-4-491
2014-12-23 21:17:00 +01:00
Florian Walch
12245f9f1f vim-patch:7.4.493
Problem:    A TextChanged autocommand is triggered when saving a file.
	    (William Gardner)
Solution:   Update last_changedtick after calling unchanged(). (Christian
	    Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-493
2014-12-23 21:17:00 +01:00
Florian Walch
75b7b04436 vim-patch:7.4.494
Problem:    Cursor shape is wrong after a CompleteDone autocommand.
Solution:   Update the cursor and mouse shape after ":normal" restores the
	    state. (Jacob Niehus)

https://code.google.com/p/vim/source/detail?r=v7-4-494
2014-12-23 21:16:56 +01:00
Florian Walch
2ba50a7846 vim-patch:7.4.499
Problem:    substitute() can be slow with long strings.
Solution:   Store a pointer to the end, instead of calling strlen() every
	    time. (Ozaki Kiichi)

https://code.google.com/p/vim/source/detail?r=v7-4-499
2014-12-23 21:15:31 +01:00
Justin M. Keyes
4f6bb8a9a9 Merge pull request #1727 from fwalch/small-patches
vim-patch: Multiple small patches
2014-12-23 15:03:08 -05:00
Justin M. Keyes
44fabac4e0 Merge pull request #1724 from fwalch/vim-7.4.452
vim-patch:7.4.449, vim-patch:7.4.452
2014-12-23 14:50:36 -05:00
Justin M. Keyes
53b13d2a18 Merge pull request #1726 from fwalch/vim-7.4.447
vim-patch:7.4.447
2014-12-23 14:42:09 -05:00
Justin M. Keyes
e274c5f622 Merge pull request #1721 from fwalch/vim-7.4.395
vim-patch:7.4.395
2014-12-23 14:31:09 -05:00
Justin M. Keyes
79fd93768a Merge pull request #1720 from fwalch/vim-7.4.311
vim-patch:7.4.311
2014-12-23 14:13:53 -05:00
Florian Walch
d5bdc709d0 vim-patch:7.4.447
Problem:    Spell files from Hunspell may generate a lot of errors.
Solution:   Add the IGNOREEXTRA flag.

https://code.google.com/p/vim/source/detail?r=v7-4-447
2014-12-23 16:14:46 +01:00
Florian Walch
c4e0cd4418 vim-patch:7.4.452
Problem:    Can't build with tiny features. (Tony Mechelynck)
Solution:   Use "return" instead of "break".

https://code.google.com/p/vim/source/detail?r=v7-4-452
2014-12-23 16:14:24 +01:00
Florian Walch
1e17904eb2 vim-patch:7.4.449
Problem:    Can't easily close the help window. (Chris Gaal)
Solution:   Add ":helpclose". (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-449
2014-12-23 16:14:24 +01:00
Florian Walch
1f73d7cb85 vim-patch:7.4.438
Problem:    Cached values for 'cino' not reset for ":set all&".
Solution:   Call parse_cino(). (Yukihiro Nakadaira)

https://code.google.com/p/vim/source/detail?r=v7-4-438
2014-12-23 16:13:31 +01:00
Florian Walch
2b9f11ac64 vim-patch:7.4.441
Problem:    Endless loop and other problems when 'cedit' is set to CTRL-C.
Solution:   Do not call ex_window() when ex_normal_busy or got_int was set.
	    (Yasuhiro Matsumoto)

https://code.google.com/p/vim/source/detail?r=v7-4-441
2014-12-23 16:13:30 +01:00
Florian Walch
2fefb5e7d3 vim-patch:7.4.458
Problem:    Issue 252: Cursor moves in a zero-height window.
Solution:   Check for zero height. (idea by Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-458
2014-12-23 16:13:30 +01:00
Florian Walch
0158539c77 vim-patch:7.4.468
Problem:    Issue 26: CTRL-C does not interrupt after it was mapped and then
	    unmapped.
Solution:   Reset mapped_ctrl_c. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-468
2014-12-23 16:13:30 +01:00
Justin M. Keyes
68f6fcffbf Merge pull request #1723 from fwalch/offline-vimpatch
Ignore update errors in vim-patch script.
2014-12-23 09:48:25 -05:00
Florian Walch
b1d025a0c8 Ignore update errors in vim-patch script. 2014-12-23 11:15:42 +01:00
Florian Walch
1053f49ab0 vim-patch:7.4.395
Problem:    C indent is wrong below an if with wrapped condition followed by
	    curly braces. (Trevor Powell)
Solution:   Make a copy of tryposBrace.

https://code.google.com/p/vim/source/detail?r=v7-4-395
2014-12-23 10:27:05 +01:00
David Rodriguez
c824e7b2d2 vim-patch:7.4.311
Problem:    Can't use winrestview to only restore part of the view.
Solution:   Handle missing items in the dict. (Christian Brabandt)

https://code.google.com/p/vim/source/detail?r=v7-4-311
2014-12-23 10:13:13 +01:00
Marco Hinz
c3de63bfbc vim-patch:7.4.457 #1713
Problem:  Using getchar() in an expression mapping may result in
          K_CURSORHOLD, which can't be recognized.
Solution: Add the <CursorHold> key.  (Hirohito Higashi)

https://code.google.com/p/vim/source/detail?r=v7-4-457
2014-12-23 03:38:17 -05:00