Justin M. Keyes
6b45e12d67
screen.lua: expect_unchanged(), get_snapshot()
...
Factor `get_snapshot()` out of `print_snapshot()`, so that callers can
get a table (for use with `expect()`) instead of the string form.
Try to use this to fix indeterminism in `searchhl_spec.lua`.
- Since the screen state is collected by `screen:expect_unchanged()`,
we don't need a deterministic initial state (which would then be
hardcoded into the test). This allows us to check "did anything
change in the last N ms?" rather than "did anything change compared
to a hardcoded screen-state?"
- This may end up fruitless, because `expect_unchanged()` depends on
timing to wait for an initial "current state".
2019-07-20 14:25:07 +02:00
Justin M. Keyes
643ba06d4d
test: shell-test.c: flush stdout for REP #10548
...
fix #10534
2019-07-20 12:52:33 +02:00
Jan Edmund Lazo
7f66fdb54d
[RFC]vim-patch:8.1.{749,1715} #10545
...
* vim-patch:8.1.1715: emoji characters are seen as word characters for spelling
Problem: Emoji characters are seen as word characters for spelling. (Gautam
Iyer)
Solution: Exclude class 3 from word characters.
06e63770096acc79f5d4
2019-07-20 10:48:45 +02:00
Justin M. Keyes
f55c1e4233
reltimefloat(): allow negative result #10544
...
For "backwards" duration, reltimefloat() should return negative value
like its counterpart reltimestr().
ref bab24a88ab06af88cd72#10521
fix #10452
2019-07-20 10:46:09 +02:00
Justin M. Keyes
afef973262
doc [ci skip] #10383
...
- test/README.md: document luassert `TableFormatLevel`
- CONTRIBUTING.md: absorb parts of the old "Development tips" wiki page
2019-07-19 21:32:04 +02:00
Björn Linse
d5f7099be2
Merge pull request #10541 from bfredl/conversion_getln
...
refactor: enable -Wconversion for ex_getln.c and use int for Rows/Columns
2019-07-19 20:15:03 +02:00
Ihor Antonov
7e4fd045f9
PVS/V1026: possible overflow in a loop #10529
...
* pvs/V1026: possible overflow in a loop
* refactor: char_u -> uint8_t
* lint
* remove unused if branch: enc_utf8 is always true
2019-07-19 19:41:57 +02:00
Justin M. Keyes
1745e59ac1
Merge #10543 'PVS/V560'
2019-07-19 19:39:46 +02:00
Ihor Antonov
f42bb50392
lint
2019-07-19 12:31:34 -04:00
Ihor Antonov
f1127a33f1
pvs/V560: A part of conditional expression is always true
...
wp->w_p_list is checked earlier in the same composite if condition
2019-07-19 11:06:40 -04:00
Ihor Antonov
91bbd07417
pvs/V560: A part of conditional expression is always true
...
c == '\000' is always true because of the if branch it is already in
2019-07-19 10:58:31 -04:00
Björn Linse
aa28e070e9
refactor: use int for Columns and Rows
2019-07-19 15:57:19 +02:00
Björn Linse
75928101f8
refactor: enable -Wconversion for ex_getln.c
2019-07-19 15:56:38 +02:00
Justin M. Keyes
a46fe2e615
option_defs.h: fix incorrect definition #10542
2019-07-19 15:17:31 +02:00
erw7
6614543316
test: Force $TEST_FILE to relative path [ci skip] #10535
...
- Always force TEST_PATH to a relative path.
- Eliminate rel_test_path. (The code simplification is worth the extra
subdirectory below Xtest_tmpdir/.)
2019-07-19 13:51:18 +02:00
Jan Edmund Lazo
d4e93fedf1
vim-patch:8.1.0740: Tcl test fails ( #10540 )
...
Problem: Tcl test fails.
Solution: When the argument is empty don't give an error, instead rely on
the error reporting higher up.
8309b0559d
2019-07-19 11:46:22 +02:00
Justin M. Keyes
281d422e71
Merge #10368 from janlazo/vim-8.0.1164
...
vim-patch:8.0.{755,1146,1164}
2019-07-19 00:39:50 +02:00
Justin M. Keyes
572ecdfeed
Merge #10052 from janlazo/vim-8.1.0729
...
vim-patch:8.1.{729,732}
2019-07-19 00:36:56 +02:00
Daniel Hahler
a04e0c8db2
Revert "Downgrade to clang-4.0 to avoid false-positive warnings from clang" [skip appveyor] ( #10487 )
...
This reverts commit 2cbac719c3
2019-07-18 08:49:37 +02:00
Ihor Antonov
ba7ec994ae
pvs/V1037: two case branches doing the same thing ( #10527 )
2019-07-18 03:12:45 +02:00
Ihor Antonov
9412dcb6ae
PVS/V1037: suppress warning #10526
...
* Case branches are semantically different.
* Lint
2019-07-18 03:10:45 +02:00
Jan Edmund Lazo
fdfdc0a228
vim-patch:8.1.0732: cannot build without the eval feature
...
Problem: Cannot build without the eval feature.
Solution: Make a copy of the sourced file name.
ea56e167c8
2019-07-17 20:27:08 -04:00
Jan Edmund Lazo
aa681df25f
vim-patch:8.1.0729: there is a SourcePre autocommand event but not a SourcePost
...
Problem: There is a SourcePre autocommand event but not a SourcePost.
Solution: Add the SourcePost autocommand event. (closes vim/vim#3739 )
2b6185287a
2019-07-17 20:23:05 -04:00
Daniel Hahler
3d356c14df
ci: Travis: use gcc9 with gcov job [skip appveyor] ( #10480 )
...
* ci: Travis: use gcc-9 in gcov job
* ci: Travis: use CCACHE_CPP2=1
This is required to avoid warnings with newer gcc/clang.
Follow-up to: https://github.com/neovim/neovim/pull/10533
2019-07-18 01:27:05 +02:00
Ihor Antonov
8499e18615
PVS/V1037: suppress warning #10528
...
Despite the PVS warning, we do not want to conflate these
cases, they are semantically different.
2019-07-18 01:20:59 +02:00
Ihor Antonov
452ec4ed31
PVS/V1037: redundant switch-case branches #10519
...
Suppress the warning, the branches are semantically different.
2019-07-18 00:20:06 +02:00
Daniel Hahler
4fc91fe365
tests: fix "system() … prints verbose information" ( #10532 )
...
It would previously fail with `set shell=sh` (no slash).
For the test itself we can just use a non-existing (fake) shell, because
it is only about the verbose output.
Ref: https://github.com/neovim/neovim/issues/9330
2019-07-17 23:05:04 +02:00
Daniel Hahler
353b3852fd
ci: Travis: ccache: use CCACHE_HASHDIR [skip appveyor]
...
This is the default since ccache 3.3, but Travis has 3.2.4.
This fixes compiler warnings from macros with later clang/gcc.
Using CCACHE_HASHDIR=1 fixes ccache v3.2.4, but CCACHE_NOHASHDIR=1 does
not break v3.7.1. The real issue/fix appears to be
ccache/ccache@284e3a0 , and using the hashdir option seems to only work
around this.
Unblocks https://github.com/neovim/neovim/pull/10480 , and
https://github.com/neovim/neovim/pull/10487 .
Ref: https://github.com/ccache/ccache/commit/6d9cb3dfdd9
Closes https://github.com/neovim/neovim/pull/10533 .
2019-07-17 19:41:19 +02:00
Daniel Hahler
b41507927b
build: fix handling of install prefix with CMAKE_EXTRA_FLAGS ( #10530 )
...
Append `CMAKE_INSTALL_PREFIX` to any given `CMAKE_EXTRA_FLAGS` always.
Regressed in 5031e3298https://github.com/neovim/neovim/issues/10524 .
2019-07-17 16:38:11 +02:00
Justin M. Keyes
58dd5fcc01
jobstop(): close channel before process_stop() #10522
...
fix #9799
regression of #7081
Helped-by: Björn Linse <bjorn.linse@gmail.com>
Problem: :UpdateRemotePlugins (which calls rpcstop()) sometimes crashes:
remote/host: python3 host registered plugins []
nvim: ../src/nvim/event/wstream.c:78:
_Bool wstream_write(Stream *, WBuffer *): Assertion `!stream->closed' failed.
Aborted (core dumped)
Order of events (channel 163, see logs below):
1. Channel's in-stream (0x2ba86c0) is **closed** by `f_rpcstop`..`process_stop`.
2. `receive_msgpack` parses the channel out-stream (0x2ba8860)
3. Invokes "nvim_command_output" API method.
4. Writes result to the **closed** in-stream => **abort**
- af993da4355215e3205a
2019-07-17 11:13:57 +02:00
Jan Edmund Lazo
f96dec4a2c
vim-patch:8.1.0715: superfluous redraw_win_later() #10523
...
Problem: Superfluous call to redraw_win_later().
Solution: Remove the call.
6f7e555f74
2019-07-17 11:08:44 +02:00
Daniel Hahler
34c6e5beaf
tests: move "busted" dir to "test" ( #10518 )
...
* tests: move "busted" dir to "test"
It is used for outputHandlers only, and clearly belongs to the tests.
Use the full module name with the `-o` option to `busted` then for
clarity.
* luacheck
* test/busted/outputHandlers/TAP.lua: use/extend upstream
2019-07-16 22:02:50 +02:00
Daniel Hahler
3a1d3e9ef1
tests: shell-test: use count for REP ( #10514 )
...
Also fix V576: use width specification
> Incorrect format. Consider checking the third actual argument of the
> 'sscanf' function. It's dangerous to use string specifier without width
> specification. Buffer overflow is possible.
2019-07-16 21:35:53 +02:00
Justin M. Keyes
bab24a88ab
viml/profile: revert proftime_T to unsigned type #10521
...
- reltimestr(): Produce negative value by comparing the unsigned
proftime_T value to INT64_MAX.
https://github.com/neovim/neovim/issues/10452#issuecomment-511155132
1. The interfaces of nearly all platforms return uint64_t. INT64_MAX is
only half of that.
2. Low-level interfaces like this typically define that there is no
fixed starting point. The only guarantees are that it's (a)
monotonically increasing at a rate that (b) matches real time.
ref 06af88cd72fix #10452
2019-07-16 20:10:08 +02:00
Ihor Antonov
f31f2d0b22
PVS/V1028: cast operands, not the result #10505
2019-07-16 20:03:08 +02:00
Justin M. Keyes
1eea2d236f
Merge #10500 from ngortheone/pvs/V1028_misc1
2019-07-16 20:01:50 +02:00
Ihor Antonov
56bc0a8bed
PVS/V108: cast operands, not the result #10501
2019-07-16 19:58:30 +02:00
Justin M. Keyes
b53b3f7dac
Merge #10493 from ngortheone/pvs/V1028_getchar_918
2019-07-16 19:56:30 +02:00
Justin M. Keyes
b35ad86024
Merge #10391 from janlazo/vim-8.1.0495
...
vim-patch:8.1.{495,505,531,533,583,623,630,641,686,715,833,1012,1221,1651}
2019-07-16 19:52:23 +02:00
Ihor Antonov
b9a2b3f014
PVS/V1028: cast operands, not the result #10503
2019-07-16 19:50:01 +02:00
Ihor Antonov
96e87c5a63
lint
2019-07-16 08:32:09 -04:00
Ihor Antonov
6262d82d2f
pvs/V1028: cast operands, not the result
2019-07-16 08:28:50 -04:00
Justin M. Keyes
583c35714c
Merge #10520 'PVS/V1037: redundant case-branches'
2019-07-16 11:32:35 +02:00
Ihor Antonov
6316247da3
PVS/V1028: cast operands, not the result #10502
2019-07-16 11:23:58 +02:00
Björn Linse
8a3f8589a3
Merge pull request #10504 from bfredl/hl_def
...
highlight: expose builtin highlight groups using hl_group_set event
2019-07-16 10:17:29 +02:00
Daniel Hahler
6aab5715c5
third-party: busted 2.0.0-0 ( #10517 )
2019-07-16 09:15:50 +02:00
Jan Edmund Lazo
64f4ee39aa
vim-patch:8.1.0715: superfluous call to redraw_win_later()
...
Problem: Superfluous call to redraw_win_later().
Solution: Remove the call.
6f7e555f74
2019-07-15 23:07:41 -04:00
Jan Edmund Lazo
bf919454eb
vim-patch:8.1.0686: when 'y' is in 'cpoptions' yanking for the clipboard changes redo
...
Problem: When 'y' is in 'cpoptions' yanking for the clipboard changes redo.
Solution: Do not use the 'y' flag when "gui_yank" is TRUE. (Andy Massimino,
closes vim/vim#3760 )
5823f84dd0
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
5be40b9aad
vim-patch:8.1.0641: no check for out-of-memory when converting regexp
...
Problem: No check for out-of-memory when converting regexp.
Solution: Bail out when lalloc() returns NULL. (John Marriott)
c57463c9c6
2019-07-15 23:07:29 -04:00
Jan Edmund Lazo
eace147bb0
vim-patch:8.1.0630: "wincmd p" does not work after using an autocmd window
...
Problem: "wincmd p" does not work after using an autocmd window.
Solution: Store "prevwin" in aco_save_T. (Christian Brabandt, closes vim/vim#3690 )
a42df5934b
2019-07-15 23:07:29 -04:00
