Problem: Recover test hangs in the GUI.
Solution: Add g:skipped_reason to skip a _nocatch_ test.
776b954622
Now always skip the test as test_override() is N/A.
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Process id may be invalid.
Solution: Use sysinfo.uptime to check for recent reboot. (suggested by Hugo
van der Sanden, closesvim/vim#7947)
f52f0606ed
test_override() is N/A.
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Swap file test fails.
Solution: Check for a very high process ID instead of one, which should be
running.
6738fd2000
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Detecting if the process of a swap file is running fails if the
process is owned by another user.
Solution: Check for the ESRCH error. (closesvim/vim#8436)
44dea9da4b
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: MS-Windows: swap file test sometimes fails.
Solution: Use a more reliable way to change the process ID. When "timeout"
fails use "ping" to wait up to ten minutes. (Ken Takata,
closesvim/vim#7365)
5ee0981fb5
Problem: Coverity warns for possibly using not NUL terminated string.
Solution: Put a NUL in b0_hname just in case.
e79cdb69a4
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Swap file test is a little flaky.
Solution: Don't set a byte to a fixed value, increment it.
c6ca9f3a29
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: It is easy to make mistakes when cleaning up swap files after the
system crashed.
Solution: Warn for the process still running after recovery. Do not
automatically delete a swap file created on another system.
(David Fries, closesvim/vim#7273)
f883508e36
The needs:response label should only be added and removed manually, and
the action's behavior of removing the label on any activity (e.g. title
change, removing reviewers) is unwanted.
Allow Include What You Use to remove unnecessary includes and only
include what is necessary. This helps with reducing compilation times
and makes it easier to visualise which dependencies are actually
required.
Work on https://github.com/neovim/neovim/issues/549, but doesn't close
it since this only works fully for .c files and not headers.
Problem: Using freed memory after SpellFileMissing autocmd uses bwipe.
Solution: Bail out if the window no longer exists.
c3d27ada14
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: A silent mapping may cause dots on the command line.
Solution: Don't show dots for completion if they are not going to be removed
again. (closesvim/vim#11501)
698a00f55d
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Coverity warns for dead code.
Solution: Remove the dead code.
b298fe6cba
Nvim has refactored this function and does not have the dead code.
Co-authored-by: Bram Moolenaar <Bram@vim.org>
Problem: Various code not used when features are disabled.
Solution: Add #ifdefs. (Dominique Pellé, closesvim/vim#9491)
748b308eeb
N/A patches for version.c:
vim-patch:8.2.2186: Vim9: error when using 'opfunc'
Problem: Vim9: error when using 'opfunc'.
Solution: Do not expect a return value from 'opfunc'. (closesvim/vim#7510)
5b3d1bb0f5
Problem: Insert complete code uses global variables.
Solution: Make variables local to the file and use accessor functions.
(Yegappan Lakshmanan, closesvim/vim#9470)
d94fbfc74a
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
Problem: Code is indented more than needed.
Solution: Return early. (Yegappan Lakshmanan, closesvim/vim#11538)
623e94e138
Only port the first change to init_history() as Nvim has refactored it.
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
This is essentially a convenience wrapper around the `pending()`
function, similar to `skip_fragile()` but more general-purpose.
Also remove `pending_win32` function as it can be replaced by
`skip(iswin())`.
Problem: Duplicate arguments are not always detected.
Solution: Expand to full path before comparing arguments. (Nir Lichtman,
closesvim/vim#11505, closesvim/vim#9402)
b3052aa1b5
Co-authored-by: Nir Lichtman <nir@lichtman.org>
Problem: col() and charcol() only work for the current window.
Solution: Add an optional winid argument. (Yegappan Lakshmanan,
closesvim/vim#11466, closesvim/vim#11461)
4c8d2f02b3
Cherry-pick test_functions.vim change from patch 8.2.0633.
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
Problem: Bogus error when string used after :elseif.
Solution: Do not consider a double quote the start of a comment.
(closesvim/vim#11534)
28c56d5013
Co-authored-by: Bram Moolenaar <Bram@vim.org>
