Commit Graph

2225 Commits

Author SHA1 Message Date
Eliseo Martínez
389470bd14 Fix substitute newline: Memory functions: Improve style.
`try_malloc` was changed in 8bb2c2c074 to
avoid a warning when size is 0. Then, this improves some things on that:

- Use local vars instead of changing parameters.
- Homogenize style for other related functions.
2014-11-24 17:20:09 +01:00
Justin M. Keyes
1c25f1d947 Merge pull request #1525 from justinmk/clipboardX
clipboard: check for X on every invocation
2014-11-23 17:53:12 -05:00
Justin M. Keyes
c10f7e1c62 clipboard: check for X on every invocation
xsel and xcopy may be available even if a valid X display is not. Also,
the availability of X may change at any time, so check on each
invocation.

Closes #1509.
2014-11-23 19:09:32 +00:00
Thiago de Arruda
f4e125de2d Merge PR #1527 'Add gdbserver support on helpers.lua' 2014-11-23 09:14:04 -03:00
Thiago de Arruda
aa22612112 test: Add gdbserver support on helpers.lua
The $GDB env var can be set to run tests under gdbserver. If $VALGRIND is also
set, it will add the --vgdb=yes command-line option to valgrind instead of
starting gdbserver.
2014-11-23 08:56:43 -03:00
Justin M. Keyes
4b89903a22 Merge pull request #1520 from elmart/fix-func-tests
Fix functional tests failing on OSX.
2014-11-22 15:25:13 -05:00
John Szakmeister
412c714448 Merge pull request #1521 from three-comrades/valgrind
Fix Makefile for running valgrind with old tests.
2014-11-22 07:48:54 -05:00
Julian Mehne
6b5785b149 Fix Makefile for running valgrind with old tests. 2014-11-22 13:07:04 +01:00
Justin M. Keyes
699a19ab30 Merge pull request #1513 from fwalch/vimpatch-script
Add helper script for porting vim patches.
2014-11-21 16:36:12 -05:00
Eliseo Martínez
1f2c197ebe Fix functional-test-105 failure in OSX.
See https://github.com/neovim/neovim/issues/1519 for failure report.

Cause    : In OSX, /tmp is a symbolic link to /private/tmp, which causes
           expected and got results different because of implicit
           resolution.
Solution : Resolve path before setting expected value.
2014-11-21 22:08:16 +01:00
Thiago de Arruda
af5eaf22c5 Merge PR #1518 'Improve functional tests and perform explicit K_EVENT handling' 2014-11-21 17:08:29 -03:00
Thiago de Arruda
f09a33bbc1 event: No longer process K_EVENT automatically
Two new functions, `event_enable_deferred()`/`event_disable_deferred()` have to
be called by code that is capable of handling asynchronicity. User-dialog states
like "press ENTER to continue" or the swap file confirmation no longer will
generate K_EVENT.
2014-11-21 15:41:02 -03:00
Thiago de Arruda
230c935e73 test: Fix problems in job_spec.lua
Nvim wasn't exiting cleanly in some job tests due to errors.

This can't be noticed until the next commit, which will perform a refactoring to
selectively process K_EVENT, so the `qa!` command executed at the end of each
test blocks forever if there are errors which require the user to press ENTER(in
that state Nvim no longer will process events).
2014-11-21 15:39:04 -03:00
Thiago de Arruda
179c51319d test: Refactor functional helpers to use vim_input
The vim_input function accepts raw terminal input and so is better to emulate
real user, especially because it is not deferred as vim_feedkeys.

Using this function required a number of changes:

- expect() was refactored to use curbuf_contents()
- The vim_eval function in request() was moved to curbuf_contents(). For most
  cases this is enough(we only care for synchronizing api calls with user input
  when verifying buffer contents).
- <C-@>(NUL) is preprocessed before being passed to replace_termcodes.
- Legacy test 4 had a bug that only became visible when using vim_input, it is
  fixed now.
- An extra blank line deletion was required for test 101

The last two items show that vim_feedkeys because it is not 100% equivalent to
receiving terminal input.
2014-11-21 15:39:04 -03:00
Thiago de Arruda
e15485c5d6 input: Refactor to ensure user input has higher priority 2014-11-21 15:39:04 -03:00
Florian Walch
b27eadbcf2 Add helper script for porting vim patches. 2014-11-21 16:11:32 +01:00
Thiago de Arruda
2c29b20af7 Merge PR #1515 'Refer to plugins running outside Nvim as "remote plugins"' 2014-11-21 10:38:57 -03:00
Thiago de Arruda
6b17082d3c runtime: Refer to plugins running outside Nvim as "remote plugins"
- Rename autoload/rpc to autoload/remote
- External plugins are now remote plugins
- External plugins directory is "rplugin"
2014-11-21 10:11:42 -03:00
Justin M. Keyes
9a774e726c Merge pull request #1373 from elmart/fix-outofdate-doc
Fix outdated doc: Connecting to nvim through python REPL.
2014-11-21 06:44:50 -05:00
Eliseo Martínez
f7b5fd6f3f Fix warnings: Fix outdated doc: Connecting to nvim through python REPL.
After neovim/python-client@b8b48bbe8f,
docs were no longer relevant.
2014-11-21 12:35:51 +01:00
Thiago de Arruda
bc1b9c1d90 Merge PR #1420 'Migrate legacy tests (2nd batch)' 2014-11-20 21:51:00 -03:00
Rainer Borene
df5a17fb51 legacy tests: migrate test105 2014-11-20 21:06:37 -03:00
Rainer Borene
da3ade6a59 legacy tests: migrate test26 2014-11-20 21:06:37 -03:00
Rainer Borene
021d9bdcc0 legacy tests: migrate test101 2014-11-20 21:06:37 -03:00
Rainer Borene
50876c2f70 legacy tests: migrate test75 2014-11-20 21:06:37 -03:00
Rainer Borene
a93d370c75 legacy tests: migrate test51 2014-11-20 21:06:37 -03:00
Rainer Borene
c9159586b8 legacy tests: migrate test43 2014-11-20 21:06:37 -03:00
Rainer Borene
bbd95c0514 legacy tests: migrate test33 2014-11-20 21:06:37 -03:00
Rainer Borene
8c872a945e legacy tests: migrate test67 2014-11-20 21:06:37 -03:00
Rainer Borene
7fc5d6fc8e legacy tests: migrate test66 2014-11-20 21:06:37 -03:00
Rainer Borene
963a146e8b legacy tests: migrate test25 2014-11-20 21:06:37 -03:00
Rainer Borene
8ca8a0da08 legacy tests: migrate test104 2014-11-20 21:06:37 -03:00
Rainer Borene
e0332e7f7c legacy tests: implement :source helper method. 2014-11-20 21:06:37 -03:00
Rainer Borene
1732615290 legacy tests: remove test21 files 2014-11-20 21:06:37 -03:00
Rainer Borene
c152cdd0f3 legacy tests: migrate test5 2014-11-20 21:06:37 -03:00
Thiago de Arruda
2f02f6c535 Merge PR #1504 'Change external plugin dir, manifest and improve docs' 2014-11-20 16:45:44 -03:00
Thiago de Arruda
35017bd954 doc: Add nvim_provider/external_plugin to doc Makefile 2014-11-20 16:03:34 -03:00
Thiago de Arruda
ea7a5c7f05 doc: Update external plugin documentation 2014-11-20 15:59:31 -03:00
Thiago de Arruda
f6c2c7bf1f runtime: Prepend the vimrc filename to the external plugin manifest
This is required to support multiple vimrcs with each having it's own set of
installed external plugins.
2014-11-20 08:48:29 -03:00
Thiago de Arruda
58ba2241e9 runtime: Change external plugin directory to "external-plugin" 2014-11-20 08:46:23 -03:00
Justin M. Keyes
32ec851270 Merge pull request #1488 from fwalch/invert-wconversion
Invert -Wconversion handling & fix some warnings.
2014-11-19 16:12:15 -05:00
Florian Walch
2b0d9bdeac Wconversion: Fix warnings in digraph.c. 2014-11-19 17:21:21 +01:00
Florian Walch
d2338ce397 Wconversion: Fix warnings in cursor_shape.c. 2014-11-19 17:21:21 +01:00
Florian Walch
96b31ca048 CMake: Set -Wconversion by default. 2014-11-19 17:21:21 +01:00
Justin M. Keyes
e8e3e6e798 Merge pull request #1478 from elmart/clang-analysis-fixes-4
Fix clang analysis warnings. (4)
2014-11-19 09:40:55 -05:00
Eliseo Martínez
7aa7ce253d Fix warnings: eval.c: f_rpcrequest(): Garbage value: MI.
Problem    : Assigned value is garbage or undefined @ 12578.
Diagnostic : Multithreading issue.
Rationale  : Error can only occur if global `provider_call_nesting` is
             changed while function is executing.
Resolution : Use local copy of global.
2014-11-18 22:20:39 +01:00
Eliseo Martínez
ee134fc698 Fix warnings: screen.c: screenalloc(): Np arg (2): MI.
Problems   : Null pointer argument in call to memory copy function
             @ 6465.
             Null pointer argument in call to memory copy function
             @ 6475.
Diagnostic : Multithreading issues.
Rationale  : Problem occurs if globals `enc_utf8` and `enc_dbcs` are
             modified while function is executing.
Resolution : Use local copy of globals.
2014-11-18 22:00:03 +01:00
Eliseo Martínez
5c00f8c132 Fix warnings: eval.c: do_return(): Np dereference: FP.
Problem    : Dereference of null pointer @ 18841.
Diagnostic : False positive.
Rationale  : Suggested error path takes `reanimate` branch at 18827,
             assigning `rettv = current_funccal->rettv`. Then,
             inmediately after, it supposes rettv is null, which cannot
             happen, since current_funccal->rettv should always be non
             null.
Resolution : Assert current_funccal->rettv non null.
2014-11-18 22:00:03 +01:00
Eliseo Martínez
97be8d45f4 Fix warnings: eval.c: add_nr_var(): Out of bounds: FP.
Problem    : Out-of-bound array access @ 18737.
Diagnostic : False positive.
Rationale  : Situation is intentional. `dictitem_T` is a prefix all dict
             items whill share, but actual size of each item will be
             different depending on its key length. `di_key` array field
             is declared of size 1 just to have a field name, but real
             size will vary for each item.
Resolution : Make analyzer ignore it.
             This could be refactored to use C99-allowed variable length
             arrays, but eval.c is bound to dissappear, so no effort is
             done in that sense.
2014-11-18 22:00:02 +01:00
Eliseo Martínez
3bf32fe43f Fix warnings: eval.c: call_user_func(): Out of bounds: FP.
Problem    : Out-of-bound array access @ 18429.
Diagnostic : False positive.
Rationale  : Situation is intentional. `dictitem_T` is a prefix all dict
             items whill share, but actual size of each item will be
             different depending on its key length. `di_key` array field
             is declared of size 1 just to have a field name, but real
             size will vary for each item.
Resolution : Make analyzer ignore it.
             This could be refactored to use C99-allowed variable length
             arrays, but eval.c is bound to dissappear, so no effort is
             done in that sense.
2014-11-18 22:00:02 +01:00