Commit Graph

2012 Commits

Author SHA1 Message Date
Xu Cheng
0bc347d85d Homebrew: move formula to neovim/homebrew-neovim 2014-11-09 20:14:01 +08:00
John Szakmeister
07775c07c0 Merge pull request #1411 from xu-cheng/homebrew-formula
Let homebrew handle external resources download
2014-11-07 08:50:13 -05:00
Thiago de Arruda
6f8c916d84 Merge PR #1424 'Only force-close stdout/stderr when the job exits' 2014-11-07 09:30:44 -03:00
Xu Cheng
9065898264 build: don't download and extract tarball if source is already present
When building under Homebrew, we want to let Homebrew manage downloading and
extracting the tarballs.
2014-11-07 20:19:00 +08:00
Xu Cheng
871e353fa8 Homebrew: let Homebrew handle external resources download 2014-11-07 20:18:28 +08:00
Thiago de Arruda
d3f81424e5 job: Only force-close stdout/stderr when the job exits
stdout/stderr should only be closed after the job truly exits, or else we can
lose data sent by it.
2014-11-07 09:12:42 -03:00
John Szakmeister
f7a468c1e7 Merge pull request #1414 from xu-cheng/sha1_md5
Prefer to SHA1 other than MD5 in third-party downloads
2014-11-07 05:26:46 -05:00
Xu Cheng
77fc32b311 Prefer to SHA1 other than MD5 in third-party downloads
If CMake version is less than 2.8.11, fallback to MD5
2014-11-07 16:07:26 +08:00
Thiago de Arruda
7edd68e635 Merge PR #1422 'Pass --show-possibly-lost=no to valgrind' 2014-11-07 02:01:48 -03:00
Thiago de Arruda
88a49148b3 test: Pass --show-possibly-lost=no to valgrind in helpers.lua
This command-line flag will suppress all warnings about interior pointers,
which are used in hashtab.c.
2014-11-07 01:40:18 -03:00
Thiago de Arruda
7ded32ad3b Merge PR #1421 'Improve test error handling and reporting' 2014-11-07 01:03:25 -03:00
Thiago de Arruda
168a46fd31 test: Improve test environment setup and error handling/reporting
During test setup, we used to call a vimscript function(BeforeEachTest) that
attempted to restore Nvim to it's initial state as much as possible in order to
provide a clean environment for running new tests. This approach has proven to
be unreliable, as some tests leave state that can affect other tests, eventually
causing failures that are difficult to debug.

This commit changes the 'clear' function so it will restart Nvim every time it
is called, which is a slower, but more reliable solution that will simplify
spotting bugs in the future.

Some other improvements/fixes were also performed:

- Whenever an error is detected in a handler passed to "run()", the event loop
  will be stopped and the error will be propagated to the main thread.
- Errors and the "cleanup()" function will always send a quit command to the
  current Nvim instance. This should prevent memory starvation when running
  tests under valgrind(where each Nvim instance can consume a lot of memory).
- Fixed a wrong assertion in server_requests_spec.lua. Previously the failure
  was undetected in a notification handler.
- Fixed some tests to expect fully clean registers. The deleted cleanup function
  used to put an empty string in every register, but that resulted in a extra
  line being added.
2014-11-07 00:55:58 -03:00
Thiago de Arruda
3e78fc9faf deps: Upgrade to latest version of lua-client 2014-11-06 22:45:15 -03:00
Justin M. Keyes
8455fd5e33 Merge pull request #1340 from elmart/remove-long_u
Remove project-specific integer types: long_u. (2)
2014-11-06 17:09:39 -05:00
Eliseo Martínez
8386255803 Review: Remove long_u: memfile: Add to clint. 2014-11-06 22:53:43 +01:00
Eliseo Martínez
09d4133a64 Review: Remove long_u: memfile: Refactor: blocknr_T: long -> int64_t.
Replace long with int64_t.
Apart from being convenient, not using long is required by clint.
2014-11-06 22:53:43 +01:00
Eliseo Martínez
7d4ec612b1 Review: Remove long_u: memfile: Refactor: int -> bool.
Replace int with bool where appropriate.
2014-11-06 22:53:43 +01:00
Eliseo Martínez
96e7f229a5 Review: Remove long_u: memfile: Refactor: bhdr_T.bh_data: char_u* -> void*.
This, in addition to being more correct, allows removing a lot of
explicit casts.
2014-11-06 22:53:42 +01:00
Eliseo Martínez
844d64e9ff Review: Remove long_u: memfile: Refactor: mf_hashtab_T.mht_fixed: Remove.
Unused since 457bb26151.
2014-11-06 22:53:42 +01:00
Eliseo Martínez
200f8ee0e5 Review: Remove long_u: memfile: Refactor: long_u -> size_t.
- memfile_defs.h:
    * hashtab_T: mht_mask: long_u -> size_t.
        Masks are used to truncate keys to a value adequate for an index
        in the array of entries. Value of the mask plus one is the
        current size of the array. Both of those reasons imply the
        soundness of size_t for this type.
    * hashtab_T: mht_count: long_u -> size_t.

- memfile.c:
    * total_mem_used: long_u -> size_t.
    * mf_hash_free_all: idx: long_u -> size_t.
    * mf_hash_add_item: idx: long_u -> size_t.
    * mf_hash_find: idx: long_u -> size_t.
    * mf_hash_grow: i: long_u -> size_t.
    * mf_hash_grow: j: long_u -> size_t.
2014-11-06 22:53:42 +01:00
Eliseo Martínez
7ffed667d4 Review: Remove long_u: memfile: Enable -Wconversion.
- Add memfile.c to converted files list.
- Fix conversion issues:
    * bhdr_T          : bh_page_count : int  -> unsigned.
    * bhdr_T          : bh_flags      : char -> unsigned.
    * mf_new()        : page_count    : int  -> unsigned.
    * mf_get()        : page_count    : int  -> unsigned.
    * mf_release()    : page_count    : int  -> unsigned.
    * mf_alloc_bhdr() : page_count    : int  -> unsigned.
    * mf_trans_add()  : page_count    : int  -> unsigned.
    * mf_put()        : flags         : int  -> unsigned.
2014-11-06 22:53:42 +01:00
Eliseo Martínez
fce201e656 Review: Remove long_u: memfile: Cleanup: Fix naming inconsistencies.
- Drop '_S' suffix for struct names.
- Make struct names match corresponding type's name (just removing '_S' suffix).
- Rename NR_TRANS type/struct (just ugly).
2014-11-06 22:53:41 +01:00
Eliseo Martínez
a69b2e3c40 Review: Remove long_u: memfile: Cleanup: Others.
memfile_defs.h:
- Inline struct definitions in typedefs.
- Move memfile_T definition to this file (weirdly, was in buffer_defs.h).

memfile.c:
- Use C99 style variable declarations. This is, move variable declarations as
  near to first-usage point as possible).
- Modernize old-style function declarations.
- Fix indent at some places (some multiline expressions and the like).
2014-11-06 22:53:41 +01:00
Eliseo Martínez
8fb4097fc6 Review: Remove long_u: memfile: Cleanup: Comments.
- Restyle comments (/// when appropiate, // otherwise).
- Improve comments (add new comments, augment/clarify existing ones).
2014-11-06 22:53:40 +01:00
Eliseo Martínez
e7a863e12c Remove long_u: eval: Replace with size_t.
Note: No effort is done on refactoring anything in eval module, as it
      will be eventually dropped.
2014-11-06 22:19:33 +01:00
Justin M. Keyes
7c7874d11b Merge pull request #1412 from fwalch/startup-help
version: Refer to nvim help on startup screen.
2014-11-06 09:45:30 -05:00
Florian Walch
724a53306f version: Refer to nvim help on startup screen. 2014-11-06 13:37:15 +01:00
Justin M. Keyes
37d608b8c1 Merge pull request #1370 from aktau/enable-iconv
re-enable iconv
2014-11-06 07:14:36 -05:00
Thiago de Arruda
4cc26fba24 Merge PR #1398 'Tests and msgpack rpc improvements' 2014-11-06 04:36:46 -03:00
Thiago de Arruda
d83868fe90 channel: Delay notifications to avoid client race conditions
It is currently possible for a client to send a response that doesn't match the
current server->client request(at the top of the stack). This commit fixes that
by delaying notifications to until the first `channel_send_call` invocation
returns.

Also remove the "call stack" size check, vim will already break if the call
stack goes too deep.
2014-11-06 04:22:06 -03:00
Thiago de Arruda
8979ede45d test: Add more valgrind "possibly lost" suppressions
These valgrind entries are false positives because vim uses interior pointers.
2014-11-06 04:22:06 -03:00
Thiago de Arruda
117d3db6d7 test: Simplify/fix options_spec.lua
The options_spec.lua suite has one purpose: Check if the :options commands will
throw any exception(:options is implemented by $VIMRUNTIME/optwin.vim). For this
it is best to use the `vim_command` API function since it will automatically
catch exceptions and forward them via msgpack-rpc.

Also, the option window seems to affect other tests, so call `restart` in the
teardown hook.
2014-11-06 04:21:57 -03:00
Nicolas Hillegeer
8c5efd62ac iconv: re-enable
This seems to have been disabled in the transition from vim to neovim,
re-enable it.
2014-11-06 00:18:26 +01:00
Thiago de Arruda
5e5525a78b test: Set VIMRUNTIME before running tests
This is required for testing scripts under the 'runtime' directory
2014-11-05 14:02:04 -03:00
John Szakmeister
3972715ce7 Merge pull request #1397 from fwalch/fix-test_file
Restore TEST_FILE functionality for running individual tests.
2014-11-05 09:33:03 -05:00
Florian Walch
afa5831d73 CMake: Fix running individual (functional/unit) test. 2014-11-05 13:57:29 +01:00
John Szakmeister
e0628dab49 Merge pull request #1395 from jszakmeister/fix-run-functional-tests
build: fix running of functional tests directly with CMake
2014-11-05 07:53:53 -05:00
John Szakmeister
5ba1d980fb build: fix running of functional tests directly with CMake
If you aren't just building everything into build/, then the functional
tests fail because they can't find the nvim executable.  Let's pass in
the location of the nvim executable, and set NVIM_PRG environment
variable accordingly.
2014-11-05 07:26:35 -05:00
John Szakmeister
d1675de0a9 Merge pull request #1392 from fwalch/fix-build-warnings
Fix build warnings.
2014-11-05 06:46:49 -05:00
Florian Walch
b904c33e41 CMake: Rename target "test" to "functionaltest".
Remove build warning:

    The target name "test" is reserved or not valid for certain CMake
    features, such as generator expressions, and may result in undefined
    behavior.
2014-11-05 11:54:20 +01:00
Florian Walch
5714afc11e CMake: Modify _FORTIFY_SOURCE only for release builds.
Remove build warning for Debug builds:

    # warning _FORTIFY_SOURCE requires compiling with optimization (-O)
2014-11-05 11:54:15 +01:00
Florian Walch
58b87579cf CMake: Pass build type CFLAGS to header generator. 2014-11-05 11:54:05 +01:00
John Szakmeister
83d9b36214 Merge pull request #1390 from jszakmeister/turn-down-fortify-source
build: turn down the _FORTIFY_SOURCE level on gcc >= 4.0
2014-11-05 04:06:40 -05:00
John Szakmeister
64ea00299d build: turn down the _FORTIFY_SOURCE level on gcc >= 4.0 2014-11-05 03:53:31 -05:00
Thiago de Arruda
04633e3e6b Merge PR #1328 'Migrate legacy tests' 2014-11-04 12:59:09 -03:00
Rainer Borene
a695c87863 legacy tests: migrate test21 2014-11-04 12:57:33 -03:00
Rainer Borene
2d8d4285e4 legacy tests: migrate test7 2014-11-04 12:57:33 -03:00
Rainer Borene
ef08a2c0df legacy tests: migrate test6 2014-11-04 12:57:33 -03:00
Rainer Borene
38bef424a2 legacy tests: migrate test28 2014-11-04 12:57:33 -03:00
Rainer Borene
ca0a55c2a9 legacy tests: migrate test20 2014-11-04 12:57:33 -03:00