Commit Graph

14507 Commits

Author SHA1 Message Date
Daniel Hahler
ed11721b6b
tests: unit: fix preprocess: pass -m32 for 32bit ABI (#11073) 2019-09-22 14:57:44 +02:00
Björn Linse
bb90e41ee2
Merge pull request #11049 from bfredl/rulermsg
screen: missing redraw/highlight for ruler in message area
2019-09-22 12:14:07 +02:00
Björn Linse
f316916758 screen: missing redraw/highlight for ruler in message area 2019-09-22 09:38:52 +02:00
erw7
028d76e5d5 env: use putenv_s for LC_ALL, LANG, etc. #11050
Problem:  ":lang messages en_US.UTF-8" no longer overrides the language
          detected from the environment (at startup).
Solution: In os_setenv, special-case "LC_ALL", "LANG", et al. to use
          putenv_s instead of uv_os_setenv.

fixes #11045
2019-09-22 00:02:28 -07:00
Justin M. Keyes
c534ab8447
Merge #11034 from zwegner/precedes
Fix "precedes" listchar behavior in wrap mode
2019-09-21 23:48:08 -07:00
Justin M. Keyes
1654932498 vim-patch:8.1.2060: "precedes" in 'listchars' not used properly
(Credit: Zach Wegner, https://github.com/neovim/neovim/pull/11034)

Problem:    "precedes" in 'listchars' not used properly.
Solution:   Correctly handle the "precedes" char in list mode for long lines.
bffba7f704
2019-09-21 22:13:55 -07:00
Zach Wegner
18e5869f56 Fix "precedes" listchar behavior in wrap mode
Previously, the "precedes" character would be rendered on every row
when w_skipcol > 0 (i.e., when viewing a single line longer than the
entire screen), instead of just on the first row. Make sure to only
render it on the first row in this case.

Add a test for this behavior.

Fix documentation for the "precedes" character, which erroneously
stated that it was only active when wrap mode was off.
2019-09-21 22:09:52 -07:00
Yoshio S
45447e3b64 checkhealth: skip python checks if intentionally disabled #11044
close #11040
2019-09-21 16:17:22 -07:00
Daniel Hahler
ad0f97f412 vim-patch:8.1.2055: profile: adjust line format #11058
Problem:    Not easy to jump to function line from profile.
Solution:   Use "file:99" instead of "file line 99" so that "gf" works.
            (Daniel Hahler, closes vim/vim#4951)
181d4f58cc
2019-09-21 14:18:56 -07:00
Justin M. Keyes
fd82ce4a3a
Merge #11060 from janlazo/vim-8.1.1783
vim-patch:8.0.{1109,1529,1539,1621,1733,1771,1776},8.1.{1783,2054,2058}
2019-09-21 14:07:50 -07:00
Jan Edmund Lazo
b3e56957f8 vim-patch:8.1.0460: assert_fails() message argument #11051
Problem:    assert_fails() does not take a message argument
Solution:   Add the argument.
1307d1c003
2019-09-21 14:03:46 -07:00
Jan Edmund Lazo
111d34849a
vim-patch:8.0.1621: using invalid default value for highlight attribute
Problem:    Using invalid default value for highlight attribute.
Solution:   Use zero instead of -1.
6185903e3d
2019-09-21 11:07:59 -04:00
Jan Edmund Lazo
eb3888a322
vim-patch:8.0.1529: assert_equalfile() does not close file descriptors
Problem:    Assert_equalfile() does not close file descriptors. (Coverity)
Solution:   Close the file descriptors.
3049418f3d
2019-09-21 08:43:08 -04:00
Jan Edmund Lazo
2a7ffc6567
vim-patch:8.0.1776: in tests, when WaitFor() fails it doesn't say why
Problem:    In tests, when WaitFor() fails it doesn't say why.
Solution:   Turn a few more WaitFor() into WaitForAssert().
0e9d1ae321
2019-09-21 08:43:07 -04:00
Jan Edmund Lazo
3878b0822e
vim-patch:8.0.1771: in tests, when WaitFor() fails it doesn't say why
Problem:    In tests, when WaitFor() fails it doesn't say why. (James McCoy)
Solution:   Add WaitForAssert(), which produces an assert error when it fails.
50182fa84e
2019-09-21 08:43:07 -04:00
Jan Edmund Lazo
7cffc87868
vim-patch:8.0.1733: incomplete testing for completion fix
Problem:    Incomplete testing for completion fix. (Lifepillar)
Solution:   Add a test with CTRL-P.
bad0ce7b26
2019-09-21 08:43:07 -04:00
Jan Edmund Lazo
ca11662515
vim-patch:8.0.1539: no test for the popup menu positioning
Problem:    No test for the popup menu positioning.
Solution:   Add a screendump test for the popup menu.
6bb2cdfe60
2019-09-21 08:43:07 -04:00
Jan Edmund Lazo
b853b6e4ea
vim-patch:8.0.1109: timer causes error on exit from Ex mode
Problem:    Timer causes error on exit from Ex mode. (xtal8)
Solution:   save and restore the ex_pressedreturn flag. (Christian Brabandt,
            closes vim/vim#2079)
f5291f301e
2019-09-21 08:43:07 -04:00
Jan Edmund Lazo
42a0513095
vim-patch:8.1.2058: function for ex command is named inconsistently
Problem:    Function for ex command is named inconsistently.
Solution:   Rename do_marks() to ex_marks().
4bd782339e
2019-09-21 08:43:06 -04:00
Jan Edmund Lazo
1c71a3c657
vim-patch:8.1.2054: compiler test for Perl may fail
Problem:    Compiler test for Perl may fail.
Solution:   Accept any error line number. (James McCoy, closes vim/vim#4944)
cebfcffa40
2019-09-21 08:43:06 -04:00
Jan Edmund Lazo
690cd4f012
vim-patch:8.1.1783: MS-Windows: compiler test may fail when using %:S
Problem:    MS-Windows: compiler test may fail when using %:S.
Solution:   Reset 'shellslash'.
dff2adc8dd
2019-09-21 08:43:06 -04:00
Björn Linse
d6f658e38f
Merge pull request #11069 from bfredl/virtualcol
screen: fix vcol counting with virtual text.
2019-09-21 10:40:41 +02:00
Björn Linse
828a6e7568 screen: fix vcol counting with virtual text. Fixes #9941 2019-09-21 09:39:10 +02:00
Daniel Hahler
afd576ee94
Merge pull request #11057 from blueyed/test-indent
Vim patches for indent tests
2019-09-19 00:12:45 +02:00
Daniel Hahler
660b452440 vim-patch:8.1.2056: "make test" for indent files doesn't cause make to fail
Problem:    "make test" for indent files doesn't cause make to fail.
Solution:   Exit the script with ":cquit". (Daniel Hahler, closes vim/vim#4949)
cd67059c0c
2019-09-18 22:59:13 +02:00
Daniel Hahler
0e75a9eead Update runtime/indent/testdir to latest Vim runtime
Several runtime updates ignored the non-existing files.
2019-09-18 22:59:13 +02:00
Daniel Hahler
48b2d21d5e vim-patch:8.1.1213: "make clean" in top dir does not cleanup indent test output
Problem:    "make clean" in top dir does not cleanup indent test output.
Solution:   Clean the indent test output.  Do not rely on the vim executable
            for that. (closes vim/vim#4307)
e13a3901ca
2019-09-18 22:46:47 +02:00
Daniel Hahler
10c050caf9 vim-patch:8.1.0599: without the +eval feature the indent tests don't work
Problem:    Without the +eval feature the indent tests don't work.
Solution:   Skip the body of the tests.
eeed665b0e
2019-09-18 22:38:37 +02:00
Daniel Hahler
865aaa031a vim-patch:8.1.0576: indent script tests pick up installed scripts
Problem:    Indent script tests pick up installed scripts.
Solution:   Use current runtime indent scripts.
30700cd5ff
2019-09-18 22:38:15 +02:00
Daniel Hahler
b466f0e114 vim-patch:8.1.0545: when executing indent tests user preferences interfere
Problem:    When executing indent tests user preferences interfere.
Solution:   Add "--clean".
dc2f73a698
2019-09-18 22:37:54 +02:00
Daniel Hahler
7f59f5b104 vim-patch:8.1.0496: no tests for indent files
Problem:    No tests for indent files.
Solution:   Add a mechanism for running indent file tests.  Add a first test
            for Vim indenting.
c0fe4978f2
2019-09-18 22:37:25 +02:00
Daniel Hahler
1070c092c7
win_update: fix redraw regression (#11027)
Before 6e9ea5adc `win_ins_lines` would return `FAIL` for `i/line_count == 0`.

Handle this by checking it in the outer `if`.

Ref: https://github.com/neovim/neovim/commit/6e9ea5ad#commitcomment-35084669
2019-09-18 18:22:38 +02:00
Daniel Hahler
d478542110
health#provider: fix duplicated output/stderr (#11048)
Ref: https://github.com/neovim/neovim/pull/11047#issuecomment-532268826
2019-09-18 18:21:44 +02:00
Justin M. Keyes
618045685b
Merge #11035 from janlazo/vim-8.0.1523
vim-patch:8.0.{1523,1770}
2019-09-17 21:49:45 -07:00
Jan Edmund Lazo
8db9e82e3e
vim-patch:8.0.1770: assert functions don't return anything
Problem:    Assert functions don't return anything.
Solution:   Return non-zero when the assertion fails.
65a5464985
2019-09-16 23:42:44 -04:00
Jan Edmund Lazo
792c290343
vim-patch:8.0.1523: cannot write and read terminal screendumps
Problem:    Cannot write and read terminal screendumps.
Solution:   Add term_dumpwrite(), term_dumpread() and term_dumpdiff().
            Also add assert_equalfile().
d96ff16511
2019-09-16 21:36:46 -04:00
Daniel Hahler
0b71bb73e8
tests: improve error message with literat "~" directory (#11032) 2019-09-17 00:39:33 +02:00
Daniel Hahler
4b2d7bb5ea
tests: fix flaky 'scrollback' option deletes lines (only) if necessary (#11003)
Using `screen:expect` with the complete grid appears to fix its
flakiness.

Fixes https://github.com/neovim/neovim/issues/10723.
2019-09-16 19:17:07 +02:00
Daniel Hahler
4df38ec9df
server_requests_spec: fix assertion, pass Lua paths via args (#10875)
This makes it pick up the nvim Luarocks module properly when not
installed via third-party.
2019-09-16 19:16:39 +02:00
Justin M. Keyes
8f3d0276ee release.sh [ci skip] 2019-09-15 23:08:40 -07:00
Justin M. Keyes
60e0000c5d nvim.appdata.xml [ci skip] 2019-09-15 19:44:11 -07:00
Justin M. Keyes
f9d1e788af CI/AppVeyor: revert whitelist
revert 6b028ec5f2 #10746

This seems to skip tags also, which breaks our release automation.
From the AppVeyor logs:

    2019-09-15 17:25:00.232 Warning Commit "1f76c4af" of branch "master" skipped as commit message contains either "[skip ci]" or "[ci skip]" or "[skip appveyor]"
    2019-09-15 17:20:24.152 Warning Commit "baa5263b" skipped as branch "stable" is not in white-list
    2019-09-15 17:20:03.163 Warning Commit "6cb5ffc0" skipped as branch "release-0.4" is not in white-list
    2019-09-15 17:20:02.977 Warning Commit "baa5263b" skipped as branch "v0.4.1" is not in white-list
    2019-09-15 16:35:38.810 Warning Commit "31956372" of branch "master" skipped as commit message contains either "[skip ci]" or "[ci skip]" or "[skip appveyor]"
    2019-09-15 16:28:35.237 Warning Commit "e2cc5fe0" skipped as branch "stable" is not in white-list
    2019-09-15 16:28:17.814 Information Build version 31489 created
    2019-09-15 16:28:16.364 Warning Commit "e2cc5fe0" skipped as branch "v0.4.0" is not in white-list
2019-09-15 17:36:17 -07:00
Justin M. Keyes
c410440edc fix api_level_6.mpack
This was generated incorrectly in the 0.4.1 release, fixed in the 0.4.1
release.
2019-09-15 17:28:42 -07:00
Justin M. Keyes
1f76c4af13 nvim.appdata.xml [ci skip] 2019-09-15 17:24:41 -07:00
Justin M. Keyes
3195637252 release.sh [ci skip] 2019-09-15 16:35:22 -07:00
Justin M. Keyes
9915b5497b version bump 2019-09-15 16:19:49 -07:00
Justin M. Keyes
e2cc5fe09d NVIM v0.4.0
This release represents ~2700 commits since v0.3.4, the previous
non-maintenance release.  Besides the highlights listed below, this
release features vast improvements to documentation, internal subsystems
and test/CI infrastructure, and 700+ patches merged from Vim.

FEATURES:

New API functions:
  nvim_create_buf: create various kinds of buffers
  nvim_get_context, nvim_load_context
    8e6b0a73c9 #10619 API: Context: save/restore/inspect editor state
  nvim_input_mouse: perform mouse actions
  nvim_open_win: create floating windows (and external, for supporting UIs)
  nvim_paste: paste text at cursor
  nvim_put: put text at cursor
  nvim_select_popupmenu_item: perform popupmenu actions
  nvim_set_keymap: create/delete mappings
  nvim_set_vvar: set v: variables
  nvim_ui_pum_set_height
  nvim_ui_try_resize_grid
  nvim_win_close: close windows
  nvim_win_get_config: get window configuration
  nvim_win_set_config: reconfigure windows

New UI events:
  redraw.grid_destroy
  redraw.hl_group_set
    8a3f8589a3 #10504 UI/highlight: expose builtin highlight groups using hl_group_set event
  redraw.msg_clear
  redraw.msg_history_show
  redraw.msg_ruler
  redraw.msg_set_pos
  redraw.msg_show
  redraw.msg_showcmd
  redraw.msg_showmode
  redraw.win_close
  redraw.win_external_pos
  redraw.win_float_pos
  redraw.win_hide
  redraw.win_pos

API
f5c56f03bb #9170 API/Lua: nvim_buf_attach: support Lua callback
82d48c0dab #9896 API: emit nvim_error_event on failed async request
b9ad12e6c2 #9992 UI/nvim_ui_attach(): add `override` option
3d1ed7c959 #9993 UI/ext_messages: learn more message kinds
8ed54bbec3 #9547 proper multiline error message for rpcrequest, API wrappers

Lua
This release introduces "Nvim-Lua standard library". See ":help lua-stdlib".
89d7e24891 #9463 Lua stdlib: vim.inspect, string functions
8e941c59ec #9740 Lua: generate documentation from docstrings
1cbe014569 #9301 lua/stdlib: Introduce vim.shared
c83926cd0a #10123 Lua: introduce vim.loop (expose libuv event-loop)
81e1dbca99 #10120 Lua: vim.schedule(cb)
1f54f68732 #10688 Lua: minimal UTF-16 support needed for LSP
6fb0020df4 #10513 Lua encoding support
    c0993ed343 Lua: support getting UTF-32 and UTF-16 sizes of replaced text
    b0e26199ec Lua: add {old_byte_size} to on_lines buffer change event

UI:
- The Nvim 0.3.4 UI protocol introduced line-based updates instead of
  legacy char-based updates. Nvim 0.4 continues to evolve the UI
  protocol. See ":help ui". Legacy UI clients are supported. See
  ":help api-contract".
9a1675b065 #6619 Floating windows
  - Can be (re)positioned, anchored, external.
  - Are real windows showing real buffers. No shortcuts, hacks, or compromises.
  - Support all features and API of normal windows, plus more.
6427894d89 #8455 Multigrid: "windows drawn on separate grids"
  - Windows are logically isolated internally.
  - Windows are sent to UIs as distinct objects, so that UIs can control
    layout instead of being stuck with the classic TUI layout.
  - Per-window font-size, dimenions, line-spacing.
  - Compositor: Internal subsystem for composing grids.
3855204f58 #6917 UIEnter, UILeave
788bcbba24 #9923 ui: ":syn blend=", 'winblend'
7cf7c0a0b8 #9575 ui: 'redrawdebug' option for flexible debugging of redrawing
5c836d2ef8 #9607 wildoptions=pum (enabled by default)
37f8df8824 #9571 UI: 'pumblend' option for semi-transparent popupmenu
c403a95a52 #9446 Visual: highlight char-at-cursor
  - Traditionally Vim's visual selection does "reverse mode", which
    perhaps conflicts with the non-blinking block cursor. But
    'guicursor' defaults to a vertical bar for selection=exclusive, and
    this confuses users who expect to see the text highlighted.

:terminal
fc27dc98d7 #8550 autocmds: TermEnter, TermLeave
d13803f64f #9810 keymap, terminal: more keycodes
3b56f59532 #9535 :terminal : Fix F1-F4 key codes
2d4a37ebab #10370 :ls : show "R", "F" for terminal-jobs
fd0fd752c8 #9966 terminal: swap priority of terminal, editor highlights
7bb858c39c #9494 libvterm 0.1

TUI
3afb397407 syntax, TUI: support "strikethrough"
ccbcd390d4 #9408 TUI: "title stacking" unconditionally
298608f88c #9509 TUI: detect background color, set bg=dark/light
42f492ac99 #9097 TUI: handle Smulx extension capability (extended underline)
424ddd01f5 #10205 TUI: support rgba background detection
9b4383261a #9601 TUI: italics in tmux, Terminal.app
f6fb370b1b #9793 keymap: support more (keypad) keycodes
3340e08bec #9423 TUI: Konsole DECSCUSR fixup

:checkhealth
d0fd66ba82 health/provider.vim: check curl HTTPS support
c38862acea #10490 checkhealth: try yarn if npm is missing
43356a43d0 #9929 health: check if tmux enabled true colors
ec5a4d862d #9548 checkhealth: validate locale

providers (clipboard, python, etc.):
96be8a2c4d #10161 Allow reloading providers (useful for UIs/clients)
db3c797c6b #9487 provider: improve error message if provider is missing

Various:
36762a00a8 #9295 signs: support multiple columns
801fe799ff #10382 eval: wait() (wait for any condition)
9df3a676e7 #10400 MsgArea highlight; message grid
a9bea8c104 #10790 keymap: allow modifiers to multibyte chars, like <m-ä>
25e0a449bb #10878 #4448 paste: redesign (10x+ faster pasting; extensible vim.paste Lua hook)
ef5037e7f6 #9706 autocmd: introduce "++once" feature
175398f216 #9616 add CompleteChanged autocmd
7fcf2f926f #9717 TextYankPost: add v:event["inclusive"]
3a699a790c #8364 termdebug.vim plugin
ca1ce59025 #9709 performance: use os_copy to create backups
ed0e96cd28 man.vim: set 'linebreak'
70f6939fd4 #9564 events: add "Signal" event
f89d0d8230 #9568 inccommand: auto-disable if folding is slow

FIXES:

41bb68b8e8 #10584 process_stop: uv: do not close stdin first/explicitly
e50aa2a6c6 #10117 normal: Don't exit CTRL-O mode after processing K_EVENT
95fa71c6d2 #9504 :recover : Fix crash on non-existent *.swp
5a836d4767 #9507 screen: don't unconditionally clear messages on window scroll
149dcbf2c7 #10021 channel: refactor events, prevent recursive invocation of events
d19ff73b39 #10107 Fix multiple c_CTRL-D showing statusline
b65a7b7f66 #10103 Fix wildmode=list,full and display+=msgsep interaction
0be6d3c86f #9634 fsync: Ignore ENOTSUP. Fix writing to SMB.
b247c6fd22 #10025 kbtree: pointer UB and unitialized value fixes
018e0d5a19 #9643 API/buffer-updates: always detach on buf-reload
400ee59247 #9961 API: fix cursor position when lines are added
769f44e918 #9911 win/defaults: Use "…/nvim-data/site" in 'runtimepath'
83d571653b #9911 spellfile.vim: store files in stdpath('data')
8dbf23181a #9887 RPC: conform message-id type to msgpack-RPC spec
5f996e36d1 #9894 options: properly reset directories on 'autochdir'
4c4a570156 #9807 various CursorMoved fixes
943bedfc86 #9853 event-loop: do not set CA_COMMAND_BUSY
9d207fd876 #9693 dictwatcheradd(): support b:changedtick
2d50bf3498 #9789 mac: fix locale detection
c5631338b1 #9754 :mksession : restore tab-local working directories
092e7e6c60 #9703 #9703 executable(): return false if user is not owner
11a481f711 #9686 env var fixes/improvements
8e54847fdf #9666 #7920 os/env: Fix completion of multibyte env var names
519382646b #10468 Fix is_executable_in_path() on Windows
8eaa452073 #9516 win: exepath(), executable() fixes
f55c1e4233 #10544 reltimefloat(): allow negative result
b08dc3ec19 #10561 win: jobstart(), system(): $PATHEXT-resolve exe
7cc2b723d4 #10392 TextYankPost: spurious/too-early dispatch during delete
6e01ed6a4c OpenBSD: stop jobs/processes properly
58dd5fcc01 #10522 jobstop(): close channel before process_stop()
83632022f8 #10959 improved resize behavior (all UIs)
c6eb1f42be #10830 API: fix nvim_command_output buffer overflow
cbfd18c85a #10763 startup: handle 'guicursor' after user config
b8f2436feb #10915 jobwait(): fix race if job exits quickly
2fafed6bb8 #10765 clipboard: handle/avoid SIGTERM with previous owner
8aca932aa0 #9954 clipboard: setreg("*") with clipboard=unnamed
3f10c5b533 #9480 performance: clipboard/macOS: assume that pbcopy works
48efafc81c #10398 screen: disable redrawing inside VimResized
5e4b93a38f #10389 API/Lua: make nvim_execute_lua use native lua floats, not special tables
8c6f5b7f92 #9934 Spurious quote mark in command line when typing <C-R>
a8a38f3465 Lua 5.2/5.3 compat

:terminal
47b7b471fa #10700 :terminal : update buffer when switching tabpage
5225c1ec30 #9605 terminal: Fix potential invalid local 'scrollback'
894f6bee54 #8325 :terminal : set topline based on window height
8171e96b96 #9551 Improve :terminal resize
d928b036dc #9856 :stopinsert should leave terminal-mode
3f71218505 #9926 :terminal : fix: Using `:stopinsert` while in normal mode
5020daa6e5 #9883 ui/terminal: make terminal state redraw like any other state

TUI:
9f19e8d29d #9443 TUI: Do not disable BCE for builtin terminfos
a4076e5dcf #9474 win/TUI: fix text overrides line numbers
533d4a36ec #9645 TUI: do not resize host-terminal on startup
b51e5d8b8d #9688 tui_tk_ti_getstr: handle weird value
1f5eac1115 #10785 TUI: fix data-race during resize

CHANGES:

9697c7f56a #8194 fix menu_get()
7f2e43c637 #9520 improve Lua error messages
c2343180d7 #9526 Remove jemalloc
baf93d9606 #9581 UI: always use concrete colors for default_colors_set
91688b4883 #9563 defaults: set 'scrollback' to -1 by default
bb24fec333 #10136 defaults: exclude "S" from 'shortmess'
ddd0eb6f51 #8540 startup: -es/-Es (silent/batch mode): skip swapfile
35362495c9 #9805 jumplist: avoid extra tail entry
939d9053bd #10573 channels: reflect exit due to signals in exit status code
45c34bd84a #10689 :doautocmd : Never show "No matching autocommands"
fb19aeeb33 #9110 API: make nvim_win_set_option() set window-global, not buffer-local
abfc8b3257 #10778 emsg_multiline: log Vim errors
06d9cc734b #10657 exists("$FOO"): return false for empty env var
6616d1d3e5 #10743 win/env: Vim-compat: Empty string deletes env var
7d664837e1 #10662 win: expand nested env var in $HOME
2816bc8620 #8349 edit.c: Disable indent during completion
58f505dc74 #9829 startup: remove TUI init special-case
    Historically Vim/Nvim does backflips to handle input and show messages
    before a UI is available. This logical contradiction was already fixed
    for remote UIs (#9024 c236e80cf3). Fixing it also for the TUI avoids
    problems on Windows, simplifies the logic, and avoids races like #9959.
2019-09-15 12:38:40 -07:00
Björn Linse
45f23ef9d6
Merge pull request #11025 from bfredl/doublescroll
compositor: avoid transmitting invalid lines on double scroll
2019-09-15 16:53:43 +02:00
Daniel Hahler
b9d035a39c
Merge pull request #11026 from janlazo/vim-8.1.0220
vim-patch:8.1.0220
2019-09-15 15:55:50 +02:00
Björn Linse
a0f13095aa compositor: avoid transmitting invalid lines on double scroll
This happens in an operation which both increases topline and also
inserts new lines somewhere in the remaining are. So before drawing any
line, win_update() is performing two grid_scroll operations.

===
A
B
C
D
E^
F
===

Consider that new line will be inserted after line E and screen also
scrolled up to line C. First the topline will be adjusted (x is the
scrolling region, ! invalid/empty space created by the scroll):

===
C   x
D   x
E^  x
F   x
!   x
!   x
===

and then space is inserted for the new line

===
C
D
E^
!   x
F   x
!   x
===

The problem is that we are now assuming that any invalid area ! created
by a scroll is filled with actual contents (by win_line etc) before it
is scrolled again. But in this case the last invalid line ! gets
scrolled. Ideally we should make win_update smarter and just scroll
valid lines for the later scroll (it is just wasteful to scroll the
larger area anyway), but for the 0.4 releasejust make
the compositor ignore such an invalid line (as it will get overdrawn
anyway later).
2019-09-15 15:30:48 +02:00