kevin/linux
1
Fork 0
Code
86987d84b9
linux/drivers/pinctrl
History
Huang-Huang Bao 128f71fe01 pinctrl: rockchip: correct RK3328 iomux width flag for GPIO2-B pins 
The base iomux offsets for each GPIO pin line are accumulatively
calculated based off iomux width flag in rockchip_pinctrl_get_soc_data.
If the iomux width flag is one of IOMUX_WIDTH_4BIT, IOMUX_WIDTH_3BIT or
IOMUX_WIDTH_2BIT, the base offset for next pin line would increase by 8
bytes, otherwise it would increase by 4 bytes.

Despite most of GPIO2-B iomux have 2-bit data width, which can be fit
into 4 bytes space with write mask, it actually take 8 bytes width for
whole GPIO2-B line.

Commit e8448a6c81 ("pinctrl: rockchip: fix pinmux bits for RK3328
GPIO2-B pins") wrongly set iomux width flag to 0, causing all base
iomux offset for line after GPIO2-B to be calculated wrong. Fix the
iomux width flag to IOMUX_WIDTH_2BIT so the offset after GPIO2-B is
correctly increased by 8, matching the actual width of GPIO2-B iomux.

Fixes: e8448a6c81 ("pinctrl: rockchip: fix pinmux bits for RK3328 GPIO2-B pins")
Cc: stable@vger.kernel.org
Reported-by: Richard Kojedzinszky <richard@kojedz.in>
Closes: https://lore.kernel.org/linux-rockchip/4f29b743202397d60edfb3c725537415@kojedz.in/
Tested-by: Richard Kojedzinszky <richard@kojedz.in>
Signed-off-by: Huang-Huang Bao <i@eh5.me>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Trevor Woerner <twoerner@gmail.com>
Link: https://lore.kernel.org/20240709105428.1176375-1-i@eh5.me
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2024-08-24 16:39:51 +02:00
..
actions
aspeed pinctrl: aspeed-g6: Add NCSI pin group config 2024-06-26 12:41:07 +02:00
bcm Pin control bulk changes for the v6.11 kernel series: 2024-07-21 10:25:59 -07:00
berlin pinctrl: berlin: Make use of struct pinfunction 2024-06-17 09:23:34 +02:00
cirrus pinctrl: cs42l43: Use str_high_low() 2024-01-31 09:11:14 +01:00
freescale pinctrl: freescale: Use scope based of_node_put() cleanups 2024-07-03 14:40:38 +02:00
intel pinctrl: baytrail: Add pinconf group for uart3 2024-04-08 17:54:48 +03:00
mediatek pinctrl: mediatek: common-v2: Fix broken bias-disable for PULL_PU_PD_RSEL_TYPE 2024-08-23 18:07:14 +02:00
meson pinctrl: add missing MODULE_DESCRIPTION() macros 2024-06-17 10:59:31 +02:00
mvebu pinctrl: armada-37xx: remove an unused variable 2024-04-02 14:27:13 +02:00
nomadik pinctrl: nomadik: Use scope based of_node_put() cleanups 2024-06-26 11:58:17 +02:00
nuvoton pinctrl: nuvoton: ma35d1: Fix an IS_ERR() vs NULL check 2024-06-17 11:01:47 +02:00
nxp of: remove internal arguments from of_property_for_each_u32() 2024-07-25 06:53:47 -05:00
pxa pinctrl: pxa2xx: Make use of struct pingroup 2024-03-28 09:44:20 +01:00
qcom pinctrl: qcom: x1e80100: Fix special pin offsets 2024-08-23 18:13:45 +02:00
realtek pinctrl: realtek: fix module autoloading 2024-04-17 10:43:50 +02:00
renesas pinctrl: renesas: rzg2l: Support output enable on RZ/G2L 2024-07-04 19:22:03 +02:00
samsung pinctrl: samsung: drop redundant drvdata assignment 2024-04-30 09:41:58 +02:00
spear pinctrl: spear: Use scope based of_node_put() cleanups 2024-06-26 11:56:15 +02:00
sprd pinctrl: sprd: Use scope based of_node_put() cleanups 2024-06-26 11:56:05 +02:00
starfive pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register 2024-08-23 18:14:45 +02:00
stm32 pinctrl: stm32: Use scope based of_node_put() cleanups 2024-06-17 09:21:32 +02:00
sunplus pinctrl: sppctl: use gpiochip_dup_line_label() 2023-12-08 09:26:37 +01:00
sunxi pinctrl: sunxi: sun9i-a80-r: drop driver owner assignment 2024-04-04 13:39:47 +02:00
tegra pinctrl: tegra: Use scope based of_node_put() cleanups 2024-06-26 11:55:34 +02:00
ti pinctrl: ti: iodelay: Use scope based of_node_put() cleanups 2024-07-03 14:40:38 +02:00
uniphier
visconti
vt8500 pinctrl: vt8500: drop the wrapper around pinctrl_gpio_direction_input() 2023-11-04 10:23:22 +01:00
core.c Pin control bulk changes for the v6.11 kernel series: 2024-07-21 10:25:59 -07:00
core.h pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC() 2024-06-17 09:24:13 +02:00
devicetree.c pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() 2024-04-16 15:32:48 +02:00
devicetree.h
Kconfig RISC-V SoC Kconfig Updates for v6.10 2024-05-07 11:02:56 +02:00
Makefile pinctrl: Implementation of the generic scmi-pinctrl driver 2024-04-19 15:17:37 +01:00
pinconf-generic.c pinctrl: pinconf-generic: Use scope based of_node_put() cleanups 2024-06-26 11:59:22 +02:00
pinconf.c pinctrl: Convert unsigned to unsigned int 2023-12-04 15:32:42 +01:00
pinconf.h pinctrl: Convert unsigned to unsigned int 2023-12-04 15:32:42 +01:00
pinctrl-amd.c genirq: Introduce IRQF_COND_ONESHOT and use it in pinctrl-amd 2024-03-25 23:45:21 +01:00
pinctrl-amd.h pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend 2023-12-04 15:46:02 +01:00
pinctrl-apple-gpio.c
pinctrl-artpec6.c pinctrl: artpec6: Convert to platform remove callback returning void 2023-10-10 15:39:10 +02:00
pinctrl-as3722.c pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path 2023-11-24 11:22:12 +01:00
pinctrl-at91-pio4.c pinctrl: at91: Use scope based of_node_put() cleanups 2024-06-26 11:57:55 +02:00
pinctrl-at91.c pinctrl: at91: make it work with current gpiolib 2024-08-23 17:32:01 +02:00
pinctrl-at91.h
pinctrl-aw9523.c pinctrl: aw9523: Fix indentation in a few places 2024-04-04 13:16:46 +02:00
pinctrl-axp209.c pinctrl: axp209: drop the wrapper around pinctrl_gpio_direction_input() 2023-11-04 10:23:22 +01:00
pinctrl-bm1880.c
pinctrl-cy8c95x0.c pinctrl: cy8c95x0: Update cache modification 2024-07-03 13:14:29 +02:00
pinctrl-da850-pupd.c
pinctrl-da9062.c pinctrl: da9062: replace gpiochip_get_desc() with gpio_device_get_desc() 2024-06-25 09:12:48 +02:00
pinctrl-digicolor.c
pinctrl-equilibrium.c pinctrl: equilibrium: Use scope based of_node_put() cleanups 2024-07-03 14:40:38 +02:00
pinctrl-equilibrium.h pinctrl: equilibrium: Make use of struct pinfunction 2024-06-17 09:23:43 +02:00
pinctrl-falcon.c
pinctrl-gemini.c
pinctrl-ingenic.c pinctrl: ingenic: Convert to use func member 2024-06-17 09:24:42 +02:00
pinctrl-k210.c of: remove internal arguments from of_property_for_each_u32() 2024-07-25 06:53:47 -05:00
pinctrl-keembay.c pinctrl: keembay: Fix func conversion in keembay_build_functions() 2024-06-17 09:26:28 +02:00
pinctrl-lantiq.c
pinctrl-lantiq.h
pinctrl-loongson2.c pinctrl: loongson2: fix module autoloading 2024-04-17 10:43:50 +02:00
pinctrl-lpc18xx.c
pinctrl-max77620.c pinctrl: max77620: Remove an unused fields in struct max77620_pin_info and max77620_pctrl_info 2024-04-04 21:03:25 +02:00
pinctrl-mcp23s08_i2c.c pinctrl: add missing MODULE_DESCRIPTION() macros 2024-06-17 10:59:31 +02:00
pinctrl-mcp23s08_spi.c pinctrl: add missing MODULE_DESCRIPTION() macros 2024-06-17 10:59:31 +02:00
pinctrl-mcp23s08.c pinctrl: add missing MODULE_DESCRIPTION() macros 2024-06-17 10:59:31 +02:00
pinctrl-mcp23s08.h pinctrl: mcp23s08: Simplify probe()/mcp23s08_spi_regmap_init() 2023-10-10 13:39:38 +02:00
pinctrl-microchip-sgpio.c
pinctrl-mlxbf3.c pinctrl: mlxbf3: Fix return value check for devm_platform_ioremap_resource 2024-06-26 12:41:07 +02:00
pinctrl-ocelot.c pinctrl: ocelot: remove redundant assignment to variable ret 2024-02-29 14:38:09 +01:00
pinctrl-palmas.c
pinctrl-pef2256.c pinctrl: Add support for the Lantic PEF2256 pinmux 2023-12-12 23:05:24 +01:00
pinctrl-pic32.c
pinctrl-pic32.h
pinctrl-pistachio.c
pinctrl-rk805.c pinctrl: rk805: Add rk816 pinctrl support 2024-05-03 09:15:33 +01:00
pinctrl-rockchip.c pinctrl: rockchip: correct RK3328 iomux width flag for GPIO2-B pins 2024-08-24 16:39:51 +02:00
pinctrl-rockchip.h pinctrl: rockchip: use dedicated pinctrl type for RK3328 2024-06-17 10:36:56 +02:00
pinctrl-scmi.c pinctrl: scmi: add blocklist 2024-06-17 09:26:04 +02:00
pinctrl-single.c pinctrl: single: fix potential NULL dereference in pcs_get_function() 2024-08-23 18:05:44 +02:00
pinctrl-st.c pinctrl: st: Use scope based of_node_put() cleanups 2024-06-17 09:21:38 +02:00
pinctrl-stmfx.c pinctrl: stmfx: Convert to platform remove callback returning void 2023-10-10 15:41:35 +02:00
pinctrl-sx150x.c
pinctrl-tb10x.c pinctrl: add missing MODULE_DESCRIPTION() macros 2024-06-17 10:59:31 +02:00
pinctrl-tps6594.c Pin control bulk changes for the v6.11 kernel series: 2024-07-21 10:25:59 -07:00
pinctrl-utils.c pinctrl: Convert unsigned to unsigned int 2023-12-04 15:32:42 +01:00
pinctrl-utils.h pinctrl: Convert unsigned to unsigned int 2023-12-04 15:32:42 +01:00
pinctrl-xway.c pinctrl: Use device_get_match_data() 2023-10-30 14:50:42 +01:00
pinctrl-zynq.c
pinctrl-zynqmp.c pinctrl: zynqmp: Support muxing individual pins 2024-06-17 10:47:06 +02:00
pinmux.c pinctrl: pinmux: Embed struct pinfunction into struct function_desc 2024-06-17 09:24:22 +02:00
pinmux.h pinctrl: pinmux: Remove unused members from struct function_desc 2024-06-17 09:25:11 +02:00