kevin/linux
1
Fork 0
Code

firewire: core: use WARN_ON_ONCE() to avoid superfluous dumps

Browse Source 
It is enough to notify programming mistakes to programmers just once.

Suggested-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20240905131029.6433-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit is contained in:
Takashi Sakamoto 2024-09-05 22:10:29 +09:00
parent 5c49cc0ed4
commit 7519033f31
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/firewire/core-iso.c
View File

@ -220,7 +220,7 @@ int fw_iso_context_flush_completions(struct fw_iso_context *ctx)
might_sleep();
// Avoid dead lock due to programming mistake.
if (WARN_ON(current_work() == &ctx->work))
if (WARN_ON_ONCE(current_work() == &ctx->work))
return 0;
disable_work_sync(&ctx->work);
@ -244,7 +244,7 @@ int fw_iso_context_stop(struct fw_iso_context *ctx)
might_sleep();
// Avoid dead lock due to programming mistake.
if (WARN_ON(current_work() == &ctx->work))
if (WARN_ON_ONCE(current_work() == &ctx->work))
return 0;
err = ctx->card->driver->stop_iso(ctx);