From 7519033f319d4dc8066cb3a37c1276610f4cb0ca Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Thu, 5 Sep 2024 22:10:29 +0900 Subject: [PATCH] firewire: core: use WARN_ON_ONCE() to avoid superfluous dumps It is enough to notify programming mistakes to programmers just once. Suggested-by: Takashi Iwai Link: https://lore.kernel.org/r/20240905131029.6433-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-iso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c index af76fa1823f1..a249974a0f87 100644 --- a/drivers/firewire/core-iso.c +++ b/drivers/firewire/core-iso.c @@ -220,7 +220,7 @@ int fw_iso_context_flush_completions(struct fw_iso_context *ctx) might_sleep(); // Avoid dead lock due to programming mistake. - if (WARN_ON(current_work() == &ctx->work)) + if (WARN_ON_ONCE(current_work() == &ctx->work)) return 0; disable_work_sync(&ctx->work); @@ -244,7 +244,7 @@ int fw_iso_context_stop(struct fw_iso_context *ctx) might_sleep(); // Avoid dead lock due to programming mistake. - if (WARN_ON(current_work() == &ctx->work)) + if (WARN_ON_ONCE(current_work() == &ctx->work)) return 0; err = ctx->card->driver->stop_iso(ctx);