kevin/linux
1
Fork 0
Code

media: tc358746: Move clk_prepare to its own function

Browse Source 
Smatch is very confused by a clk_prepare_enable() being called in an
error-path. Fix this warning by moving the clk_prepare_enable() to its
own function.

drivers/media/i2c/tc358746.c:1631 tc358746_suspend() warn: 'tc358746->refclk' from clk_prepare_enable() not released on lines: 1631.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Ricardo Ribalda 2024-08-16 12:32:02 +00:00 committed by Hans Verkuil
parent 334af4c52e
commit 157c73682d
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/media/i2c/tc358746.c
View File

@ -1616,6 +1616,16 @@ static void tc358746_remove(struct i2c_client *client)
pm_runtime_dont_use_autosuspend(sd->dev); pm_runtime_dont_use_autosuspend(sd->dev);
} }
/*
* This function has been created just to avoid a smatch warning,
* please do not merge it into tc358746_suspend until you have
* confirmed that it does not introduce a new warning.
*/
static void tc358746_clk_enable(struct tc358746 *tc358746)
{
clk_prepare_enable(tc358746->refclk);
}
static int tc358746_suspend(struct device *dev) static int tc358746_suspend(struct device *dev)
{ {
struct tc358746 *tc358746 = dev_get_drvdata(dev); struct tc358746 *tc358746 = dev_get_drvdata(dev);
@ -1626,7 +1636,7 @@ static int tc358746_suspend(struct device *dev)
err = regulator_bulk_disable(ARRAY_SIZE(tc358746_supplies), err = regulator_bulk_disable(ARRAY_SIZE(tc358746_supplies),
tc358746->supplies); tc358746->supplies);
if (err) if (err)
clk_prepare_enable(tc358746->refclk); tc358746_clk_enable(tc358746);
return err; return err;
} }