kevin/linux
1
Fork 0
Code

media: i2c: s5c73m3: Move clk_prepare to its own function

Browse Source 
Smatch is very confused by a clk_prepare_enable() being called in an
error-path. Fix this warning by moving the clk_prepare_enable() to its
own function.

drivers/media/i2c/s5c73m3/s5c73m3-core.c:1425 __s5c73m3_power_off() warn: 'state->clock' from clk_prepare_enable() not released on lines: 1425.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Ricardo Ribalda 2024-08-16 12:32:01 +00:00 committed by Hans Verkuil
parent 820d81a167
commit 334af4c52e
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/media/i2c/s5c73m3/s5c73m3-core.c
View File

@ -1392,6 +1392,16 @@ err_reg_dis:
return ret;
}
/*
* This function has been created just to avoid a smatch warning,
* please do not merge into __s5c73m3_power_off() until you have
* confirmed that it does not introduce a new warning.
*/
static void s5c73m3_enable_clk(struct s5c73m3 *state)
{
clk_prepare_enable(state->clock);
}
static int __s5c73m3_power_off(struct s5c73m3 *state)
{
int i, ret;
@ -1421,7 +1431,8 @@ err:
state->supplies[i].supply, r);
}
clk_prepare_enable(state->clock);
s5c73m3_enable_clk(state);
return ret;
}