Commit Graph

24 Commits

Author SHA1 Message Date
Edwin Kofler
d81b81f9de
fix: Remove == inside [ (#1421)
* lint(checkstyle): Miscellaneous tweaks
* lint(checkstyle): Add 'no-double-equals' rule
* lint: Remove double equals from `[`
* chore: Remove final double equals

Co-authored-by: Trevor Brown <Stratus3D@users.noreply.github.com>
2023-01-14 08:18:44 -05:00
Edwin Kofler
ec972cbdf0
fix: Ban use of 'test' (#1383) 2022-12-19 08:08:38 -05:00
Josh Soref
eaf2215cb8
chore: Fix spelling (#1289)
chore: Fix spelling
2022-07-05 09:40:33 -04:00
James Hegedus
21bc411915
ci: add latest OSs to testing matrix, bump BATS, shfmt, shellcheck (#1260)
* ci: add latest OSs to testing matrix
* ci: bump bats & shellcheck & shfmt
* chore: format with latest shfmt
2022-06-24 19:20:27 +10:00
Trevor Brown
39909e01af
fix: add asdf to list of banned commands (#1224)
Ban recusive asdf calls as they are inefficient and may introduce bugs.
If you find yourself needing to invoke an `asdf` command from within
asdf code, please source the appropriate file and invoke the
corresponding function.
2022-05-06 09:21:06 -04:00
Trevor Brown
87137e4103
fix: Ban ls command (#1141)
* Ban `ls` command
* Update banned commands test so it only checks bash and sh files
* Only allow `ls` for resolving symlinks
* Replace `ls` commands with `find`
2021-12-29 12:10:39 -05:00
Trevor Brown
6e4c39c244
fix: ban grep long flags (#1117)
Co-authored-by: James Hegedus <jthegedus@hey.com>
2021-12-09 13:17:49 +11:00
Elijah
cc7778a040
feat: Elvish Shell support (#1066) 2021-11-18 21:05:27 +11:00
Max Nordlund
847ec73751
fix: Use more idiomatic fish (#1042)
The use of `.` is deprecated in fish, unlike POSIX shells. We can avoid
calling `psub` and pipe directly into source which does the same thing.

https://fishshell.com/docs/current/cmds/source.html
2021-10-07 09:20:41 -04:00
Alberto de Murga
8a515f49d7
fix: Adds "grep -P" to the list of banned commands (#1064)
Co-authored-by: James Hegedus <jthegedus@hey.com>
2021-10-07 09:58:42 +11:00
Trevor Brown
79eca42572 Update banned_commands.bats tests to ignore string literals 2021-05-24 17:30:51 -04:00
Trevor Brown
e121a93716 Update banned_commands.bats
Update banned_commands.bats so commands in comments are ignored and output
is only printed when a banned command is found.
2021-05-21 12:40:23 -04:00
Trevor Brown
5ca750edb2 Add source to list of banned commands 2021-05-21 11:58:49 -04:00
James Hegedus
10d9c1218e
Merge branch 'master' into ban-process-substitution 2021-04-27 19:34:35 +10:00
Trevor Brown
dd20022830
Add both the short and long versions of the --sort-versions flag to the banned commands
Related to #755
2021-02-10 14:45:02 -05:00
Trevor Brown
f633811577 Ban process substitution from asdf codebase 2021-02-05 11:28:27 -05:00
Trevor Brown
8bbefba072
chore: ban echo command (#806) 2020-09-22 08:27:52 +10:00
Trevor Brown
aef4ae8b5a
fix: ban the sort -V command (#755) 2020-07-08 15:37:52 +10:00
Trevor Brown
4219f9f5b1 Add column to list of banned commands for the asdf codebase 2020-07-06 09:47:35 -04:00
Victor Hugo Borja
5ab01f49df Allow eval only on asdf function at lib/asdf.sh.
It's needed for `asdf shell` command.
2019-12-03 11:04:04 -06:00
Daniel Perez
81709db18a Fix shim_plugin_version 2019-03-23 21:21:55 +00:00
Trevor Brown
4a4f453a93 Add readlink to list of banned commands. 2018-06-16 20:19:33 -04:00
Trevor Brown
8794210b8e Add 'eval' to list of banned commands. 2017-11-16 22:43:52 -05:00
Trevor Brown
7601afd9b9 Add test that greps source code for banned commands. 2017-10-28 10:54:10 -04:00