kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 01:28:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

Update banned_commands.bats

Browse Source 
Update banned_commands.bats so commands in comments are ignored and output
is only printed when a banned command is found.
This commit is contained in:
Trevor Brown 2021-05-21 12:40:20 -04:00
parent f125741fb5
commit e121a93716
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/banned_commands.bats
View File

@ -38,8 +38,18 @@ teardown() {
for cmd in "${banned_commands[@]}"; do
# Assert command is not used in the lib and bin dirs
# or expect an explicit comment at end of line, allowing it.
run bash -c "grep -nHR '$cmd' lib bin | grep -v '# asdf_allow: $cmd'"
echo "banned command $cmd: $output"
# Also ignore matches that are contained in comments or followed by an
# underscore (indicating it's a variable and not a command).
run bash -c "grep -nHR '$cmd' lib bin\
| grep -v '#.*$cmd'\
| grep -v '${cmd}_'\
| grep -v '# asdf_allow: $cmd'"
# Only print output if we've found a banned command
if [ "$status" -ne 1 ]; then
echo "banned command $cmd: $output"
fi
[ "$status" -eq 1 ]
[ "" == "$output" ]
done