mirror of
https://github.com/neovim/neovim.git
synced 2024-12-20 11:15:14 -07:00
a70eae57bd
Problem: nvim_open_win blocking all win_set_buf autocommands when !enter && !noautocmd is too aggressive. Solution: temporarily block WinEnter/Leave and BufEnter/Leave events when setting the buffer. Delegate the firing of BufWinEnter back to win_set_buf, which also has the advantage of keeping the timing consistent (e.g: before the epilogue in enter_buffer, which also handles restoring the cursor position if autocommands didn't change it, among other things). Reword the documentation for noautocmd a bit. I pondered modifying do_buffer and callees to allow for BufEnter/Leave being conditionally disabled, but it seems too invasive (and potentially error-prone, especially if new code paths to BufEnter/Leave are added in the future). Unfortunately, doing this has the drawback of blocking ALL such events for the duration, which also means blocking unrelated such events; like if window switching occurs in a ++nested autocmd fired by win_set_buf. If this turns out to be a problem in practice, a different solution specialized for nvim_open_win could be considered. :-) |
||
|---|---|---|
| .. | ||
| autoload | ||
| colors | ||
| compiler | ||
| doc | ||
| ftplugin | ||
| indent | ||
| keymap | ||
| lua | ||
| macros | ||
| pack/dist/opt | ||
| plugin | ||
| queries | ||
| spell | ||
| syntax | ||
| tools | ||
| tutor | ||
| CMakeLists.txt | ||
| delmenu.vim | ||
| filetype.lua | ||
| ftoff.vim | ||
| ftplugin.vim | ||
| ftplugof.vim | ||
| indent.vim | ||
| indoff.vim | ||
| macmap.vim | ||
| makemenu.vim | ||
| menu.vim | ||
| mswin.vim | ||
| neovim.ico | ||
| nvim.appdata.xml | ||
| nvim.desktop | ||
| nvim.png | ||
| optwin.vim | ||
| synmenu.vim | ||
