mirror of
https://github.com/neovim/neovim.git
synced 2024-12-27 14:21:31 -07:00
e268fcbdaa
There appears to be a bug in `make` where if a rule asks `make` to invoke a command called `foo`, and `foo` exists somewhere in `$PATH` as a directory (not an executable file), `make` will attempt to `execve` that directory instead of continuing to search in later parts of the `$PATH` for `foo` as a true executable. The cause can be traced back to a bug in Make 4.3 which stems from their use of the findprog function in Gnulib. This was reported to the Make maintainers here: https://savannah.gnu.org/bugs/index.php?57962 and then forwarded to the Gnulib maintainers here: https://github.com/coreutils/gnulib/commit/7b1de4a Make 4.4 does not have this bug, and I can confirm that I'm able to run make in the Neovim repo with no further modifications to my system than upgrading the version of make I'm using to 4.4 or 4.4.1. As the change is small enough, and it's unlikely that make version around the world is going to be updated in a timely manner, it makes sense to just add a workaround for this. Using `command -v` to resolve the `cmake` command, similar to what is already being done with `cmake3`, makes it work correctly in all cases. Continuing to include `... || echo cmake` at the end means that if neither `cmake3` nor `cmake` are installed, the user will still see a message about CMake being missing. Co-authored-by: Jake Zimmerman <zimmerman.jake@gmail.com>
172 lines
5.1 KiB
Makefile
172 lines
5.1 KiB
Makefile
ifeq ($(OS),Windows_NT)
|
|
SHELL := powershell.exe
|
|
.SHELLFLAGS := -NoProfile -NoLogo
|
|
MKDIR := @$$null = new-item -itemtype directory -force
|
|
TOUCH := @$$null = new-item -force
|
|
RM := remove-item -force
|
|
CMAKE := cmake
|
|
CMAKE_GENERATOR := Ninja
|
|
define rmdir
|
|
if (Test-Path $1) { remove-item -recurse $1 }
|
|
endef
|
|
else
|
|
MKDIR := mkdir -p
|
|
TOUCH := touch
|
|
RM := rm -rf
|
|
CMAKE := $(shell (command -v cmake3 || command -v cmake || echo cmake))
|
|
CMAKE_GENERATOR ?= "$(shell (command -v ninja > /dev/null 2>&1 && echo "Ninja") || echo "Unix Makefiles")"
|
|
define rmdir
|
|
rm -rf $1
|
|
endef
|
|
endif
|
|
|
|
MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
|
|
MAKEFILE_DIR := $(dir $(MAKEFILE_PATH))
|
|
|
|
filter-false = $(strip $(filter-out 0 off OFF false FALSE,$1))
|
|
filter-true = $(strip $(filter-out 1 on ON true TRUE,$1))
|
|
|
|
# See contrib/local.mk.example
|
|
-include local.mk
|
|
|
|
all: nvim
|
|
|
|
CMAKE_FLAGS := -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE)
|
|
# Extra CMake flags which extend the default set
|
|
CMAKE_EXTRA_FLAGS ?=
|
|
NVIM_PRG := $(MAKEFILE_DIR)/build/bin/nvim
|
|
|
|
# CMAKE_INSTALL_PREFIX
|
|
# - May be passed directly or as part of CMAKE_EXTRA_FLAGS.
|
|
# - `checkprefix` target checks that it matches the CMake-cached value. #9615
|
|
ifneq (,$(CMAKE_INSTALL_PREFIX)$(CMAKE_EXTRA_FLAGS))
|
|
CMAKE_INSTALL_PREFIX := $(shell echo $(CMAKE_EXTRA_FLAGS) | 2>/dev/null \
|
|
grep -o 'CMAKE_INSTALL_PREFIX=[^ ]\+' | cut -d '=' -f2)
|
|
endif
|
|
ifneq (,$(CMAKE_INSTALL_PREFIX))
|
|
override CMAKE_EXTRA_FLAGS += -DCMAKE_INSTALL_PREFIX=$(CMAKE_INSTALL_PREFIX)
|
|
|
|
checkprefix:
|
|
@if [ -f build/.ran-cmake ]; then \
|
|
cached_prefix=$(shell $(CMAKE) -L -N build | 2>/dev/null grep 'CMAKE_INSTALL_PREFIX' | cut -d '=' -f2); \
|
|
if ! [ "$(CMAKE_INSTALL_PREFIX)" = "$$cached_prefix" ]; then \
|
|
printf "Re-running CMake: CMAKE_INSTALL_PREFIX '$(CMAKE_INSTALL_PREFIX)' does not match cached value '%s'.\n" "$$cached_prefix"; \
|
|
$(RM) build/.ran-cmake; \
|
|
fi \
|
|
fi
|
|
else
|
|
checkprefix: ;
|
|
endif
|
|
|
|
DEPS_BUILD_DIR ?= ".deps"
|
|
ifneq (1,$(words [$(DEPS_BUILD_DIR)]))
|
|
$(error DEPS_BUILD_DIR must not contain whitespace)
|
|
endif
|
|
|
|
DEPS_CMAKE_FLAGS ?=
|
|
USE_BUNDLED ?=
|
|
|
|
ifneq (,$(USE_BUNDLED))
|
|
BUNDLED_CMAKE_FLAG := -DUSE_BUNDLED=$(USE_BUNDLED)
|
|
endif
|
|
|
|
ifneq (,$(findstring functionaltest-lua,$(MAKECMDGOALS)))
|
|
BUNDLED_LUA_CMAKE_FLAG := -DUSE_BUNDLED_LUA=ON
|
|
$(shell [ -x $(DEPS_BUILD_DIR)/usr/bin/lua ] || $(RM) build/.ran-*)
|
|
endif
|
|
|
|
# For use where we want to make sure only a single job is run. This does issue
|
|
# a warning, but we need to keep SCRIPTS argument.
|
|
SINGLE_MAKE = export MAKEFLAGS= ; $(MAKE)
|
|
|
|
nvim: build/.ran-cmake deps
|
|
$(CMAKE) --build build
|
|
|
|
libnvim: build/.ran-cmake deps
|
|
$(CMAKE) --build build --target libnvim
|
|
|
|
cmake:
|
|
$(TOUCH) CMakeLists.txt
|
|
$(MAKE) build/.ran-cmake
|
|
|
|
build/.ran-cmake: | deps
|
|
$(CMAKE) -B build -G $(CMAKE_GENERATOR) $(CMAKE_FLAGS) $(CMAKE_EXTRA_FLAGS) $(MAKEFILE_DIR)
|
|
$(TOUCH) $@
|
|
|
|
deps: | build/.ran-deps-cmake
|
|
ifeq ($(call filter-true,$(USE_BUNDLED)),)
|
|
$(CMAKE) --build $(DEPS_BUILD_DIR)
|
|
endif
|
|
|
|
ifeq ($(call filter-true,$(USE_BUNDLED)),)
|
|
$(DEPS_BUILD_DIR):
|
|
$(MKDIR) $@
|
|
build/.ran-deps-cmake:: $(DEPS_BUILD_DIR)
|
|
$(CMAKE) -S $(MAKEFILE_DIR)/cmake.deps -B $(DEPS_BUILD_DIR) -G $(CMAKE_GENERATOR) $(BUNDLED_CMAKE_FLAG) $(BUNDLED_LUA_CMAKE_FLAG) $(DEPS_CMAKE_FLAGS)
|
|
endif
|
|
build/.ran-deps-cmake::
|
|
$(MKDIR) build
|
|
$(TOUCH) "$@"
|
|
|
|
# TODO: cmake 3.2+ add_custom_target() has a USES_TERMINAL flag.
|
|
oldtest: | nvim
|
|
$(SINGLE_MAKE) -C test/old/testdir clean
|
|
ifeq ($(strip $(TEST_FILE)),)
|
|
$(SINGLE_MAKE) -C test/old/testdir NVIM_PRG=$(NVIM_PRG) $(MAKEOVERRIDES)
|
|
else
|
|
@# Handle TEST_FILE=test_foo{,.res,.vim}.
|
|
$(SINGLE_MAKE) -C test/old/testdir NVIM_PRG=$(NVIM_PRG) SCRIPTS= $(MAKEOVERRIDES) $(patsubst %.vim,%,$(patsubst %.res,%,$(TEST_FILE)))
|
|
endif
|
|
# Build oldtest by specifying the relative .vim filename.
|
|
.PHONY: phony_force
|
|
test/old/testdir/%.vim: phony_force nvim
|
|
$(SINGLE_MAKE) -C test/old/testdir NVIM_PRG=$(NVIM_PRG) SCRIPTS= $(MAKEOVERRIDES) $(patsubst test/old/testdir/%.vim,%,$@)
|
|
|
|
functionaltest-lua: | nvim
|
|
$(CMAKE) --build build --target functionaltest
|
|
|
|
FORMAT=formatc formatlua format
|
|
LINT=lintlua lintsh lintc clang-analyzer lintcommit lintdoc lint
|
|
TEST=functionaltest unittest
|
|
generated-sources benchmark $(FORMAT) $(LINT) $(TEST) doc: | build/.ran-cmake
|
|
$(CMAKE) --build build --target $@
|
|
|
|
test: $(TEST)
|
|
|
|
iwyu: build/.ran-cmake
|
|
$(CMAKE) --preset iwyu
|
|
$(CMAKE) --build build > build/iwyu.log
|
|
iwyu-fix-includes --only_re="src/nvim" --ignore_re="(src/nvim/eval/encode.c\
|
|
|src/nvim/auto/\
|
|
|src/nvim/os/lang.c\
|
|
|src/nvim/map.c\
|
|
)" --nosafe_headers < build/iwyu.log
|
|
$(CMAKE) -B build -U ENABLE_IWYU
|
|
$(CMAKE) --build build
|
|
|
|
clean:
|
|
ifneq ($(wildcard build),)
|
|
$(CMAKE) --build build --target clean
|
|
endif
|
|
$(MAKE) -C test/old/testdir clean
|
|
$(MAKE) -C runtime/indent clean
|
|
|
|
distclean:
|
|
$(call rmdir, $(DEPS_BUILD_DIR))
|
|
$(call rmdir, build)
|
|
$(MAKE) clean
|
|
|
|
install: checkprefix nvim
|
|
$(CMAKE) --install build
|
|
|
|
appimage:
|
|
bash scripts/genappimage.sh
|
|
|
|
# Build an appimage with embedded update information.
|
|
# appimage-nightly: for nightly builds
|
|
# appimage-latest: for a release
|
|
appimage-%:
|
|
bash scripts/genappimage.sh $*
|
|
|
|
.PHONY: test clean distclean nvim libnvim cmake deps install appimage checkprefix benchmark $(FORMAT) $(LINT) $(TEST)
|