mirror of
https://github.com/neovim/neovim.git
synced 2024-12-24 13:15:09 -07:00
2e8103475e
## Overview
- Move vim.lsp.diagnostic to vim.diagnostic
- Refactor client ids to diagnostic namespaces
- Update tests
- Write/update documentation and function signatures
Currently, non-LSP diagnostics in Neovim must hook into the LSP subsystem. This
is what e.g. null-ls and nvim-lint do. This is necessary because none of the
diagnostic API is exposed separately from the LSP subsystem.
This commit addresses this by generalizing the diagnostic subsystem beyond the
scope of LSP. The `vim.lsp.diagnostic` module is now simply a specific
diagnostic producer and primarily maintains the interface between LSP clients
and the broader diagnostic API.
The current diagnostic API uses "client ids" which only makes sense in the
context of LSP. We replace "client ids" with standard API namespaces generated
from `nvim_create_namespace`.
This PR is *mostly* backward compatible (so long as plugins are only using the
publicly documented API): LSP diagnostics will continue to work as usual, as
will pseudo-LSP clients like null-ls and nvim-lint. However, the latter can now
use the new interface, which looks something like this:
```lua
-- The namespace *must* be given a name. Anonymous namespaces will not work with diagnostics
local ns = vim.api.nvim_create_namespace("foo")
-- Generate diagnostics
local diagnostics = generate_diagnostics()
-- Set diagnostics for the current buffer
vim.diagnostic.set(ns, diagnostics, bufnr)
```
Some public facing API utility methods were removed and internalized directly in `vim.diagnostic`:
* `vim.lsp.util.diagnostics_to_items`
## API Design
`vim.diagnostic` contains most of the same API as `vim.lsp.diagnostic` with
`client_id` simply replaced with `namespace`, with some differences:
* Generally speaking, functions that modify or add diagnostics require a namespace as their first argument, e.g.
```lua
vim.diagnostic.set({namespace}, {bufnr}, {diagnostics}[, {opts}])
```
while functions that read or query diagnostics do not (although in many cases one may be supplied optionally):
```lua
vim.diagnostic.get({bufnr}[, {namespace}])
```
* We use our own severity levels to decouple `vim.diagnostic` from LSP. These
are designed similarly to `vim.log.levels` and currently include:
```lua
vim.diagnostic.severity.ERROR
vim.diagnostic.severity.WARN
vim.diagnostic.severity.INFO
vim.diagnostic.severity.HINT
```
In practice, these match the LSP diagnostic severity levels exactly, but we
should treat this as an interface and not assume that they are the same. The
"translation" between the two severity types is handled transparently in
`vim.lsp.diagnostic`.
* The actual "diagnostic" data structure is: (**EDIT:** Updated 2021-09-09):
```lua
{
lnum = <number>,
col = <number>,
end_lnum = <number>,
end_col = <number>,
severity = <vim.diagnostic.severity>,
message = <string>
}
```
This differs from the LSP definition of a diagnostic, so we transform them in
the handler functions in vim.lsp.diagnostic.
## Configuration
The `vim.lsp.with` paradigm still works for configuring how LSP diagnostics are
displayed, but this is a specific use-case for the `publishDiagnostics` handler.
Configuration with `vim.diagnostic` is instead done with the
`vim.diagnostic.config` function:
```lua
vim.diagnostic.config({
virtual_text = true,
signs = false,
underline = true,
update_in_insert = true,
severity_sort = false,
}[, namespace])
```
(or alternatively passed directly to `set()` or `show()`.)
When the `namespace` argument is `nil`, settings are set globally (i.e. for
*all* diagnostic namespaces). This is what user's will typically use for their
local configuration. Diagnostic producers can also set configuration options for
their specific namespace, although this is generally discouraged in order to
respect the user's global settings. All of the values in the table passed to
`vim.diagnostic.config()` are resolved in the same way that they are in
`on_publish_diagnostics`; that is, the value can be a boolean, a table, or
a function:
```lua
vim.diagnostic.config({
virtual_text = function(namespace, bufnr)
-- Only enable virtual text in buffer 3
return bufnr == 3
end,
})
```
## Misc Notes
* `vim.diagnostic` currently depends on `vim.lsp.util` for floating window
previews. I think this is okay for now, although ideally we'd want to decouple
these completely.
|
||
|---|---|---|
| .. | ||
| api.txt | ||
| arabic.txt | ||
| autocmd.txt | ||
| change.txt | ||
| channel.txt | ||
| cmdline.txt | ||
| debug.txt | ||
| deprecated.txt | ||
| develop.txt | ||
| diagnostic.txt | ||
| diff.txt | ||
| digraph.txt | ||
| editing.txt | ||
| eval.txt | ||
| filetype.txt | ||
| fold.txt | ||
| ft_ada.txt | ||
| ft_ps1.txt | ||
| ft_raku.txt | ||
| ft_rust.txt | ||
| ft_sql.txt | ||
| gui.txt | ||
| hebrew.txt | ||
| help.txt | ||
| helphelp.txt | ||
| if_cscop.txt | ||
| if_lua.txt | ||
| if_perl.txt | ||
| if_pyth.txt | ||
| if_ruby.txt | ||
| indent.txt | ||
| index.txt | ||
| insert.txt | ||
| intro.txt | ||
| job_control.txt | ||
| lsp-extension.txt | ||
| lsp.txt | ||
| lua.txt | ||
| Makefile | ||
| makehtml.awk | ||
| maketags.awk | ||
| map.txt | ||
| mbyte.txt | ||
| message.txt | ||
| mlang.txt | ||
| motion.txt | ||
| msgpack_rpc.txt | ||
| nvim_terminal_emulator.txt | ||
| nvim.txt | ||
| options.txt | ||
| pattern.txt | ||
| pi_gzip.txt | ||
| pi_health.txt | ||
| pi_msgpack.txt | ||
| pi_netrw.txt | ||
| pi_paren.txt | ||
| pi_spec.txt | ||
| pi_tar.txt | ||
| pi_tutor.txt | ||
| pi_zip.txt | ||
| print.txt | ||
| provider.txt | ||
| quickfix.txt | ||
| quickref.txt | ||
| recover.txt | ||
| remote_plugin.txt | ||
| repeat.txt | ||
| rileft.txt | ||
| russian.txt | ||
| scroll.txt | ||
| sign.txt | ||
| spell.txt | ||
| starting.txt | ||
| syntax.txt | ||
| tabpage.txt | ||
| tagsrch.txt | ||
| term.txt | ||
| testing.txt | ||
| tips.txt | ||
| treesitter.txt | ||
| uganda.txt | ||
| ui.txt | ||
| undo.txt | ||
| usr_01.txt | ||
| usr_02.txt | ||
| usr_03.txt | ||
| usr_04.txt | ||
| usr_05.txt | ||
| usr_06.txt | ||
| usr_07.txt | ||
| usr_08.txt | ||
| usr_09.txt | ||
| usr_10.txt | ||
| usr_11.txt | ||
| usr_12.txt | ||
| usr_20.txt | ||
| usr_21.txt | ||
| usr_22.txt | ||
| usr_23.txt | ||
| usr_24.txt | ||
| usr_25.txt | ||
| usr_26.txt | ||
| usr_27.txt | ||
| usr_28.txt | ||
| usr_29.txt | ||
| usr_30.txt | ||
| usr_31.txt | ||
| usr_32.txt | ||
| usr_40.txt | ||
| usr_41.txt | ||
| usr_42.txt | ||
| usr_43.txt | ||
| usr_44.txt | ||
| usr_45.txt | ||
| usr_toc.txt | ||
| various.txt | ||
| vi_diff.txt | ||
| vim_diff.txt | ||
| visual.txt | ||
| windows.txt | ||