neovim/test/functional
James McCoy 3a59b04c19
Correct logic for setting NormalState.toplevel
In Vim's main_loop function, the main loop is

        while (!cmdwin
    #ifdef FEAT_CMDWIN
                || cmdwin_result == 0
    #endif
                )
        {
    ...
    #ifdef FEAT_EVAL
            /*
             * May perform garbage collection when waiting for a character, but
             * only at the very toplevel.  Otherwise we may be using a List or
             * Dict internally somewhere.
             * "may_garbage_collect" is reset in vgetc() which is invoked through
             * do_exmode() and normal_cmd().
             */
            may_garbage_collect = (!cmdwin && !noexmode);
    #endif
            /*
             * If we're invoked as ex, do a round of ex commands.
             * Otherwise, get and execute a normal mode command.
             */
            if (exmode_active)
            {
                if (noexmode)   /* End of ":global/path/visual" commands */
                    return;
                do_exmode(exmode_active == EXMODE_VIM);
            }
            else
                normal_cmd(&oa, TRUE);
        }

cmdwin_result is set to 0 before calling main_loop to handle the cmdwin
window and gets changed when the user causes a command to execute
(either through pressing <CR> or <C-c>).  This means that when the
cmdwin isn't active OR the user is still editing their command,
main_loop runs and main_loop calls normal_cmd with toplevel true as long
as exmode isn't active.

When the normal mode state was extracted in dae006a9, the conditions for
toplevel and may_garbage_collect were combined.  Since toplevel was set
to always ignore cmdwin, the v:count(1) variables were no longer being
updated when a command was prefixed with a count in the cmdwin.

Closes #5404
2016-09-30 07:29:25 -04:00
..
api api: Establish API naming convention. (#5344) 2016-09-17 06:30:36 +02:00
autocmd Merge pull request #5225 from equalsraf/windows-functionaltests 2016-08-31 21:39:42 +02:00
clipboard Mark some functional tests as pending in Windows 2016-08-26 08:21:41 +01:00
core CI: Travis macOS: Skip tab left-drag tests. 2016-09-12 03:42:51 +02:00
eval api: Establish API naming convention. (#5344) 2016-09-17 06:30:36 +02:00
ex_cmds CI: test: Avoid QuickBuild hang. (#5330) 2016-09-12 03:18:48 +02:00
ex_getln functests: Check logs in lua code 2016-06-10 21:50:49 +03:00
fixtures CheckHealth: Accept [plugin1 [, plugin2 [, ...]]] args. 2016-08-21 22:03:28 -04:00
legacy test: legacy/012_directory_spec: Also use dot-prefix on Windows. 2016-09-20 11:08:14 +02:00
normal Correct logic for setting NormalState.toplevel 2016-09-30 07:29:25 -04:00
options Mark some functional tests as pending in Windows 2016-08-26 08:21:41 +01:00
plugin health.vim: Show results incrementally. 2016-09-05 19:22:01 -04:00
provider Merge #4980 'Support legacy :ruby commands'. 2016-07-10 14:16:12 -04:00
shada shada: Fix non-writeable ShaDa directory handling 2016-09-04 21:45:48 -04:00
shell Mark some functional tests as pending in Windows 2016-08-26 08:21:41 +01:00
terminal test: api_spec 2016-09-22 20:04:32 +02:00
ui api: Establish API naming convention. (#5344) 2016-09-17 06:30:36 +02:00
viml api: add tests for calling the api from vimscript 2016-08-31 21:57:06 +02:00
dict_notifications_spec.lua functests: Check logs in lua code 2016-06-10 21:50:49 +03:00
helpers.lua test: api_spec 2016-09-22 20:04:32 +02:00
preload.lua functests: Check logs in lua code 2016-06-10 21:50:49 +03:00