Vim-fork focused on extensibility and usability
Go to file
zeertzjq 0b23207c73 vim-patch:9.0.2074: Completion menu may be wrong
Problem:  Completion menu may be wrong
Solution: Check for the original direction of the completion menu,
          add more tests, make it work with 'noselect'

completion: move in right direction when  filling completion_info()

When moving through the insert completion menu and switching directions,
we need to make sure we start at the correct position in the list and
move correctly forward/backwards through it, so that we do not skip
entries and the selected item points to the correct entry in the list
of completion entries generated by the completion_info() function.

The general case is this:

1) CTRL-X CTRL-N, we will traverse the list starting from
   compl_first_match and then go forwards (using the cp->next pointer)
   through the list (skipping the very first entry, which has the
   CP_ORIGINAL_TEXT flag set (since that is the empty/non-selected entry

2) CTRL-X CTRL-P, we will traverse the list starting from
   compl_first_match (which now points to the last entry). The previous
   entry will have the CP_ORIGINAL_TEXT flag set, so we need to start
   traversing the list from the second prev pointer.

There are in fact 2 special cases after starting the completion menu
with CTRL-X:

3)  CTRL-N and then going backwards by pressing CTRL-P again.
    compl_first_match will point to the same entry as in step 1 above,
    but since compl_dir_foward() has been switched by pressing CTRL-P
    to backwards we need to pretend to be in still in case 1 and still
    traverse the list in forward direction using the cp_next pointer

4)  CTRL-P and then going forwards by pressing CTRL-N again.
    compl_first_match will point to the same entry as in step 2 above,
    but since compl_dir_foward() has been switched by pressing CTRL-N
    to forwards we need to pretend to be in still in case 2 and still
    traverse the list in backward direction using the cp_prev pointer

For the 'noselect' case however, this is slightly different again. When
going backwards, we only need to go one cp_prev pointer back. And
resting of the direction works again slightly different. So we need to
take the noselect option into account when deciding in which direction
to iterate through the list of matches.

related: vim/vim#13402
related: vim/vim#12971
closes: vim/vim#13408

daef8c7437

Co-authored-by: Christian Brabandt <cb@256bit.org>
2023-10-28 06:16:55 +08:00
.github ci: run tests in parallel 2023-10-22 16:13:34 +02:00
cmake build: enable formatting during rebase 2023-10-23 21:48:06 +02:00
cmake.config build: add CMAKE_C_FLAGS to --version output 2023-10-24 11:09:15 +02:00
cmake.deps build(deps): bump luajit to HEAD - e826d0c10 2023-10-21 14:14:12 +02:00
cmake.packaging build!: remove neovim qt 2023-06-06 19:19:00 +02:00
contrib build: remove luarocks 2023-09-10 15:32:47 +02:00
runtime fix(diagnostic): virtual_text prefix function should have index and total (#25801) 2023-10-27 08:17:46 -05:00
scripts feat(lsp): add snippet API (#25301) 2023-10-21 08:51:26 +02:00
src vim-patch:9.0.2074: Completion menu may be wrong 2023-10-28 06:16:55 +08:00
test vim-patch:9.0.2074: Completion menu may be wrong 2023-10-28 06:16:55 +08:00
.cirrus.yml ci(cirrus): use FreeBSD 13.2 (#24684) 2023-09-11 12:41:53 +08:00
.clang-format build: align .clang-format rules with uncrustify config 2023-05-28 15:39:43 +02:00
.clang-tidy refactor(clang-tidy): ignore warnings from clang-tidy 17 2023-09-24 04:58:49 +02:00
.clangd Adding clangd language serever config file to point to build/ directory for compile_commands.json 2021-06-28 11:03:09 -04:00
.editorconfig build(editorconfig): set indent_size to 4 for python files (#21135) 2022-11-21 06:53:29 -07:00
.git-blame-ignore-revs docs: .git-blame-ignore-revs (#20820) 2022-10-27 20:31:09 +02:00
.gitattributes docs(options): take ownership of options.txt (#24528) 2023-08-04 21:26:53 +01:00
.gitignore feat: add .luarc.json (#24592) 2023-08-07 16:27:53 +01:00
.luacheckrc feat(lua-types): types for vim.api.* (#24523) 2023-08-01 14:20:44 +01:00
.luacov Lua: vim.validate() 2019-11-10 22:50:24 -08:00
.luarc.json fix(luarc.json): ignore test directory to save memory 2023-08-23 14:25:36 +01:00
.mailmap docs: update .mailmap (#20086) 2022-09-06 08:57:03 +02:00
.stylua.toml refactor(lua): reformat with stylua 0.14.0 (#19264) 2022-07-07 18:27:18 +02:00
.styluaignore build(lint): use stylua without add_glob_target 2023-09-14 09:58:50 +02:00
BACKERS.md Update backer URL 2015-11-11 19:50:33 -08:00
BSDmakefile feat(lua)!: register_keystroke_callback => on_key 2021-09-09 06:09:33 -07:00
CMakeLists.txt build: adjust how find order is prioritized 2023-10-16 20:15:41 +02:00
CMakePresets.json build: add "ci" configure preset to reduce verbosity 2023-04-23 17:12:46 +02:00
CONTRIBUTING.md docs: Lua docstrings guidance #25345 2023-09-27 21:57:22 -07:00
LICENSE.txt vim-patch:e978b4534a5e (#24697) 2023-08-13 13:25:10 +01:00
MAINTAIN.md feat(meta): add types for vim.lpeg 2023-09-24 22:10:10 +02:00
Makefile ci: enable clang-analyzer warnings 2023-10-09 16:52:28 +02:00
README.md fix(messages): use "Vimscript" instead of "VimL" #24111 2023-06-22 04:09:14 -07:00

Neovim

Documentation | Chat

Coverity Scan analysis Clang analysis PVS-Studio analysis Packages Debian CI Downloads

Neovim is a project that seeks to aggressively refactor Vim in order to:

See the Introduction wiki page and Roadmap for more information.

Features

See :help nvim-features for the full list, and :help news for noteworthy changes in the latest version!

Install from package

Pre-built packages for Windows, macOS, and Linux are found on the Releases page.

Managed packages are in Homebrew, Debian, Ubuntu, Fedora, Arch Linux, Void Linux, Gentoo, and more!

Install from source

See the Building Neovim wiki page and supported platforms for details.

The build is CMake-based, but a Makefile is provided as a convenience. After installing the dependencies, run the following command.

make CMAKE_BUILD_TYPE=RelWithDebInfo
sudo make install

To install to a non-default location:

make CMAKE_BUILD_TYPE=RelWithDebInfo CMAKE_INSTALL_PREFIX=/full/path/
make install

CMake hints for inspecting the build:

  • cmake --build build --target help lists all build targets.
  • build/CMakeCache.txt (or cmake -LAH build/) contains the resolved values of all CMake variables.
  • build/compile_commands.json shows the full compiler invocations for each translation unit.

Transitioning from Vim

See :help nvim-from-vim for instructions.

Project layout

├─ cmake/           CMake utils
├─ cmake.config/    CMake defines
├─ cmake.deps/      subproject to fetch and build dependencies (optional)
├─ runtime/         plugins and docs
├─ src/nvim/        application source code (see src/nvim/README.md)
│  ├─ api/          API subsystem
│  ├─ eval/         Vimscript subsystem
│  ├─ event/        event-loop subsystem
│  ├─ generators/   code generation (pre-compilation)
│  ├─ lib/          generic data structures
│  ├─ lua/          Lua subsystem
│  ├─ msgpack_rpc/  RPC subsystem
│  ├─ os/           low-level platform code
│  └─ tui/          built-in UI
└─ test/            tests (see test/README.md)

License

Neovim contributions since b17d96 are licensed under the Apache 2.0 license, except for contributions copied from Vim (identified by the vim-patch token). See LICENSE for details.

Vim is Charityware.  You can use and copy it as much as you like, but you are
encouraged to make a donation for needy children in Uganda.  Please see the
kcc section of the vim docs or visit the ICCF web site, available at these URLs:

        https://iccf-holland.org/
        https://www.vim.org/iccf/
        https://www.iccf.nl/

You can also sponsor the development of Vim.  Vim sponsors can vote for
features.  The money goes to Uganda anyway.