mirror of
https://github.com/neovim/neovim.git
synced 2024-12-19 10:45:16 -07:00
7ed6966023
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Problem: The "*.*" browsefilter pattern only matches all files on
Windows (Daryl Lee)
Solution: Use "*" to filter on all platforms but keep "*.*" as the label
text on Windows. (Fixes vim/vim#12685, Doug Kearns)
The *.* browsefilter pattern used to match "All Files" on Windows is a
legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons
of backward compatibility this still works on Windows to match all
files, even those without an extension.
However, this pattern only matches filenames containing a dot on other
platforms. This often makes files without an extension difficult to
access from the file dialog, e.g., "Makefile"
On Windows it is still standard practice to use "*.*" for the filter
label so ftplugins should use "All Files (*.*)" on Windows and "All
Files (*)" on other platforms. This matches Vim's default browsefilter
values.
This commit also normalises the browsefilter conditional test to check
for the Win32 and GTK GUI features and an unset b:browsefilter.
closes: vim/vim#12759
93197fde0f
Co-authored-by: Doug Kearns <dougkearns@gmail.com>
55 lines
1.4 KiB
VimL
55 lines
1.4 KiB
VimL
" Vim filetype plugin file
|
|
" Language: MS-DOS/Windows .bat files
|
|
" Maintainer: Mike Williams <mrmrdubya@gmail.com>
|
|
" Last Change: 12th February 2023
|
|
" 2024 Jan 14 by Vim Project (browsefilter)
|
|
"
|
|
" Options Flags:
|
|
" dosbatch_colons_comment - any value to treat :: as comment line
|
|
|
|
" Only do this when not done yet for this buffer
|
|
if exists("b:did_ftplugin")
|
|
finish
|
|
endif
|
|
|
|
" Don't load another plugin for this buffer
|
|
let b:did_ftplugin = 1
|
|
|
|
let s:cpo_save = &cpo
|
|
set cpo&vim
|
|
|
|
" BAT comment formatting
|
|
setlocal comments=b:rem,b:@rem,b:REM,b:@REM
|
|
if exists("dosbatch_colons_comment")
|
|
setlocal comments+=:::
|
|
setlocal commentstring=::\ %s
|
|
else
|
|
setlocal commentstring=REM\ %s
|
|
endif
|
|
setlocal formatoptions-=t formatoptions+=rol
|
|
|
|
" Lookup DOS keywords using Windows command help.
|
|
if executable('help.exe')
|
|
if has('terminal')
|
|
setlocal keywordprg=:term\ help.exe
|
|
else
|
|
setlocal keywordprg=help.exe
|
|
endif
|
|
endif
|
|
|
|
" Define patterns for the browse file filter
|
|
if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter")
|
|
let b:browsefilter = "DOS Batch Files (*.bat, *.cmd)\t*.bat;*.cmd\n"
|
|
if has("win32")
|
|
let b:browsefilter ..= "All Files (*.*)\t*\n"
|
|
else
|
|
let b:browsefilter ..= "All Files (*)\t*\n"
|
|
endif
|
|
endif
|
|
|
|
let b:undo_ftplugin = "setlocal comments< formatoptions< keywordprg<"
|
|
\ . "| unlet! b:browsefilter"
|
|
|
|
let &cpo = s:cpo_save
|
|
unlet s:cpo_save
|