Merge 4bda502014 into 7121983c45

Problem: internal augroup need nvim_ prefix and test case postion inside wrong function block

Solution: add nvim_ prefix and move the test case to a single block

runtime/lua/vim/lsp/util.lua

@@ -1618,18 +1618,16 @@ function M.open_floating_preview(contents, syntax, opts)
     api.nvim_buf_set_var(bufnr, 'lsp_floating_preview', floating_winnr)
   end
 
-  local augroup_name = ('closing_floating_preview_%d'):format(floating_winnr)
-  local ok =
-    pcall(api.nvim_get_autocmds, { group = augroup_name, pattern = tostring(floating_winnr) })
-  if not ok then
+  local augroup_name = 'nvim_closing_floating_preview'
+  if vim.fn.exists(('#%s'):format(augroup_name)) == 0 then
     api.nvim_create_autocmd('WinClosed', {
-      group = api.nvim_create_augroup(augroup_name, {}),
-      pattern = tostring(floating_winnr),
-      callback = function()
-        if api.nvim_buf_is_valid(bufnr) then
+      group = api.nvim_create_augroup(augroup_name, { clear = true }),
+      callback = function(args)
+        if
+          tonumber(args.match) == vim.b[bufnr].lsp_floating_preview and api.nvim_buf_is_valid(bufnr)
+        then
           vim.b[bufnr].lsp_floating_preview = nil
         end
-        api.nvim_del_augroup_by_name(augroup_name)
       end,
     })
   end

test/functional/plugin/lsp/utils_spec.lua

@@ -267,8 +267,16 @@ describe('vim.lsp.util', function()
 
         eq(56, opts.height)
       end)
+    end)
+  end)
+
+  describe('open_floating_preview', function()
+    before_each(function()
+      n.clear()
+      Screen.new(10, 10)
+      feed('9i<CR><Esc>G4k')
+    end)
 
-      describe('vim.lsp.util.open_floating_preview', function()
     local var_name = 'lsp_floating_preview'
     local curbuf = api.nvim_get_current_buf()
 
@@ -278,10 +286,7 @@ describe('vim.lsp.util', function()
       end)
       eq(true, api.nvim_win_is_valid(api.nvim_buf_get_var(curbuf, var_name)))
       command('fclose')
-          eq(
-            'Key not found: lsp_floating_preview',
-            pcall_err(api.nvim_buf_get_var, curbuf, var_name)
-          )
+      eq('Key not found: lsp_floating_preview', pcall_err(api.nvim_buf_get_var, curbuf, var_name))
     end)
 
     it('clean bufvar after CursorMoved', function()
@@ -293,12 +298,7 @@ describe('vim.lsp.util', function()
         return result
       end)
       eq(true, result)
-          eq(
-            'Key not found: lsp_floating_preview',
-            pcall_err(api.nvim_buf_get_var, curbuf, var_name)
-          )
-        end)
-      end)
+      eq('Key not found: lsp_floating_preview', pcall_err(api.nvim_buf_get_var, curbuf, var_name))
     end)
   end)
 end)