Ihor Antonov
e0f2c36667
PVS/V560: condition is always true #10630
...
earlier condition leads to short-circuit of the loop
2019-07-28 11:08:41 +02:00
Ihor Antonov
ce59a70f5b
PVS/V560: condition is always true #10624
...
* before changed line status variable is set to RA_FAIL in 2 places
line 3816 and 3826, both lead to short-circuit of the loop, making
comparing it to RA_FAIL useless
close #10624
2019-07-28 10:59:44 +02:00
Ihor Antonov
5b47ee5b7a
pvs/V560: part of conditional expression is always true ( #10629 )
...
Since timed_out is pointer to int condition timed_out != NULL && timed_out makes no sense as both are effectively the same thing. Most likely the first check was meant to guard the dereference of the second.
Wrong import of Vim patch (8.0.0643).
2019-07-28 05:16:14 +02:00
notomo
32a6b5601b
Fix clint error
2019-07-28 09:22:46 +09:00
notomo
08c7e206cc
vim-patch:8.1.1759: no mode char for terminal mapping from maparg()
...
Problem: No mode char for terminal mapping from maparg().
Solution: Check for TERMINAL mode. (closes vim/vim#4735 )
14371ed697
2019-07-28 08:00:52 +09:00
cangscop
dedcd3ad1e
vim-patch:8.1.0053 use typval_T in the caller of call_vim_function
...
Problem: unreliable types for complete function arguments
Solution: fix argument type for functions w/ unreliable type conversion(Ozaki Kiichi)
vim/vim#2993
2019-07-28 00:19:41 +02:00
Daniel Hahler
7f5a113f65
vim-patch:8.1.1748: :args output is not aligned ( #10625 )
...
Problem: :args output is not aligned.
Solution: Output a line break after the last item in a row.
74da39373c
vim-patch:8.1.1750: depending on the terminal width :version may miss a line break
Problem: Depending on the terminal width :version may miss a line break.
Solution: Add a line break when needed.
8a5c29aee9
vim-patch:8.1.1760: extra line break for wrapping output of :args
Problem: Extra line break for wrapping output of :args.
Solution: Avoid the extra line break. (Daniel Hahler, closes vim/vim#4737 )
9800bfe0fc
2019-07-27 23:48:32 +02:00
Justin M. Keyes
8e6b0a73c9
Merge #10619 'API: context'
2019-07-27 22:56:05 +02:00
Abdelhakeem
b6278bbf12
API: Context: save/restore
2019-07-27 22:14:58 +02:00
Jan Edmund Lazo
0e23ee3cc7
vim-patch:8.1.0956: context:0 in 'diffopt' #10622
...
Problem: Using context:0 in 'diffopt' does not work well.
Solution: Make zero context do the same as one line context. (closes vim/vim#4005 )
b9ddda6c2d
2019-07-27 20:33:33 +02:00
Abdelhakeem
691deca2e8
eval: context: add ctx-family functions
2019-07-27 16:36:56 +02:00
Abdelhakeem
a80f691a6a
API: Context
2019-07-27 16:36:56 +02:00
Justin M. Keyes
411a06c8b6
API: Context
2019-07-27 16:36:57 +02:00
cangscop
0364e47ccb
vim-patch:8.1.53 use typval_T in the caller of call_vim_function
...
Problem: unreliable types for complete function arguments
Solution: fix argument type for functions w/ unreliable type conversion(Ozaki Kiichi)
vim/vim#2993
2019-07-27 16:25:33 +02:00
Daniel Hahler
997601d966
ci: AppVeyor: DEPS_BUILD_DIR is not a CMake variable [ci skip] ( #10613 )
...
Fixes:
> CMake Warning:
> Manually-specified variables were not used by the project:
>
> DEPS_BUILD_DIR
2019-07-27 11:55:17 +02:00
Daniel Hahler
7be85ed0f5
ci: Travis: single osx job [ci skip] ( #10614 )
...
The "osx" jobs are the slowest ones, and often still flaky.
I think it is good enough to have a single one there (since they only use
different compilers).
This should improve build times in general (with multiple running
builds, since we're using less jobs per build), and also make flaky job
failures less likely.
2019-07-27 11:50:44 +02:00
Daniel Hahler
0b4123668a
ci: Travis: gcc-9: use gcov-9 ( #10609 )
2019-07-27 02:04:49 +02:00
Daniel Hahler
709e87792f
tests: test_arglist.vim: align with Vim [ci skip] ( #10612 )
...
This just moves the test to where it is in Vim.
2019-07-27 01:47:12 +02:00
Justin M. Keyes
af01b347d8
Merge #10606 'vim-patch:8.1.0404'
2019-07-27 01:33:58 +02:00
Daniel Hahler
e1a5c29b93
ci: Travis: remove clang-tsan from allowed failures [skip ci] ( #10591 )
...
While it still might be flaky sometimes, it is far better than the
osx jobs in general, and due to it being allowed to fail, we are not
getting aware of more recent (flaky) issues due to building tags during
make-install, which might indicate a more generic problem.
2019-07-27 01:32:02 +02:00
Daniel Hahler
809613c952
Merge pull request #10580 from blueyed/tests-cat
...
tests: use "cat" also on Windows
2019-07-27 00:59:27 +02:00
erw7
53d1801b49
tests: win: fix "cat" with PowerShell
...
Ref: https://github.com/neovim/neovim/pull/10580#issuecomment-514884092
2019-07-26 21:45:24 +02:00
Daniel Hahler
2906c702f9
tests: use "cat" also on Windows
...
Fixes https://github.com/neovim/neovim/issues/10574 .
Keeps 'can be called recursively' pending for now, see
https://github.com/neovim/neovim/pull/10580#issuecomment-515295571 .
2019-07-26 21:45:00 +02:00
Jan Edmund Lazo
2b731a388a
vim-patch:8.1.1747: unused variables #10605
...
Problem: Compiler warning for unused variables. (Tony Mechelynck)
Solution: Add #ifdef.
fbfb757d4c
2019-07-26 11:21:44 +02:00
Jan Edmund Lazo
0fb05b2c7d
Revert "vim-patch:8.1.0430: Xargadd file left behind after running test"
...
This reverts commit ce1b4f95fe
.
2019-07-26 05:19:05 -04:00
Jan Edmund Lazo
cbda383efe
vim-patch:8.1.0404: accessing invalid memory with long argument name
...
Problem: Accessing invalid memory with long argument name.
Solution: Use item_count instead of checking for a terminating NULL.
(Dominique Pelle, closes vim/vim#3444 )
e961cba3cb
2019-07-26 05:19:05 -04:00
Justin M. Keyes
b42bfa599b
Merge #10589 'os/fs: introduce os_fopen()'
2019-07-26 11:18:19 +02:00
Justin M. Keyes
2731080212
cleanup: remove mch_fopen in favor of os_fopen
2019-07-25 22:32:23 +02:00
Justin M. Keyes
bb3a0099c6
os/fs: introduce os_fopen()
...
Windows: Using fopen() directly may need UTF-16 filepath conversion. To
achieve that, os_fopen() goes through os_open().
fix #10586
2019-07-25 22:32:23 +02:00
Ihor Antonov
8a9c9a9963
PVS/V768: do use enum as bool #10582
...
Fix win_draw_end invocation, pass HLF symbol explicitly.
2019-07-25 21:57:58 +02:00
Justin M. Keyes
36622014c6
Merge #10596 'vim-patch:8.1.{899,903,905,907,908,910,913,1746}'
...
close #9930
close #10051
2019-07-25 12:00:08 +02:00
Jan Edmund Lazo
0925afcfcf
regexp: add function attributes
2019-07-25 03:34:26 -04:00
Jan Edmund Lazo
98fcf66b7a
vim-patch:8.1.0913: CI crashes when running out of memory
...
Problem: CI crashes when running out of memory.
Solution: Apply 'maxmempattern' also to new regexp engine.
688b3983d8
2019-07-25 03:02:22 -04:00
Jan Edmund Lazo
52488ea6fb
vim-patch:8.1.0910: crash with tricky search pattern
...
Problem: Crash with tricky search pattern. (Kuang-che Wu)
Solution: Check for runnning out of memory. (closes vim/vim#3950 )
15bbd6ec87
2019-07-25 02:39:24 -04:00
Jan Edmund Lazo
fb059a1741
vim-patch:8.1.0907: CI tests on AppVeyor are failing
...
Problem: CI tests on AppVeyor are failing.
Solution: Reduce the recursiveness limit for regexp.
5382f12c91
2019-07-25 02:21:32 -04:00
Jan Edmund Lazo
a77e5b3606
vim-patch:8.1.0905: complicated regexp causes a crash
...
Problem: Complicated regexp causes a crash. (Kuang-che Wu)
Solution: Limit the recursiveness of addstate(). (closes vim/vim#3941 )
5567ad48b6
2019-07-25 02:04:32 -04:00
Jan Edmund Lazo
8e490b98cc
regexp: use fixed types to avoid overflow
2019-07-24 21:50:16 -04:00
Gabriel
33ce6a7f62
Checks for overflow when parsing string to int
2019-07-24 21:43:04 -04:00
Jan Edmund Lazo
43f4e5d5be
vim-patch:8.1.0908: can't handle large value for %{nr}v in regexp
...
Problem: Can't handle large value for %{nr}v in regexp. (Kuang-che Wu)
Solution: Give an error if the value is too large. (closes vim/vim#3948 )
9403a2168d
2019-07-24 21:43:04 -04:00
Jan Edmund Lazo
9ea449085d
vim-patch:8.1.1746: ":dl" is seen as ":dlist" instead of ":delete"
...
Problem: ":dl" is seen as ":dlist" instead of ":delete".
Solution: Do not use cmdidxs2[] if the length is 1. (closes vim/vim#4721 )
94f82cbacf
2019-07-24 21:43:04 -04:00
Jan Edmund Lazo
80487b59c9
vim-patch:8.1.0903: struct uses more bytes than needed
...
Problem: Struct uses more bytes than needed.
Solution: Reorder members of regitem_S. (Dominique Pelle, closes vim/vim#3936 )
beb7574d6b
2019-07-24 19:46:09 -04:00
Jan Edmund Lazo
2385039623
vim-patch:8.1.0899: no need to check restricted mode for setwinvar()
...
Problem: No need to check restricted mode for setwinvar().
Solution: Remove check_restricted().
e0fb7d1e38
2019-07-24 19:46:09 -04:00
Daniel Hahler
d1faf900b1
coverage: use "cd" with gcovr ( #10594 )
...
This makes the invocation compatible for the upcoming gcovr 4.2 release,
and is the correct way of invoking it.
Ref: https://github.com/gcovr/gcovr/commit/a782972#commitcomment-34420728
2019-07-25 01:11:17 +02:00
Daniel Hahler
b8fcf62da9
vim-patch:8.1.1740: exepath() doesn't work for "bin/cat" ( #10556 )
...
Problem: Exepath() doesn't work for "bin/cat".
Solution: Check for any path separator. (Daniel Hahler, closes vim/vim#4724 ,
closes vim/vim#4710 )
d08b8c4c04
Fixes https://github.com/neovim/neovim/issues/10554 .
2019-07-24 22:23:00 +02:00
Daniel Hahler
3566267e75
vim-patch:8.1.1738: testing lambda with timer is slow ( #10590 )
...
Problem: Testing lambda with timer is slow.
Solution: Do not test timer accuracy, only that it works. (Daniel Hahler,
closes vim/vim#4723 )
9bc4dde45d
2019-07-24 19:47:41 +02:00
Daniel Hahler
8404e8df20
third-party: download: retry ( #10599 )
...
This is meant to handle the common case of failing to download
libtermkey:
FAILED: cd /home/travis/build/neovim/neovim/deps-downloads/libtermkey && /usr/local/cmake-3.12.4/bin/cmake -DPREFIX=/home/travis/nvim-deps/build -DDOWNLOAD_DIR=/home/travis/build/neovim/neovim/deps-downloads/libtermkey -DURL=http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.21.1.tar.gz -DEXPECTED_SHA256=cecbf737f35d18f433c8d7864f63c0f878af41f8bd0255a3ebb16010dc044d5f -DTARGET=libtermkey -DUSE_EXISTING_SRC_DIR=OFF -P /home/travis/build/neovim/neovim/third-party/cmake/DownloadAndExtractFile.cmake && /usr/local/cmake-3.12.4/bin/cmake -E touch /home/travis/nvim-deps/build/src/libtermkey-stamp/libtermkey-download
-- file: /home/travis/build/neovim/neovim/deps-downloads/libtermkey/libtermkey-0.21.1.tar.gz
-- downloading...
src='http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.21.1.tar.gz '
dst='/home/travis/build/neovim/neovim/deps-downloads/libtermkey/libtermkey-0.21.1.tar.gz'
timeout='none'
CMake Error at /home/travis/build/neovim/neovim/third-party/cmake/DownloadAndExtractFile.cmake:77 (message):
error: downloading
'http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.21.1.tar.gz ' failed
status_code: 6
status_string: "Couldn't resolve host name"
log: Curl_ipv4_resolve_r failed for www.leonerd.org.uk
Couldn't resolve host 'www.leonerd.org.uk'
Closing connection 0
Co-Authored-By: Justin M. Keyes <justinkz@gmail.com>
2019-07-24 19:11:27 +02:00
Daniel Hahler
431cf56e2f
ci: RunTests: ensure that the logfile gets displayed ( #10597 )
...
This is meant to help with test failures where e.g. `busted` itself might
crash or get killed.
Ref: https://github.com/neovim/neovim/issues/10182#issuecomment-514450069
2019-07-24 18:12:55 +02:00
Jan Edmund Lazo
06547cdfc0
sign: REMOVE FEAT_SIGN_ICONS, dead code #10595
2019-07-24 12:17:53 +02:00
Daniel Hahler
451f6046b0
tests: AppVeyor: fix test/functional/ex_cmds/arg_spec.lua ( #10598 )
...
For unknown reasons it does not have the trailing space in `:args`
output there anymore:
[ FAILED ] test/functional\ex_cmds\arg_spec.lua @ 11: :argument does not restart :terminal buffer
test/functional\ex_cmds\arg_spec.lua:25: Expected objects to be the same.
Passed in:
(string) '
[term://.//4552:C:\Windows\system32\cmd.exe]'
Expected:
(string) '
[term://.//4552:C:\Windows\system32\cmd.exe] '
stack traceback:
test/functional\ex_cmds\arg_spec.lua:25: in function <test/functional\ex_cmds\arg_spec.lua:11>
The test is not about that though, and this can be made less strict by
using `trim()`. The new test in `test_arglist.vim` for no trailing
newline is OK, and contains trailing spaces. So this is likely due to
the length of it exceeding the column width already.
2019-07-24 09:31:46 +02:00
Daniel Hahler
733e1a0e73
vim-patch:8.1.1737: :args command that outputs one line gives more prompt
...
Problem: :args command that outputs one line gives more prompt.
Solution: Only output line break if needed. (Daniel Hahler, closes vim/vim#4715 )
949f1989cb
Closes https://github.com/neovim/neovim/pull/10147 .
2019-07-24 06:14:12 +02:00