Jan Edmund Lazo
22804c66a5
vim-patch:8.0.1807: function to set terminal name is too long
...
Problem: Function to set terminal name is too long.
Solution: Refactor the function. Fix typo in test.
69e056915c
2018-10-06 11:36:12 -04:00
Justin M. Keyes
6fe9a12268
Merge #9090 'clint.py: --stdin-filename'
2018-10-06 15:17:52 +02:00
Björn Linse
075dc42fb2
test: replace wait() with pre-assertion in assert_term_colors
2018-10-06 11:36:09 +02:00
Björn Linse
1bf83ea8e1
TUI: delete "first-row" workaround after resize
...
This was caused by cursor position being invalid right
after tui_grid_resize, which is now fixed
2018-10-06 11:36:08 +02:00
Björn Linse
cc305213d7
TUI: always use safe cursor movement after resize
...
The old code could lead to a memory error in the following situation:
0. The previous cursor position was row 50 since before, on a grid
larger than 50 rows.
1. grid_resize changes the grid height to 40, and invalidly assumes the
resize moved the physical cursor to row 0
2. Some event used a operation that could move the cursor (such as clear), and
then reset the cursor to the "true" position row 50 (pointless after #8221 , but
I forgot to remove it)
3. raw_line/cheap_to_print is invoked, and tries to inspect the grid at
row 50 (memory error)
4. grid_cursor_goto would have been called at this point, and set a
valid cursor position 0-39.
2018-10-06 11:29:51 +02:00
Daniel Hahler
1e7eb20c91
clint: add support for --stdin-filename
2018-10-05 23:14:14 +02:00
Daniel Hahler
2351b931dd
clint: use fileinput for stdin
...
Fixes handing of "-" on Python 3:
Traceback (most recent call last):
File "…/Vcs/neovim/src/clint.py", line 3625, in <module>
main()
File "…/Vcs/neovim/src/clint.py", line 3618, in main
ProcessFile(filename, _cpplint_state.verbose_level)
File "…/Vcs/neovim/src/clint.py", line 3464, in ProcessFile
'replace').read().split('\n')
File "/usr/lib/python3.7/codecs.py", line 701, in read
return self.reader.read(size)
File "/usr/lib/python3.7/codecs.py", line 500, in read
data = self.bytebuffer + newdata
TypeError: can't concat str to bytes
2018-10-05 23:13:44 +02:00
Daniel Hahler
39ad99b594
TUI: check libvte version for undercurl support #9088
...
Support was added in https://github.com/GNOME/vte/commit/efaf8f3c .
Fixes #9083
2018-10-05 14:54:04 +02:00
Justin M. Keyes
c05982cf35
vim-patch.sh: Skip Vim screen-dump files
2018-10-05 09:51:38 +02:00
Jan Edmund Lazo
c1c5c4f8e4
vim-patch:8.1.0440: remove() with a range not sufficiently tested ( #9076 )
...
Problem: remove() with a range not sufficiently tested.
Solution: Add a test. (Dominique Pelle, closes vim/vim#3497 )
2bfddfc508
2018-10-04 18:40:59 +02:00
Justin M. Keyes
79b358facd
Merge #9078 from janlazo/vim-8.0.1832
2018-10-04 11:43:56 +02:00
James McCoy
94e585944d
Merge pull request #9081 from jamessan/embed-crash
...
Fix crash if --embed is used more than once
2018-10-03 10:04:54 -04:00
James McCoy
eb7b2c7912
Fix crash if --embed is used more than once
2018-10-03 07:29:08 -04:00
Jan Edmund Lazo
c0d835764f
vim-patch:8.1.0047: no completion for :unlet $VAR
...
Problem: No completion for :unlet $VAR.
Solution: Add completion. (Jason Franklin)
1983401088
2018-10-02 22:47:47 -04:00
Jan Edmund Lazo
07fbdf4acc
vim-patch:8.0.1832: cannot use :unlet for an environment variable
...
Problem: Cannot use :unlet for an environment variable.
Solution: Make it work. Use unsetenv() if available.
(Yasuhiro Matsumoto, closes vim/vim#2855 )
137374fd65
2018-10-02 20:44:48 -04:00
Daniel Hahler
65206714bc
TUI: fix support for undercurl/underline color #9080
2018-10-03 00:35:25 +02:00
Björn Linse
14ae394532
Merge pull request #9052 from blueyed/undercurl
...
tui: add support for undercurl and colored underline
2018-10-02 15:10:47 +02:00
Björn Linse
171c80e227
Merge pull request #9064 from bfredl/uidoc
...
UI: rename ext_newgrid to ext_linegrid and add --embed UI startup recommendations
2018-10-02 10:55:47 +02:00
Björn Linse
bab3b0ad45
ui: reserve the right to split a screen redraw into multiple batches.
2018-10-02 10:52:37 +02:00
Björn Linse
43823acae2
ui: rename ext_newgrid to ext_linegrid
2018-10-01 21:24:15 +02:00
Björn Linse
b98af01260
ui: update docs for safe startup procedure
2018-10-01 21:24:15 +02:00
Daniel Hahler
c4006a621e
tui: add support for undercurl and underline color
...
Fixes https://github.com/neovim/neovim/issues/7479 .
2018-10-01 16:22:26 +02:00
Justin M. Keyes
8ac44984c4
Revert "TUI: terminfo_start: use unibi_from_term directly"
...
If $TERM is not defined then unibi_from_term() would crash.
Reverts 3bdc34d065
.
ref #9072
2018-10-01 00:42:19 +02:00
James McCoy
e2647366c9
Merge pull request #9073 from blueyed/vim-patch-ff
...
vim-patch.sh: use --ff with git-pull
2018-09-30 18:36:19 -04:00
Daniel Hahler
c2f337ce97
vim-patch.sh: use --ff with git-pull
...
I have `merge.ff = no` in my Git config to not use fast-forward merges
by default, but when updating the Vim sources it should not cause a
merge commit.
[ci skip]
2018-09-30 21:05:26 +02:00
Daniel Hahler
3bdc34d065
TUI: terminfo_start: use unibi_from_term directly ( #9072 )
...
Avoids redundant call to `getenv("TERM")`.
Ref: e3b16d6219/uniutil.c (L203-L211)
2018-09-30 20:39:45 +02:00
Justin M. Keyes
3999aa755e
man.vim: set $MANWIDTH=999
...
On some systems, mandoc disallows $MANWIDTH greater than 1000.
E.g. FreeBSD:
b7d613ae8a/contrib/mandoc/manpath.c (L312)
closes #9065
2018-09-30 18:35:19 +02:00
ssteinbach
6c496db4b7
undo: Fix infinite loop if undo_read_byte returns EOF #2880
...
Problem: Corrupt(?) persistent undofile leads to an infinite loop.
Solution: Break out of loop if undo_read_byte returns EOF (cf.
u_read_undo() which does this too).
backtrace from lldb (@ a743297be2
):
Process 70700 stopped
* thread 1: tid = 0x147d2d1, 0x00007fff8c8facd7 libsystem_pthread.dylib`__mtx_droplock + 209, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
frame 0: 0x00007fff8c8facd7 libsystem_pthread.dylib`__mtx_droplock + 209
libsystem_pthread.dylib`__mtx_droplock + 209:
-> 0x7fff8c8facd7: movq %rcx, -0x50(%rbp)
0x7fff8c8facdb: movq %r8, -0x58(%rbp)
0x7fff8c8facdf: movq %rdx, -0x68(%rbp)
0x7fff8c8face3: movq %r14, -0x60(%rbp)
(lldb) bt
* thread 1: tid = 0x147d2d1, 0x00007fff8c8facd7 libsystem_pthread.dylib`__mtx_droplock + 209, queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
* frame 0: 0x00007fff8c8facd7 libsystem_pthread.dylib`__mtx_droplock + 209
frame 1: 0x00007fff8c8fab4e libsystem_pthread.dylib`pthread_mutex_unlock + 63
frame 2: 0x00007fff915da2a4 libsystem_c.dylib`getc + 63
frame 3: 0x000000010e6194b9 nvim`undo_read_byte(bi=0x00007fff5181a838) + 25 at undo.c:1553
frame 4: 0x000000010e619685 nvim`unserialize_uhp(bi=0x00007fff5181a838, file_name=0x000000000f2e8060) + 421 at undo.c:840
frame 5: 0x000000010e618abb nvim`u_read_undo(name=0x0000000000000000, hash=0x00007fff5181af80, orig_name=0x000000000f370dd0) + 1579 at undo.c:1363
frame 6: 0x000000010e4a8db9 nvim`readfile(fname=0x000000000f370dd0, sfname=0x000000000f370dd0, from=0, lines_to_skip=0, lines_to_read=2147483647, eap=0x00007fff5181b6a0, flags=1) + 21017 at fileio.c:
1961
frame 7: 0x000000010e3ecc8b nvim`open_buffer(read_stdin=0, eap=0x00007fff5181b6a0, flags=0) + 603 at buffer.c:153
...
closes #2879
closes #2880
2018-09-30 17:54:24 +02:00
Matěj Cepl
84fcba9b01
editorconfig: Fix charset name #9070
...
According to
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties
the possible values of the charset property are "latin1", "utf-8",
"utf-16be", "utf-16le", or "utf-8-bom" (case insensitive), not "utf_8"
It breaks https://github.com/sgur/vim-editorconfig/ for example.
2018-09-30 17:02:19 +02:00
Daniel Hahler
4c57169745
dialog_changed: Remove mistaken assert #9069
...
It fails with `nvim -u NONE -c 'set modified' -c 'confirm q'`.
Introduced in 3dffc842f
(vim-patch:8.0.0983), but the Vim patch [1] does not
have this assertion.
NULL gets handled in `dialog_msg` [2].
1: 3f9a1ff141
2: c6d36b97ba/src/nvim/ex_docmd.c (L9704-L9705)
2018-09-30 15:47:02 +02:00
Justin M. Keyes
c6d36b97ba
Merge #9067 from janlazo/vim-8.0.1485
2018-09-30 14:48:29 +02:00
Jan Edmund Lazo
9dcd5bd9c5
vim-patch:8.1.0067: syntax highlighting not working when re-entering a buffer
...
Problem: Syntax highlighting not working when re-entering a buffer.
Solution: Do force executing autocommands when not called recursively.
a5616b0136
2018-09-30 02:58:34 -04:00
Jan Edmund Lazo
6a680548ec
vim-patch:8.1.0066: nasty autocommand causes using freed memory
...
Problem: Nasty autocommand causes using freed memory. (Dominique Pelle)
Solution: Do not force executing autocommands if the value of 'syntax' or
'filetype' did not change.
c3ffc9b8d3
2018-09-30 02:51:04 -04:00
Jan Edmund Lazo
33ef959814
vim-patch:8.1.0068: nasty autocommands can still cause using freed memory
...
Problem: Nasty autocommands can still cause using freed memory.
Solution: Disallow using setloclist() and setqflist() recursively.
2f82ca7d79
2018-09-30 02:06:43 -04:00
Jan Edmund Lazo
cf7e351c24
lint
2018-09-29 22:11:50 -04:00
Jan Edmund Lazo
458a6f58b6
globals: arg_had_last is bool
2018-09-29 16:53:55 -04:00
Jan Edmund Lazo
63b1a7d0cf
vim-patch:8.0.1485: weird autocmd may cause arglist to be changed recursively
...
Problem: Weird autocmd may cause arglist to be changed recursively.
Solution: Prevent recursively changing the argument list. (Christian
Brabandt, closes vim/vim#2472 )
9e33efd152
2018-09-29 16:45:51 -04:00
Justin M. Keyes
6e146d4132
test: check_cores(): Fix tmp dir exclusion ( #9061 )
...
tmpdir_get() may be an absolute path, but we invoke glob() with
a relative `initial_path`.
That can lead to this error:
[ ERROR ] test/functional/helpers.lua @ 752: after_each
test/helpers.lua:95: cannot open ./Xtest-tmpdir/nvim8jKCjR: No such file or directory
stack traceback:
test/helpers.lua:95: in function 'glob'
test/helpers.lua:273: in function 'check_cores'
test/functional/helpers.lua:757: in function <test/functional/helpers.lua:752>
2018-09-28 08:58:22 +02:00
Jan Edmund Lazo
b09f173d93
vim-patch:8.1.0416: sort doesn't report deleted lines ( #9062 )
...
Problem: Sort doesn't report deleted lines.
Solution: Call msgmore(). (Christian Brabandt, closes vim/vim#3454 )
b0e982bf05
2018-09-28 08:56:54 +02:00
Björn Linse
64a8a8fd22
Merge pull request #9056 from bfredl/tui_repr
...
TUI code simplification and dead code elimination
2018-09-27 12:59:31 +02:00
Justin M. Keyes
33887206b9
Merge #9060 from janlazo/vim-8.1.0120
2018-09-27 10:47:37 +02:00
Justin M. Keyes
ba17bcfefc
vim-patch:8.1.0435: cursorline highlight not removed in some situation ( #9059 )
...
Problem: Cursorline highlight not removed in some situation. (Vitaly
Yashin)
Solution: Reset last_cursorline when resetting 'cursorline'. (Christian
Brabandt, closes vim/vim#3481 )
8c63e0ec31
2018-09-27 10:33:39 +02:00
Justin M. Keyes
a1976c7390
man.vim: Start at the top #9023
...
fixes #9057
2018-09-27 10:08:31 +02:00
Jan Edmund Lazo
96a34daab7
lint
2018-09-27 03:17:36 -04:00
Björn Linse
edb26f2c65
tui: eliminate scrolling region data structure
...
The scrolling region is always local to a single grid_scroll event, use
local variables and parameters instead.
The invocation of reset_scroll_region in grid_resize is cargo-culted to use
margin reset under exactly the same circumstances, not sure if it is necessary
though.
2018-09-27 08:50:48 +02:00
Jan Edmund Lazo
25e6d37705
vim-patch:8.1.0120: buffer 'modified' set even when :sort has no changes
...
Problem: Buffer 'modified' set even when :sort has no changes.
Solution: Only set 'modified' when lines are moved. (Jason Franklin)
dc9e955fb0
2018-09-26 21:32:45 -04:00
Björn Linse
1b8939d233
tui: eliminate grid->attrs, use indexed cell->attr
...
remove dead ugrid_put
2018-09-26 19:30:21 +02:00
Justin M. Keyes
fc18fad74f
Merge #9053 from janlazo/vim-8.1.0433
2018-09-26 08:13:21 +02:00
Jan Edmund Lazo
c6350e4150
vim-patch:8.1.0436: can get the text of inputsecret() with getcmdline()
...
Problem: Can get the text of inputsecret() with getcmdline(). (Tommy Allen)
Solution: Don't return the text.
ee91c33570
2018-09-25 23:13:29 -04:00
Jan Edmund Lazo
28ac4a99f2
vim-patch:8.1.0433: mapping can obtain text from inputsecret()
...
Problem: Mapping can obtain text from inputsecret(). (Tommy Allen)
Solution: Disallow CTRL-R = and CTRL-\ e when using inputsecret().
31cbadf74b
2018-09-25 23:09:51 -04:00