Commit Graph

47 Commits

Author SHA1 Message Date
ZyX
a1f985f60a clint: Check that boolean operator is placed on the next line
I have not found in the style guide words about other operators, so they are not
tested. This adds 128 new errors.
2016-05-01 19:42:42 +03:00
ZyX
4a6328a8eb clint: Add rule for preincrement/predecrement 2016-04-13 03:06:35 +03:00
ZyX
0cb2c39ec4 clint: Add diagnostics for things like char* foo or (char*)
Asterisk should be preceded by a space except the following cases:

1. `foo[*idx_ptr]`
2. `++*foo` (though I would prefer to write this as `++(*foo)`)
3. `(*foo)->bar`, `if (*p)`
4. `char **foo`
5. `/* comment */`
6. `!*p`

Note: `[^ (*/![]` is followed by `+` to make error position easier to find. It
is not needed to find location of the problem.
2016-04-13 03:06:34 +03:00
Björn Linse
e17e5547d7 clint.py: a function name starting with for is not a for statement 2016-02-29 16:07:50 +01:00
Seth Jackson
a7ade5c832 misc: UNIX => Unix #4022
Although UNIX is a registered trademark of The Open Group, it doesn't
really matter whether we refer to these systems as UNIX, Unix, or
Unix-like. So, for consistency, refer to them collectively as Unix.

Related:
http://www.greens.org/about/unix.html
http://www.unixica.com/html/unixunix.html
2016-01-16 18:34:31 -05:00
ZyX
e796632240 clint: Check indentation and alignment inside expressions 2015-12-11 19:08:46 +03:00
ZyX
74c960007f clint: Check for spaces after { and before } 2015-12-09 19:55:34 +03:00
ZyX
4c0ac1ca26 clint: Do not special-case for() semicolons 2015-12-09 18:37:13 +03:00
ZyX
86c0bd14ec clint: Disallow old style comments everywhere, except for macros 2015-12-08 13:54:20 +03:00
ZyX
77836ff01b clint: Make sure that braces are always used for if and other clauses 2015-12-08 13:22:31 +03:00
ZyX
aa6723d16b clint: Add support for errors suppression 2015-08-15 19:09:16 +03:00
Michael Reed
3c2fa1767b cmake: Make make lint less verbose
It unnecessarily complicates spotting linter errors, as they're usually
surrounded by a bunch of lines saying "Done processing ... ".
2015-06-27 15:21:09 -04:00
Michael Reed
ed6611a588 clint.py: don't print --help output to stderr and exit 1
a) It's not an error
b) It requires manual redirection of stderr into stdout ('2>&1') in
   order to be viewed with a pager, which it warrants given how long the
   help message is.

Helped-by: Florian Walch <florian@fwalch.com>
2015-06-27 15:21:09 -04:00
Thiago de Arruda
84891f2802 Change neovim.org references to neovim.io 2015-04-19 17:17:45 -03:00
Thiago de Arruda
2d104f14db clint: Add rules to check for memory functions calls 2015-04-13 08:23:08 -03:00
Eliseo Martínez
94db26edbd Enable -Wconversion: indent.c.
Note: Clint was failing because of recommending not to use long. But
converting to long is the proper refactoring here, in as far as other
longs exist. We could, then, disable clint rule, or remove this file
from checking. We choose the former, as it's being discussed what to do
with longs, but a decision has not been taken. So, it seems most
reasonable to allow longs for now, to enable proper refactorings, and
then, when a decision is taken, refactor all longs to some other thing.
2015-02-18 20:54:13 -05:00
Eliseo Martínez
df3b509c98 Make clint.py pep8-compliant. 2015-02-08 19:47:06 +01:00
Florian Walch
470b87e377 Linting: Recommend os_* instead of POSIX functions. 2015-01-11 17:29:17 +01:00
Will Stamper
5b3b3fd3ed spelling fixes #827 2014-06-12 20:26:35 -04:00
Nicolas Hillegeer
b591447f77 clint: disregard compound literal return
This allows lines like:

return (my_struct_type) {
  .my_int = 5,
  .my_str = ""
};

Thanks to @watk for finding and fixing it!
2014-05-18 06:45:39 -03:00
Eliseo Martínez
5f795225dc Introduce nvim namespace: Fix define guards.
Change define guards from NEOVIM_XXX_H to NVIM_XXX_H:
- Change header files.
- Change clint correct guard name calculation.
2014-05-15 20:46:02 +02:00
Eliseo Martínez
575deff66d Introduce nvim namespace: Fix clint.
- Fix path to clint-checked files.
- Fix mechanism to calculate define guard names.
2014-05-15 20:46:02 +02:00
ZyX
37935130f9 Do not detect macros like VIM_TRUE as boolean values 2014-05-03 08:44:04 -04:00
Eliseo Martínez
557e41b119 Use portable format specifiers: Clint advice & other.
- Modify Clint advice to reflect preference for fixed sized macros.
- Cleanup comment to eliminate referecen to "%ld".
2014-04-23 06:56:34 -03:00
John Schmidt
302998b0c7 Remove dead code in clint.py 2014-04-21 12:19:08 -03:00
Hinidu
39932212d8 Added clint check for TRUE/FALSE 2014-04-07 12:15:28 -03:00
Julian Orth
d1ef25728a More cleanup 2014-03-27 14:03:36 -03:00
Julian Orth
380b8048db remove leftover c++ headers 2014-03-27 14:03:36 -03:00
Julian Orth
5a2168a601 remove some leftover function calls 2014-03-27 14:03:35 -03:00
Julian Orth
323e90ee79 remove cpp headers 2014-03-27 14:03:35 -03:00
Julian Orth
f3a77cfd8c remove cpp file extensions 2014-03-27 14:03:35 -03:00
Julian Orth
2b7cd6ebbc remove CleanseRawStrings 2014-03-27 14:03:35 -03:00
Julian Orth
a8e2cab3ef remove C++ only _NestingState parts 2014-03-27 14:03:35 -03:00
Julian Orth
2aadf0daac clean up CheckForNonStandardConstruct
remove C++ stuff and add C types
2014-03-27 14:03:35 -03:00
Julian Orth
23a41ebf8f remove C++ stuff from CheckSpacingForFunctionCall 2014-03-27 14:03:35 -03:00
Julian Orth
95659707a8 remove C++ stuff from CheckSpacing 2014-03-27 14:03:35 -03:00
Julian Orth
ef23bbe6ee remove CheckSectionSpacing
irrelevant
2014-03-27 14:03:35 -03:00
Julian Orth
cb5f1fa51d remove unused function 2014-03-27 14:03:35 -03:00
Julian Orth
67dbb1afda remove some unused variables 2014-03-27 14:03:35 -03:00
Julian Orth
ccc3375d99 remove C++ only stuff from CheckLanguage
Do we want VLAs?
2014-03-27 14:03:35 -03:00
Julian Orth
4bfb03c630 remove "stream check" from CheckIncludeLine
irrelevant
2014-03-27 14:03:35 -03:00
Julian Orth
b3edf6c065 remove CheckForNonConstReference
irrelevant
2014-03-27 14:03:35 -03:00
Julian Orth
1511901467 remove CheckCStyleCast 2014-03-27 14:03:35 -03:00
Julian Orth
38eaa7ed32 remove CheckForIncludeWhatYouUse
Only checks C++ related headers
2014-03-27 14:03:35 -03:00
Julian Orth
cfa070edc5 remove CheckMakePairUsesDeduction
Irrelevant
2014-03-27 14:03:35 -03:00
Steven Myint
1fb6612dc0 Make script portable across Python versions
Support both Python 2 and 3.
2014-03-07 17:05:43 -03:00
David Z. Chen
6121d9b500 Issue #66 - Add lint tool and uncrustify config. Update contributing documentation on coding style. 2014-03-05 16:50:27 -03:00