From f8eae29d396b7476baf8e1da9466d9768a7edbfa Mon Sep 17 00:00:00 2001 From: Gregory Anders Date: Sat, 14 Aug 2021 06:53:52 -0600 Subject: [PATCH] build: prioritize statically built libluv in search When libluv is built statically it appends an '_a' suffix to the library name. This affects CMake's ability to find the bundled version of libluv (which is built statically) when there is a dynamic version of the library also built on the system, which does not have the '_a' suffix. Prioritize searching for 'libluv_a' first before falling back to 'libluv'. This will ensure the bundled version of libluv is always found first before any system versions of libluv. In cases where we are not using bundled libraries, CMake will still safely fall through to finding 'libluv' since package managers do not typically provide static system libraries. --- cmake/FindLibLUV.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/FindLibLUV.cmake b/cmake/FindLibLUV.cmake index af25c2ddaa..23b62b66d3 100644 --- a/cmake/FindLibLUV.cmake +++ b/cmake/FindLibLUV.cmake @@ -15,7 +15,7 @@ find_path(LIBLUV_INCLUDE_DIR luv/luv.h PATHS ${PC_LIBLUV_INCLUDEDIR} ${PC_LIBLUV_INCLUDE_DIRS}) # Explicitly look for luv.so. #10407 -list(APPEND LIBLUV_NAMES luv luv_a libluv_a luv${CMAKE_SHARED_LIBRARY_SUFFIX}) +list(APPEND LIBLUV_NAMES luv_a luv libluv_a luv${CMAKE_SHARED_LIBRARY_SUFFIX}) find_library(LIBLUV_LIBRARY NAMES ${LIBLUV_NAMES} HINTS ${PC_LIBLUV_LIBDIR} ${PC_LIBLUV_LIBRARY_DIRS})