kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-20 11:15:14 -07:00
Code Issues Packages Projects Releases Wiki Activity

lsp: Fix parameter markdown rendering for signature help (#12832)

Browse Source
This commit is contained in:
Xuyuan Pang 2020-09-13 00:33:31 +08:00 committed by GitHub
parent 97c03227c8
commit f3b5531ae8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
runtime/lua/vim/lsp/util.lua
View File

@ -505,13 +505,13 @@ function M.convert_signature_help_to_markdown_lines(signature_help)
if signature.documentation then
M.convert_input_to_markdown_lines(signature.documentation, contents)
end
if signature_help.parameters then
if signature.parameters and #signature.parameters > 0 then
local active_parameter = signature_help.activeParameter or 0
-- If the activeParameter is not inside the valid range, then clip it.
if active_parameter >= #signature_help.parameters then
if active_parameter >= #signature.parameters then
active_parameter = 0
end
local parameter = signature.parameters and signature.parameters[active_parameter]
local parameter = signature.parameters[active_parameter + 1]
if parameter then
--[=[
--Represents a parameter of a callable-signature. A parameter can
@ -532,8 +532,8 @@ function M.convert_signature_help_to_markdown_lines(signature_help)
}
--]=]
-- TODO highlight parameter
if parameter.documentation then
M.convert_input_help_to_markdown_lines(parameter.documentation, contents)
if parameter.documentation and parameter.documentation ~= vim.NIL then
M.convert_input_to_markdown_lines(parameter.documentation, contents)
end
end
end