kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-24 13:15:09 -07:00
Code Issues Packages Projects Releases Wiki Activity

tui: setrgbf/setrgbb: emit semicolons for VTE

Browse Source 
Severe memory leak observed on gnome-terminal 3.26.2 VTE 0.50.2 when
colon-delimited RGB sequences are used.

closes #7573
This commit is contained in:
Justin M. Keyes 2017-11-18 12:24:11 +01:00
parent a6de144c3e
commit f19e5d6530
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/nvim/tui/tui.c
View File

@ -1568,10 +1568,9 @@ static void augment_terminfo(TUIData *data, const char *term,
} }
// Dickey ncurses terminfo does not include the setrgbf and setrgbb // Dickey ncurses terminfo does not include the setrgbf and setrgbb
// capabilities, proposed by Rüdiger Sonderfeld on 2013-10-15. So adding // capabilities, proposed by Rüdiger Sonderfeld on 2013-10-15. Adding
// them to terminal types, that do actually have such control sequences but // them here when terminfo lacks them is an augmentation, not a fixup.
// lack the correct definitions in terminfo, is an augmentation, not a // https://gist.github.com/XVilka/8346728
// fixup. See https://gist.github.com/XVilka/8346728 for more about this.
// At this time (2017-07-12) it seems like all terminals that support rgb // At this time (2017-07-12) it seems like all terminals that support rgb
// color codes can use semicolons in the terminal code and be fine. // color codes can use semicolons in the terminal code and be fine.
@ -1581,8 +1580,8 @@ static void augment_terminfo(TUIData *data, const char *term,
// can use colons like ISO 8613-6:1994/ITU T.416:1993 says. // can use colons like ISO 8613-6:1994/ITU T.416:1993 says.
bool has_colon_rgb = !tmux && !screen bool has_colon_rgb = !tmux && !screen
&& ((vte_version >= 3600) // per GNOME bug #685759, #704449 && !vte_version // VTE colon-support has a big memory leak. #7573
|| iterm || iterm_pretending_xterm // per analysis of VT100Terminal.m && (iterm || iterm_pretending_xterm // per VT100Terminal.m
// per http://invisible-island.net/xterm/xterm.log.html#xterm_282 // per http://invisible-island.net/xterm/xterm.log.html#xterm_282
|| true_xterm); || true_xterm);