kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-21 03:35:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.0.1078: using freed memory with ":hi Normal"

Browse Source 
Problem:    Using freed memory with ":hi Normal".
Solution:   Get "item" again after updating the table.
b4ea1914b8
This commit is contained in:
Jan Edmund Lazo 2018-07-25 23:36:32 -04:00
parent 6b7b56dabe
commit f0ca2283b0
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/nvim/syntax.c
View File

@ -6500,6 +6500,7 @@ void do_highlight(const char *line, const bool forceit, const bool init)
bool error = false;
int color;
bool is_normal_group = false; // "Normal" group
bool did_highlight_changed = false;
// If no argument, list current highlighting.
if (ends_excmd((uint8_t)(*line))) {
@ -6944,6 +6945,9 @@ void do_highlight(const char *line, const bool forceit, const bool init)
// redraw below will still handle usages of guibg=fg etc.
ui_default_colors_set();
}
item = &HL_TABLE()[idx];
did_highlight_changed = true;
redraw_all_later(NOT_VALID);
} else {
set_hl_attr(idx);
}
@ -6954,7 +6958,8 @@ void do_highlight(const char *line, const bool forceit, const bool init)
// Only call highlight_changed() once, after a sequence of highlight
// commands, and only if an attribute actually changed
if (memcmp(item, &item_before, sizeof(item_before)) != 0) {
if (memcmp(item, &item_before, sizeof(item_before)) != 0
&& !did_highlight_changed) {
redraw_all_later(NOT_VALID);
need_highlight_changed = true;
}