kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-20 11:15:14 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(float): properly find last window of tabpage (#30571)

Browse Source
This commit is contained in:
zeertzjq 2024-09-29 18:38:17 +08:00 committed by GitHub
parent 006323dd70
commit df915f3afc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/winfloat.c
View File

@ -59,7 +59,7 @@ win_T *win_new_float(win_T *wp, bool last, WinConfig fconfig, Error *err)
if (!tp) { if (!tp) {
return NULL; return NULL;
} }
tp_last = tp->tp_lastwin; tp_last = tp == curtab ? lastwin : tp->tp_lastwin;
while (tp_last->w_floating && tp_last->w_prev) { while (tp_last->w_floating && tp_last->w_prev) {
tp_last = tp_last->w_prev; tp_last = tp_last->w_prev;
} }

16
test/functional/ui/float_spec.lua
View File

@ -662,6 +662,22 @@ describe('float window', function()
screen:detach() screen:detach()
end) end)
it('no crash with relative="win" after %bdelete #30569', function()
exec([[
botright vsplit
%bdelete
]])
api.nvim_open_win(0, false, {
relative = 'win',
win = 0,
row = 0,
col = 5,
width = 5,
height = 5,
})
assert_alive()
end)
describe('with only one tabpage,', function() describe('with only one tabpage,', function()
local float_opts = {relative = 'editor', row = 1, col = 1, width = 1, height = 1} local float_opts = {relative = 'editor', row = 1, col = 1, width = 1, height = 1}
local old_buf, old_win local old_buf, old_win