kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-24 05:05:00 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(completion): make sure the buffer name is valid (#25975)

Browse Source 
Problem:
crash from
  set complete+=f
  open a empty buffer
  C-N

Solution:
make sure the buffer name is valid.

regression from ae4ca4edf8
This commit is contained in:
mortezadadgar 2023-11-11 02:11:10 +03:30 committed by GitHub
parent 4e33ef747c
commit d1b2a5cf5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/insexpand.c
View File

@ -3334,7 +3334,7 @@ static bool get_next_completion_match(int type, ins_compl_next_state_T *st, pos_
static void get_next_bufname_token(void) static void get_next_bufname_token(void)
{ {
FOR_ALL_BUFFERS(b) { FOR_ALL_BUFFERS(b) {
if (b->b_p_bl) { if (b->b_p_bl && b->b_sfname != NULL) {
char *start = get_past_head(b->b_sfname); char *start = get_past_head(b->b_sfname);
char *current = start; char *current = start;
char *p = (char *)path_next_component(start); char *p = (char *)path_next_component(start);

2
test/functional/editor/completion_spec.lua
View File

@ -1237,7 +1237,7 @@ describe('completion', function()
bufname = 'C:\\foo\\bar.txt' bufname = 'C:\\foo\\bar.txt'
hidden = 'C:\\fooA\\.hidden' hidden = 'C:\\fooA\\.hidden'
end end
command('set complete+=f | edit '.. bufname ..' | edit '..hidden) command('set complete+=f | edit '..bufname..' | edit '..hidden..' | enew')
feed('i<C-n>') feed('i<C-n>')
screen:expect{grid=[[ screen:expect{grid=[[