kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-23 20:55:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(intro): redrawing intro exposing pseudo-randomness

Browse Source 
problem:  redrawing intro exposes pseudo-randomness
solution: remove pseudo-randomness
This commit is contained in:
bfredl 2024-03-15 22:39:34 +01:00
parent 102a72a21e
commit d1a30221fc
2 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/nvim/version.c
View File

@ -2759,11 +2759,6 @@ void intro_message(bool colon)
blanklines = 0; blanklines = 0;
} }
// Show the sponsor and register message one out of four times, the Uganda
// message two out of four times.
int sponsor = (int)time(NULL);
sponsor = ((sponsor & 2) == 0) - ((sponsor & 4) == 0);
// start displaying the message lines after half of the blank lines // start displaying the message lines after half of the blank lines
int row = blanklines / 2; int row = blanklines / 2;
@ -2781,16 +2776,6 @@ void intro_message(bool colon)
mesg = xmallocz((size_t)mesg_size); mesg = xmallocz((size_t)mesg_size);
snprintf(mesg, (size_t)mesg_size + 1, p, snprintf(mesg, (size_t)mesg_size + 1, p,
STR(NVIM_VERSION_MAJOR), STR(NVIM_VERSION_MINOR)); STR(NVIM_VERSION_MAJOR), STR(NVIM_VERSION_MINOR));
} else if (sponsor != 0) {
if (strstr(p, "children") != NULL) {
p = sponsor < 0
? N_("Sponsor Vim development!")
: N_("Become a registered Vim user!");
} else if (strstr(p, "iccf") != NULL) {
p = sponsor < 0
? N_("type :help sponsor<Enter> for information ")
: N_("type :help register<Enter> for information ");
}
} }
if (mesg == NULL) { if (mesg == NULL) {

12
test/functional/ui/messages_spec.lua
View File

@ -1623,7 +1623,8 @@ describe('ui/ext_messages', function()
{1:~ }| {1:~ }|
{1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}| {1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}|
{1:~ }| {1:~ }|
{MATCH:.*}|*2 {1:~ }Help poor children in Uganda!{1: }|
{1:~ }type :help iccf{5:<Enter>} for information {1: }|
{1:~ }|*5 {1:~ }|*5
]]) ]])
@ -1645,7 +1646,8 @@ describe('ui/ext_messages', function()
{1:~ }| {1:~ }|
{1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}| {1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}|
{1:~ }| {1:~ }|
{MATCH:.*}|*2 {1:~ }Help poor children in Uganda!{1: }|
{1:~ }type :help iccf{5:<Enter>} for information {1: }|
{1:~ }|*5 {1:~ }|*5
]], ]],
showmode = { { '-- INSERT --', 3 } }, showmode = { { '-- INSERT --', 3 } },
@ -1678,7 +1680,8 @@ describe('ui/ext_messages', function()
| |
{MATCH: +}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+ +}| {MATCH: +}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+ +}|
| |
{MATCH:.*}|*2 Help poor children in Uganda! |
type :help iccf{5:<Enter>} for information |
|*5 |*5
]], ]],
messages = { messages = {
@ -1783,7 +1786,8 @@ it('ui/ext_multigrid supports intro screen', function()
{1:~ }| {1:~ }|
{1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}| {1:~{MATCH: +}}type :help news{5:<Enter>} to see changes in v{MATCH:%d+%.%d+}{1:{MATCH: +}}|
{1:~ }| {1:~ }|
{MATCH:.*}|*2 {1:~ }Help poor children in Uganda!{1: }|
{1:~ }type :help iccf{5:<Enter>} for information {1: }|
{1:~ }|*4 {1:~ }|*4
## grid 3 ## grid 3
| |