From c1807411899d3fc8a1ff6451ccb398e009b76337 Mon Sep 17 00:00:00 2001
From: oni-link <knil.ino@gmail.com>
Date: Sat, 14 Jul 2018 20:59:22 +0200
Subject: [PATCH] channel.c: Prevent channel_destroy_early() from freeing
 uninitialized rpc stuff

Without this patch the following commands would crash:
    :call rpcstart('unknown_command')

    :set sh=unknown_command
    :call jobstart('ls',{'rpc':1})
---
 src/nvim/channel.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/nvim/channel.c b/src/nvim/channel.c
index 6ad64bbb85..67306d7e11 100644
--- a/src/nvim/channel.c
+++ b/src/nvim/channel.c
@@ -288,7 +288,6 @@ Channel *channel_job_start(char **argv, CallbackReader on_stdout,
   chan->on_stdout = on_stdout;
   chan->on_stderr = on_stderr;
   chan->on_exit = on_exit;
-  chan->is_rpc = rpc;
 
   if (pty) {
     if (detach) {
@@ -326,7 +325,7 @@ Channel *channel_job_start(char **argv, CallbackReader on_stdout,
     has_out = true;
     has_err = false;
   } else {
-    has_out = chan->is_rpc || callback_reader_set(chan->on_stdout);
+    has_out = rpc || callback_reader_set(chan->on_stdout);
     has_err = callback_reader_set(chan->on_stderr);
   }
   int status = process_spawn(proc, true, has_out, has_err);
@@ -347,7 +346,7 @@ Channel *channel_job_start(char **argv, CallbackReader on_stdout,
     rstream_init(&proc->out, 0);
   }
 
-  if (chan->is_rpc) {
+  if (rpc) {
     // the rpc takes over the in and out streams
     rpc_start(chan);
   } else {