kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-23 20:55:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix/PVS #17863

Browse Source 
* fix(PVS/V002): disable rule completely

V002: "Some diagnostic messages may contain incorrect line number in
this file." This particular check seems unreliable. It says on their
website https://pvs-studio.com/en/docs/warnings/v002/ that this warning
occurs when there are multiline pragmas, but there are none in
extmark.c.

* fix(PVS/V756): ignore "counter is not used inside a nested loop" warning

The nested loop starts with "AutoCmd *ac = ap->cmds" so "ap" is
definitely used.

* fix(PVS/V560): disable "a part of conditional expression is always true"

* fix(PVS/V614): potentially uninitialized variable 'blen' used
This commit is contained in:
dundargoc 2022-04-25 03:51:22 +02:00 committed by GitHub
parent 68d27e156c
commit 933274c438
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/pvscheck.sh
View File

@ -380,7 +380,7 @@ run_analysis() {(
--sourcetree-root . || true --sourcetree-root . || true
rm -rf PVS-studio.{xml,err,tsk,html.d} rm -rf PVS-studio.{xml,err,tsk,html.d}
local plog_args="PVS-studio.log --srcRoot . --excludedCodes V011,V1042,V1051,V1074" local plog_args="PVS-studio.log --srcRoot . --excludedCodes V011,V1042,V1051,V1074,V002"
plog-converter $plog_args --renderTypes xml --output PVS-studio.xml plog-converter $plog_args --renderTypes xml --output PVS-studio.xml
plog-converter $plog_args --renderTypes errorfile --output PVS-studio.err plog-converter $plog_args --renderTypes errorfile --output PVS-studio.err
plog-converter $plog_args --renderTypes tasklist --output PVS-studio.tsk plog-converter $plog_args --renderTypes tasklist --output PVS-studio.tsk

2
src/nvim/autocmd.c
View File

@ -2449,7 +2449,7 @@ bool autocmd_delete_id(int64_t id)
// Note that since multiple AutoCmd objects can have the same ID, we need to do a full scan. // Note that since multiple AutoCmd objects can have the same ID, we need to do a full scan.
FOR_ALL_AUEVENTS(event) { FOR_ALL_AUEVENTS(event) {
FOR_ALL_AUPATS_IN_EVENT(event, ap) { FOR_ALL_AUPATS_IN_EVENT(event, ap) { // -V756
for (AutoCmd *ac = ap->cmds; ac != NULL; ac = ac->next) { for (AutoCmd *ac = ap->cmds; ac != NULL; ac = ac->next) {
if (ac->id == id) { if (ac->id == id) {
aucmd_del(ac); aucmd_del(ac);

2
src/nvim/fileio.c
View File

@ -1118,7 +1118,7 @@ retry:
&& tmpname == NULL && tmpname == NULL
&& (*fenc == 'u' || *fenc == NUL)))) { && (*fenc == 'u' || *fenc == NUL)))) {
char_u *ccname; char_u *ccname;
int blen; int blen = 0;
// no BOM detection in a short file or in binary mode // no BOM detection in a short file or in binary mode
if (size < 2 || curbuf->b_p_bin) { if (size < 2 || curbuf->b_p_bin) {

1
src/nvim/fold.c
View File

@ -2752,6 +2752,7 @@ static void truncate_fold(win_T *const wp, fold_T *fp, linenr_T end)
} }
#define FOLD_END(fp) ((fp)->fd_top + (fp)->fd_len - 1) #define FOLD_END(fp) ((fp)->fd_top + (fp)->fd_len - 1)
// -V:VALID_FOLD:V560
#define VALID_FOLD(fp, gap) \ #define VALID_FOLD(fp, gap) \
((gap)->ga_len > 0 && (fp) < ((fold_T *)(gap)->ga_data + (gap)->ga_len)) ((gap)->ga_len > 0 && (fp) < ((fold_T *)(gap)->ga_data + (gap)->ga_len))
#define FOLD_INDEX(fp, gap) ((size_t)((fp) - ((fold_T *)(gap)->ga_data))) #define FOLD_INDEX(fp, gap) ((size_t)((fp) - ((fold_T *)(gap)->ga_data)))