kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-19 18:55:14 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(test/tui_spec): pass the expected NULL-sentinel to execl()

Browse Source 
Since execl() is a variadic function, it requries a NULL-terminal to
indicate the end of its argument list, c.f. exec(3)

> The first argument, by convention, should point to the filename
> associated with the file being executed.  The list of arguments *must*
> be terminated by a null pointer

This fixes the failure seen on aarch64 and i386, due to garbage data
being considered part of the variadic arguments.
This commit is contained in:
James McCoy 2024-01-05 22:56:34 -05:00
parent 28c183b38c
commit 8861ad83fd
No known key found for this signature in database
GPG Key ID: DFE691AE331BA3DB
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/functional/terminal/tui_spec.lua
View File

@ -24,7 +24,6 @@ local funcs = helpers.funcs
local meths = helpers.meths local meths = helpers.meths
local is_ci = helpers.is_ci local is_ci = helpers.is_ci
local is_os = helpers.is_os local is_os = helpers.is_os
local is_arch = helpers.is_arch
local new_pipename = helpers.new_pipename local new_pipename = helpers.new_pipename
local spawn_argv = helpers.spawn_argv local spawn_argv = helpers.spawn_argv
local set_session = helpers.set_session local set_session = helpers.set_session
@ -1932,9 +1931,6 @@ describe('TUI', function()
end) end)
it('argv[0] can be overridden #23953', function() it('argv[0] can be overridden #23953', function()
if is_arch('aarch64') then
pending('execl does not work on aarch64')
end
if not exec_lua('return pcall(require, "ffi")') then if not exec_lua('return pcall(require, "ffi")') then
pending('missing LuaJIT FFI') pending('missing LuaJIT FFI')
end end
@ -1944,7 +1940,7 @@ describe('TUI', function()
[=[ [=[
local ffi = require('ffi') local ffi = require('ffi')
ffi.cdef([[int execl(const char *, const char *, ...);]]) ffi.cdef([[int execl(const char *, const char *, ...);]])
ffi.C.execl(vim.v.progpath, 'Xargv0nvim', '--clean') ffi.C.execl(vim.v.progpath, 'Xargv0nvim', '--clean', nil)
]=] ]=]
) )
finally(function() finally(function()