From 7c64dc833c858ba03f4a7a4e8d7ab55c8dcbb9c6 Mon Sep 17 00:00:00 2001 From: Yi Ming Date: Sat, 19 Oct 2024 12:32:48 +0800 Subject: [PATCH] feat(lsp): include `end_col` and `end_lnum` in `vim.lsp.buf.symbols_to_items` --- runtime/doc/news.txt | 3 ++- runtime/lua/vim/lsp/util.lua | 22 +++++++++++++++------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/runtime/doc/news.txt b/runtime/doc/news.txt index 71ec84c2f2..eb6e6fb773 100644 --- a/runtime/doc/news.txt +++ b/runtime/doc/news.txt @@ -223,7 +223,8 @@ LSP • Completion side effects (including snippet expansion, execution of commands and application of additional text edits) is now built-in. -• |vim.lsp.util.locations_to_items()| sets `end_col` and `end_lnum` fields. +• |vim.lsp.util.locations_to_items()| and |vim.lsp.util.symbols_to_items()| now + sets `end_col` and `end_lnum` fields. • |vim.lsp.buf.format()| now supports passing a list of ranges via the `range` parameter (this requires support for the `textDocument/rangesFormatting` request). diff --git a/runtime/lua/vim/lsp/util.lua b/runtime/lua/vim/lsp/util.lua index 6bee5bc31f..050c0e42ec 100644 --- a/runtime/lua/vim/lsp/util.lua +++ b/runtime/lua/vim/lsp/util.lua @@ -1779,25 +1779,33 @@ function M.symbols_to_items(symbols, bufnr) bufnr = bufnr or 0 local items = {} --- @type vim.quickfix.entry[] for _, symbol in ipairs(symbols) do - --- @type string?, lsp.Position? - local filename, pos + --- @type string?, lsp.Range? + local filename, range if symbol.location then --- @cast symbol lsp.SymbolInformation filename = vim.uri_to_fname(symbol.location.uri) - pos = symbol.location.range.start + range = symbol.location.range elseif symbol.selectionRange then --- @cast symbol lsp.DocumentSymbol filename = api.nvim_buf_get_name(bufnr) - pos = symbol.selectionRange.start + range = symbol.selectionRange end - if filename and pos then + if filename and range then local kind = protocol.SymbolKind[symbol.kind] or 'Unknown' + + local lnum = range['start'].line + 1 + local col = range['start'].character + 1 + local end_lnum = range['end'].line + 1 + local end_col = range['end'].character + 1 + items[#items + 1] = { filename = filename, - lnum = pos.line + 1, - col = pos.character + 1, + lnum = lnum, + col = col, + end_lnum = end_lnum, + end_col = end_col, kind = kind, text = '[' .. kind .. '] ' .. symbol.name, }