kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-01-01 17:23:36 -07:00
Code Issues Packages Projects Releases Wiki Activity

job: Close the process in a queued event handler

Browse Source 
Since all reads are queued by the event loop, we must also queue the exit event,
or else the process_close function can close the job streams before received
data is processed.
This commit is contained in:
Thiago de Arruda 2015-03-25 08:52:40 -03:00
parent 727f524167
commit 710002c820
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/nvim/os/job.c
View File

@ -406,6 +406,12 @@ static void close_cb(uv_handle_t *handle)
job_decref(handle_get_job(handle)); job_decref(handle_get_job(handle));
} }
static void job_exited(Event event)
{
Job *job = event.data;
process_close(job);
}
static void chld_handler(uv_signal_t *handle, int signum) static void chld_handler(uv_signal_t *handle, int signum)
{ {
int stat = 0; int stat = 0;
@ -433,7 +439,12 @@ static void chld_handler(uv_signal_t *handle, int signum)
} else if (WIFSIGNALED(stat)) { } else if (WIFSIGNALED(stat)) {
job->status = WTERMSIG(stat); job->status = WTERMSIG(stat);
} }
process_close(job); if (exiting) {
// don't enqueue more events when exiting
process_close(job);
} else {
event_push((Event) {.handler = job_exited, .data = job}, false);
}
break; break;
} }
} }