kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-29 14:41:06 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(PVS/V547): "expression is always false"

Browse Source 
Suppress warning in loop.c, the expression can be true if EXITFREE isn't
defined.
This commit is contained in:
Dundar Goc 2022-05-17 13:44:54 +02:00
parent e75ccc3b3a
commit 65f585ce9b
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/event/loop.c
View File

@ -143,7 +143,7 @@ bool loop_close(Loop *loop, bool wait)
while (true) { while (true) {
// Run the loop to tickle close-callbacks (which should then free memory). // Run the loop to tickle close-callbacks (which should then free memory).
// Use UV_RUN_NOWAIT to avoid a hang. #11820 // Use UV_RUN_NOWAIT to avoid a hang. #11820
uv_run(&loop->uv, didstop ? UV_RUN_DEFAULT : UV_RUN_NOWAIT); uv_run(&loop->uv, didstop ? UV_RUN_DEFAULT : UV_RUN_NOWAIT); // -V547
if ((uv_loop_close(&loop->uv) != UV_EBUSY) || !wait) { if ((uv_loop_close(&loop->uv) != UV_EBUSY) || !wait) {
break; break;
} }

13
src/nvim/ex_docmd.c
View File

@ -1683,14 +1683,13 @@ void execute_cmd(exarg_T *eap, CmdParseInfo *cmdinfo)
(eap->argt & EX_BUFUNL) != 0, false, false); (eap->argt & EX_BUFUNL) != 0, false, false);
eap->addr_count = 1; eap->addr_count = 1;
// Shift each argument by 1 // Shift each argument by 1
if (eap->args != NULL) { for (size_t i = 0; i < eap->argc - 1; i++) {
for (size_t i = 0; i < eap->argc - 1; i++) { eap->args[i] = eap->args[i + 1];
eap->args[i] = eap->args[i + 1];
}
// Make the last argument point to the NUL terminator at the end of string
eap->args[eap->argc - 1] = eap->args[eap->argc - 1] + eap->arglens[eap->argc - 1];
eap->argc -= 1;
} }
// Make the last argument point to the NUL terminator at the end of string
eap->args[eap->argc - 1] = eap->args[eap->argc - 1] + eap->arglens[eap->argc - 1];
eap->argc -= 1;
eap->arg = eap->args[0]; eap->arg = eap->args[0];
} }
if (eap->line2 < 0) { // failed if (eap->line2 < 0) { // failed