kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-23 20:55:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui_client): check return value of channel_job_start (#27729)

Browse Source 
Problem: null pointer member access in ui_client_start_server if
channel_job_start returns NULL.

Solution: check for it, return 0 in that case (which is already used to indicate
failure and is handled by main).

Happened on Linux when trying to run Nvim in an old gdbserver instance after having
rebuilt Nvim since. This gave E903 (the nvim binary was deleted, so " (deleted)" appears
as a suffix in the `v:progpath`, making it invalid), then ASAN complains due to the NPD;
instead it now then prints "Failed to start Nvim server!", as expected.
This commit is contained in:
Sean Dewar 2024-03-04 13:15:04 +00:00 committed by GitHub
parent a8131aee9e
commit 633bf61d3b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/ui_client.c
View File

@ -62,6 +62,9 @@ uint64_t ui_client_start_server(int argc, char **argv)
CALLBACK_READER_INIT, on_err, CALLBACK_NONE, CALLBACK_READER_INIT, on_err, CALLBACK_NONE,
false, true, true, false, kChannelStdinPipe, false, true, true, false, kChannelStdinPipe,
NULL, 0, 0, NULL, &exit_status); NULL, 0, 0, NULL, &exit_status);
if (!channel) {
return 0;
}
// If stdin is not a pty, it is forwarded to the client. // If stdin is not a pty, it is forwarded to the client.
// Replace stdin in the TUI process with the tty fd. // Replace stdin in the TUI process with the tty fd.