refactor: move Arena and ArenaMem to memory_defs.h (#26240)

Makefile

@@ -161,7 +161,6 @@ iwyu: build/.ran-cmake
 	|src/nvim/assert.h\
 	|src/nvim/autocmd.h\
 	|src/nvim/autocmd_defs.h\
-	|src/nvim/base64.h\
 	|src/nvim/buffer.h\
 	|src/nvim/buffer_defs.h\
 	|src/nvim/buffer_updates.h\
@@ -174,8 +173,6 @@ iwyu: build/.ran-cmake
 	|src/nvim/cmdhist.h\
 	|src/nvim/context.h\
 	|src/nvim/cursor.h\
-	|src/nvim/cursor_shape.h\
-	|src/nvim/debugger.h\
 	|src/nvim/decoration.h\
 	|src/nvim/decoration_defs.h\
 	|src/nvim/decoration_provider.h\
@@ -188,9 +185,7 @@ iwyu: build/.ran-cmake
 	|src/nvim/eval/buffer.h\
 	|src/nvim/eval/decode.h\
 	|src/nvim/eval/encode.h\
-	|src/nvim/eval/executor.h\
 	|src/nvim/eval/funcs.h\
-	|src/nvim/eval/gc.h\
 	|src/nvim/eval/typval.h\
 	|src/nvim/eval/typval_defs.h\
 	|src/nvim/eval/typval_encode.h\
@@ -208,13 +203,10 @@ iwyu: build/.ran-cmake
 	|src/nvim/event/time.h\
 	|src/nvim/event/wstream.h\
 	|src/nvim/ex_cmds.h\
-	|src/nvim/ex_cmds2.h\
 	|src/nvim/ex_cmds_defs.h\
 	|src/nvim/ex_docmd.h\
-	|src/nvim/ex_eval.h\
 	|src/nvim/ex_eval_defs.h\
 	|src/nvim/ex_getln.h\
-	|src/nvim/ex_session.h\
 	|src/nvim/extmark.h\
 	|src/nvim/extmark_defs.h\
 	|src/nvim/file_search.h\
@@ -227,7 +219,6 @@ iwyu: build/.ran-cmake
 	|src/nvim/grid.h\
 	|src/nvim/grid_defs.h\
 	|src/nvim/hashtab.h\
-	|src/nvim/help.h\
 	|src/nvim/highlight.h\
 	|src/nvim/highlight_defs.h\
 	|src/nvim/highlight_group.h\
@@ -239,13 +230,7 @@ iwyu: build/.ran-cmake
 	|src/nvim/keycodes.h\
 	|src/nvim/linematch.h\
 	|src/nvim/log.h\
-	|src/nvim/lua/base64.h\
 	|src/nvim/lua/executor.h\
-	|src/nvim/lua/secure.h\
-	|src/nvim/lua/spell.h\
-	|src/nvim/lua/stdlib.h\
-	|src/nvim/lua/treesitter.h\
-	|src/nvim/lua/xdiff.h\
 	|src/nvim/macros.h\
 	|src/nvim/main.h\
 	|src/nvim/map.h\
@@ -257,7 +242,6 @@ iwyu: build/.ran-cmake
 	|src/nvim/match.h\
 	|src/nvim/mbyte.h\
 	|src/nvim/mbyte_defs.h\
-	|src/nvim/memfile.h\
 	|src/nvim/memfile_defs.h\
 	|src/nvim/memline.h\
 	|src/nvim/memory.h\
@@ -268,16 +252,12 @@ iwyu: build/.ran-cmake
 	|src/nvim/msgpack_rpc/channel.h\
 	|src/nvim/msgpack_rpc/channel_defs.h\
 	|src/nvim/msgpack_rpc/helpers.h\
-	|src/nvim/msgpack_rpc/server.h\
 	|src/nvim/msgpack_rpc/unpacker.h\
 	|src/nvim/normal.h\
-	|src/nvim/nvim/extmark.h\
 	|src/nvim/ops.h\
 	|src/nvim/option.h\
 	|src/nvim/option_defs.h\
 	|src/nvim/option_vars.h\
-	|src/nvim/optionstr.h\
-	|src/nvim/os/dl.h\
 	|src/nvim/os/fileio.h\
 	|src/nvim/os/fs.h\
 	|src/nvim/os/input.h\
@@ -286,9 +266,6 @@ iwyu: build/.ran-cmake
 	|src/nvim/os/pty_conpty_win.h\
 	|src/nvim/os/pty_process_unix.h\
 	|src/nvim/os/pty_process_win.h\
-	|src/nvim/os/shell.h\
-	|src/nvim/os/time.h\
-	|src/nvim/os/tty.h\
 	|src/nvim/path.h\
 	|src/nvim/plines.h\
 	|src/nvim/popupmenu.h\
@@ -298,20 +275,13 @@ iwyu: build/.ran-cmake
 	|src/nvim/regexp_defs.h\
 	|src/nvim/runtime.h\
 	|src/nvim/search.h\
-	|src/nvim/sha256.h\
-	|src/nvim/shada.h\
 	|src/nvim/sign.h\
-	|src/nvim/sign_defs.h\
 	|src/nvim/spell.h\
 	|src/nvim/spell_defs.h\
-	|src/nvim/spellfile.h\
-	|src/nvim/state.h\
 	|src/nvim/statusline.h\
 	|src/nvim/statusline_defs.h\
 	|src/nvim/strings.h\
 	|src/nvim/syntax.h\
-	|src/nvim/tag.h\
-	|src/nvim/terminal.h\
 	|src/nvim/testing.h\
 	|src/nvim/textformat.h\
 	|src/nvim/textobject.h\

src/clint.py

@@ -916,7 +916,6 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/assert.h",
             "src/nvim/autocmd.h",
             "src/nvim/autocmd_defs.h",
-            "src/nvim/base64.h",
             "src/nvim/buffer.h",
             "src/nvim/buffer_defs.h",
             "src/nvim/buffer_updates.h",
@@ -929,8 +928,6 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/cmdhist.h",
             "src/nvim/context.h",
             "src/nvim/cursor.h",
-            "src/nvim/cursor_shape.h",
-            "src/nvim/debugger.h",
             "src/nvim/decoration.h",
             "src/nvim/decoration_defs.h",
             "src/nvim/decoration_provider.h",
@@ -943,9 +940,7 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/eval/buffer.h",
             "src/nvim/eval/decode.h",
             "src/nvim/eval/encode.h",
-            "src/nvim/eval/executor.h",
             "src/nvim/eval/funcs.h",
-            "src/nvim/eval/gc.h",
             "src/nvim/eval/typval.h",
             "src/nvim/eval/typval_defs.h",
             "src/nvim/eval/typval_encode.h",
@@ -963,13 +958,10 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/event/time.h",
             "src/nvim/event/wstream.h",
             "src/nvim/ex_cmds.h",
-            "src/nvim/ex_cmds2.h",
             "src/nvim/ex_cmds_defs.h",
             "src/nvim/ex_docmd.h",
-            "src/nvim/ex_eval.h",
             "src/nvim/ex_eval_defs.h",
             "src/nvim/ex_getln.h",
-            "src/nvim/ex_session.h",
             "src/nvim/extmark.h",
             "src/nvim/extmark_defs.h",
             "src/nvim/file_search.h",
@@ -982,7 +974,6 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/grid.h",
             "src/nvim/grid_defs.h",
             "src/nvim/hashtab.h",
-            "src/nvim/help.h",
             "src/nvim/highlight.h",
             "src/nvim/highlight_defs.h",
             "src/nvim/highlight_group.h",
@@ -994,13 +985,7 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/keycodes.h",
             "src/nvim/linematch.h",
             "src/nvim/log.h",
-            "src/nvim/lua/base64.h",
             "src/nvim/lua/executor.h",
-            "src/nvim/lua/secure.h",
-            "src/nvim/lua/spell.h",
-            "src/nvim/lua/stdlib.h",
-            "src/nvim/lua/treesitter.h",
-            "src/nvim/lua/xdiff.h",
             "src/nvim/macros.h",
             "src/nvim/main.h",
             "src/nvim/map.h",
@@ -1012,7 +997,6 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/match.h",
             "src/nvim/mbyte.h",
             "src/nvim/mbyte_defs.h",
-            "src/nvim/memfile.h",
             "src/nvim/memfile_defs.h",
             "src/nvim/memline.h",
             "src/nvim/memory.h",
@@ -1023,16 +1007,12 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/msgpack_rpc/channel.h",
             "src/nvim/msgpack_rpc/channel_defs.h",
             "src/nvim/msgpack_rpc/helpers.h",
-            "src/nvim/msgpack_rpc/server.h",
             "src/nvim/msgpack_rpc/unpacker.h",
             "src/nvim/normal.h",
-            "src/nvim/nvim/extmark.h",
             "src/nvim/ops.h",
             "src/nvim/option.h",
             "src/nvim/option_defs.h",
             "src/nvim/option_vars.h",
-            "src/nvim/optionstr.h",
-            "src/nvim/os/dl.h",
             "src/nvim/os/fileio.h",
             "src/nvim/os/fs.h",
             "src/nvim/os/input.h",
@@ -1041,9 +1021,6 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/os/pty_conpty_win.h",
             "src/nvim/os/pty_process_unix.h",
             "src/nvim/os/pty_process_win.h",
-            "src/nvim/os/shell.h",
-            "src/nvim/os/time.h",
-            "src/nvim/os/tty.h",
             "src/nvim/path.h",
             "src/nvim/plines.h",
             "src/nvim/popupmenu.h",
@@ -1053,20 +1030,13 @@ def CheckIncludes(filename, lines, error):
             "src/nvim/regexp_defs.h",
             "src/nvim/runtime.h",
             "src/nvim/search.h",
-            "src/nvim/sha256.h",
-            "src/nvim/shada.h",
             "src/nvim/sign.h",
-            "src/nvim/sign_defs.h",
             "src/nvim/spell.h",
             "src/nvim/spell_defs.h",
-            "src/nvim/spellfile.h",
-            "src/nvim/state.h",
             "src/nvim/statusline.h",
             "src/nvim/statusline_defs.h",
             "src/nvim/strings.h",
             "src/nvim/syntax.h",
-            "src/nvim/tag.h",
-            "src/nvim/terminal.h",
             "src/nvim/testing.h",
             "src/nvim/textformat.h",
             "src/nvim/textobject.h",

src/nvim/api/autocmd.c

@@ -1,4 +1,5 @@
 #include <assert.h>
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdio.h>
@@ -6,7 +7,6 @@
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/autocmd.h"
 #include "nvim/api/keysets.h"
 #include "nvim/api/private/defs.h"

src/nvim/api/autocmd.h

@@ -1,9 +1,9 @@
 #pragma once
 
-#include <stdint.h>
+#include <stdint.h>  // IWYU pragma: keep
 
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/autocmd.h.generated.h"

src/nvim/api/buffer.h

@@ -1,9 +1,10 @@
 #pragma once
 
-#include <lauxlib.h>
+#include <lua.h>  // IWYU pragma: keep
+#include <stdint.h>  // IWYU pragma: keep
 
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 #include "nvim/buffer_defs.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS

src/nvim/api/command.c

@@ -1,10 +1,10 @@
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/command.h"
 #include "nvim/api/keysets.h"
 #include "nvim/api/private/defs.h"
@@ -15,7 +15,6 @@
 #include "nvim/autocmd.h"
 #include "nvim/buffer_defs.h"
 #include "nvim/cmdexpand_defs.h"
-#include "nvim/decoration.h"
 #include "nvim/ex_cmds.h"
 #include "nvim/ex_docmd.h"
 #include "nvim/ex_eval.h"

src/nvim/api/command.h

@@ -1,9 +1,9 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
-#include "nvim/decoration.h"
-#include "nvim/ex_cmds.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/command.h.generated.h"

src/nvim/api/extmark.c

@@ -1,10 +1,10 @@
 #include <assert.h>
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stdint.h>
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/extmark.h"
 #include "nvim/api/keysets.h"
 #include "nvim/api/private/defs.h"

src/nvim/api/extmark.h

@@ -1,8 +1,10 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
-#include "nvim/decoration.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
+#include "nvim/decoration_defs.h"  // IWYU pragma: keep
 #include "nvim/macros.h"
 #include "nvim/map.h"
 #include "nvim/types.h"

src/nvim/api/options.c

@@ -1,5 +1,4 @@
 #include <assert.h>
-#include <inttypes.h>
 #include <stdbool.h>
 #include <string.h>
 

src/nvim/api/options.h

@@ -1,8 +1,10 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
-#include "nvim/option.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
+#include "nvim/option_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/options.h.generated.h"

src/nvim/api/ui.h

@@ -1,8 +1,10 @@
 #pragma once
 
-#include <stdint.h>
+#include <stdint.h>  // IWYU pragma: keep
 
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
+#include "nvim/grid_defs.h"  // IWYU pragma: keep
+#include "nvim/highlight_defs.h"  // IWYU pragma: keep
 #include "nvim/map.h"
 #include "nvim/ui.h"
 

src/nvim/api/vim.c

@@ -1,5 +1,6 @@
 #include <assert.h>
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <limits.h>
 #include <stdbool.h>
 #include <stddef.h>
@@ -8,7 +9,6 @@
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/buffer.h"
 #include "nvim/api/deprecated.h"
 #include "nvim/api/keysets.h"

src/nvim/api/vim.h

@@ -1,7 +1,9 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/vim.h.generated.h"

src/nvim/api/vimscript.h

@@ -1,7 +1,9 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/vimscript.h.generated.h"

src/nvim/api/win_config.c

@@ -255,8 +255,8 @@ void nvim_win_set_config(Window window, Dict(float_config) *config, Error *err)
   }
 }
 
-Dictionary config_put_bordertext(Dictionary config, FloatConfig *fconfig,
-                                 BorderTextType bordertext_type)
+static Dictionary config_put_bordertext(Dictionary config, FloatConfig *fconfig,
+                                        BorderTextType bordertext_type)
 {
   VirtText vt;
   AlignTextPos align;

src/nvim/api/win_config.h

@@ -1,8 +1,9 @@
 #pragma once
 
+#include <stdint.h>  // IWYU pragma: keep
+
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
-#include "nvim/buffer_defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/win_config.h.generated.h"

src/nvim/api/window.h

@@ -1,7 +1,7 @@
 #pragma once
 
 #include "nvim/api/keysets.h"
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "api/window.h.generated.h"

src/nvim/base64.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <stddef.h>
+#include <stddef.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "base64.h.generated.h"

src/nvim/buffer_updates.c

@@ -1,9 +1,9 @@
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stddef.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/buffer.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/helpers.h"

src/nvim/buffer_updates.h

@@ -1,7 +1,10 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
+#include <stdint.h>  // IWYU pragma: keep
+
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
 #include "nvim/extmark.h"
+#include "nvim/pos.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "buffer_updates.h.generated.h"

src/nvim/bufwrite.h

@@ -1,7 +1,8 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "bufwrite.h.generated.h"

src/nvim/change.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
 #include "nvim/pos.h"
 
 // flags for open_line()

src/nvim/channel.c

@@ -1,11 +1,11 @@
 #include <assert.h>
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <stddef.h>
 #include <stdio.h>
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/private/converter.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/helpers.h"

src/nvim/cmdhist.h

@@ -1,9 +1,10 @@
 #pragma once
 
-#include "nvim/cmdexpand_defs.h"
+#include "nvim/cmdexpand_defs.h"  // IWYU pragma: export
 #include "nvim/eval/typval_defs.h"
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: export
 #include "nvim/os/time.h"
+#include "nvim/types.h"
 
 /// Present history tables
 typedef enum {

src/nvim/cursor.h

@@ -1,8 +1,7 @@
 #pragma once
 
-#include <stdbool.h>
-
-#include "nvim/vim.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "cursor.h.generated.h"

src/nvim/cursor_shape.c

@@ -13,7 +13,6 @@
 #include "nvim/highlight_group.h"
 #include "nvim/log.h"
 #include "nvim/macros.h"
-#include "nvim/memory.h"
 #include "nvim/option_vars.h"
 #include "nvim/strings.h"
 #include "nvim/ui.h"

src/nvim/cursor_shape.h

@@ -1,7 +1,7 @@
 #pragma once
 
-#include "nvim/api/private/defs.h"
-#include "nvim/types.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
+#include "nvim/memory_defs.h"  // IWYU pragma: keep
 
 /// struct to store values from 'guicursor' and 'mouseshape'
 /// Indexes in shape_table[]

src/nvim/debugger.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <stdbool.h>
-
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "debugger.h.generated.h"

src/nvim/decoration_provider.c

@@ -1,8 +1,8 @@
 #include <assert.h>
+#include <lauxlib.h>
 #include <string.h>
 
 #include "klib/kvec.h"
-#include "lauxlib.h"
 #include "nvim/api/extmark.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/helpers.h"

src/nvim/digraph.h

@@ -1,6 +1,9 @@
 #pragma once
 
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/garray_defs.h"  // IWYU pragma: keep
 #include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS

src/nvim/edit.h

@@ -1,7 +1,8 @@
 #pragma once
 
-#include "nvim/autocmd_defs.h"
-#include "nvim/vim.h"
+#include "nvim/autocmd_defs.h"  // IWYU pragma: keep
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 
 // Values for in_cinkeys()
 #define KEY_OPEN_FORW   0x101

src/nvim/eval.h

@@ -10,6 +10,7 @@
 #include "nvim/eval/typval_defs.h"
 #include "nvim/event/time.h"
 #include "nvim/ex_cmds_defs.h"
+#include "nvim/globals.h"
 #include "nvim/hashtab.h"
 #include "nvim/macros.h"
 #include "nvim/os/fileio.h"

src/nvim/eval/buffer.h

@@ -1,7 +1,8 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
-#include "nvim/eval/typval_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "eval/buffer.h.generated.h"

src/nvim/eval/decode.h

@@ -1,9 +1,9 @@
 #pragma once
 
-#include <msgpack.h>
-#include <stddef.h>
+#include <msgpack.h>  // IWYU pragma: keep
+#include <stddef.h>  // IWYU pragma: keep
 
-#include "nvim/eval/typval_defs.h"
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
 #include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS

src/nvim/eval/executor.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "nvim/eval/typval_defs.h"
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
 
 extern char *e_list_index_out_of_range_nr;
 

src/nvim/eval/gc.h

@@ -6,5 +6,5 @@ extern dict_T *gc_first_dict;
 extern list_T *gc_first_list;
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
-# include "eval/gc.h.generated.h"
+# include "eval/gc.h.generated.h"  // IWYU pragma: export
 #endif

src/nvim/eval/typval.c

@@ -1,11 +1,11 @@
 #include <assert.h>
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-#include "lauxlib.h"
 #include "nvim/ascii.h"
 #include "nvim/assert.h"
 #include "nvim/charset.h"

src/nvim/eval/userfunc.c

@@ -3,11 +3,11 @@
 #include <assert.h>
 #include <ctype.h>
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-#include "lauxlib.h"
 #include "nvim/ascii.h"
 #include "nvim/autocmd.h"
 #include "nvim/charset.h"

src/nvim/eval/vars.h

@@ -1,7 +1,12 @@
 #pragma once
 
-#include "nvim/ex_cmds_defs.h"
-#include "nvim/option_defs.h"
+#include <stddef.h>  // IWYU pragma: keep
+
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/garray_defs.h"  // IWYU pragma: keep
+#include "nvim/hashtab.h"
+#include "nvim/option_defs.h"  // IWYU pragma: keep
+#include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "eval/vars.h.generated.h"

src/nvim/ex_cmds.c

@@ -25,7 +25,6 @@
 #include "nvim/change.h"
 #include "nvim/channel.h"
 #include "nvim/charset.h"
-#include "nvim/cmdexpand_defs.h"
 #include "nvim/cmdhist.h"
 #include "nvim/cursor.h"
 #include "nvim/decoration.h"

src/nvim/ex_cmds.h

@@ -2,7 +2,7 @@
 
 #include <stdbool.h>
 
-#include "nvim/buffer_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
 #include "nvim/eval/typval_defs.h"
 #include "nvim/ex_cmds_defs.h"  // IWYU pragma: export
 #include "nvim/os/time.h"

src/nvim/ex_cmds2.h

@@ -1,15 +1,16 @@
 #pragma once
 
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 
-//
-// flags for check_changed()
-//
-#define CCGD_AW         1       // do autowrite if buffer was changed
-#define CCGD_MULTWIN    2       // check also when several wins for the buf
-#define CCGD_FORCEIT    4       // ! used
-#define CCGD_ALLBUF     8       // may write all buffers
-#define CCGD_EXCMD      16      // may suggest using !
+/// flags for check_changed()
+enum {
+  CCGD_AW      = 1,   ///< do autowrite if buffer was changed
+  CCGD_MULTWIN = 2,   ///< check also when several wins for the buf
+  CCGD_FORCEIT = 4,   ///< ! used
+  CCGD_ALLBUF  = 8,   ///< may write all buffers
+  CCGD_EXCMD   = 16,  ///< may suggest using !
+};
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "ex_cmds2.h.generated.h"

src/nvim/ex_session.h

@@ -1,8 +1,8 @@
 #pragma once
 
-#include <stdio.h>
+#include <stdio.h>  // IWYU pragma: keep
 
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "ex_session.h.generated.h"

src/nvim/getchar.c

@@ -2,6 +2,7 @@
 // file, manipulations with redo buffer and stuff buffer.
 
 #include <assert.h>
+#include <lauxlib.h>
 #include <limits.h>
 #include <stdbool.h>
 #include <stddef.h>
@@ -10,7 +11,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include "lauxlib.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/helpers.h"
 #include "nvim/ascii.h"

src/nvim/grid.h

@@ -1,14 +1,13 @@
 #pragma once
 
 #include <stdbool.h>
+#include <stddef.h>  // IWYU pragma: keep
 #include <string.h>
 
-#include "nvim/ascii.h"
 #include "nvim/buffer_defs.h"
 #include "nvim/grid_defs.h"  // IWYU pragma: export
 #include "nvim/macros.h"
 #include "nvim/mbyte.h"
-#include "nvim/memory.h"
 #include "nvim/pos.h"
 
 /// By default, all windows are drawn on a single rectangular grid, represented by

src/nvim/help.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <stdbool.h>
-
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "help.h.generated.h"

src/nvim/highlight.c

@@ -2,9 +2,9 @@
 
 #include <assert.h>
 #include <inttypes.h>
+#include <lauxlib.h>
 #include <string.h>
 
-#include "lauxlib.h"
 #include "nvim/api/keysets.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/dispatch.h"

src/nvim/highlight_group.h

@@ -1,8 +1,9 @@
 #pragma once
 
 #include "nvim/api/keysets.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 #include "nvim/api/private/helpers.h"
-#include "nvim/cmdexpand_defs.h"
+#include "nvim/cmdexpand_defs.h"  // IWYU pragma: keep
 #include "nvim/highlight_defs.h"
 #include "nvim/types.h"
 

src/nvim/iconv.h

@@ -3,8 +3,6 @@
 #include <errno.h>
 #include <iconv.h>
 
-#include "auto/config.h"
-
 // define some missing constants if necessary
 #ifndef EILSEQ
 # define EILSEQ 123

src/nvim/indent.h

@@ -1,6 +1,9 @@
 #pragma once
 
-#include "nvim/vim.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
+#include "nvim/types.h"
 
 typedef int (*IndentGetter)(void);
 

src/nvim/indent_c.h

@@ -1,6 +1,7 @@
 #pragma once
 
-#include "nvim/vim.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "indent_c.h.generated.h"

src/nvim/input.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "nvim/vim.h"
+#include "nvim/event/multiqueue.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "input.h.generated.h"

src/nvim/insexpand.h

@@ -1,9 +1,9 @@
 #pragma once
 
-#include <stdbool.h>
-
 #include "nvim/macros.h"
-#include "nvim/option_defs.h"
+#include "nvim/option_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
+#include "nvim/types.h"
 #include "nvim/vim.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS

src/nvim/linematch.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <stddef.h>
+#include <stddef.h>  // IWYU pragma: keep
 
 #include "nvim/pos.h"
 

src/nvim/lua/base64.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <lauxlib.h>
-#include <lua.h>
-#include <lualib.h>
+#include <lua.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/base64.h.generated.h"

src/nvim/lua/secure.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <lua.h>
-
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/secure.h.generated.h"

src/nvim/lua/spell.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <lauxlib.h>
-#include <lua.h>
-#include <lualib.h>
+#include <lua.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/spell.h.generated.h"

src/nvim/lua/stdlib.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <lua.h>
+#include <lua.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/stdlib.h.generated.h"

src/nvim/lua/treesitter.c

@@ -12,6 +12,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <tree_sitter/api.h>
 #include <uv.h>
 
 #include "klib/kvec.h"
@@ -26,7 +27,6 @@
 #include "nvim/pos.h"
 #include "nvim/strings.h"
 #include "nvim/types.h"
-#include "tree_sitter/api.h"
 
 #define TS_META_PARSER "treesitter_parser"
 #define TS_META_TREE "treesitter_tree"

src/nvim/lua/treesitter.h

@@ -1,10 +1,6 @@
 #pragma once
 
-#include <lauxlib.h>
-#include <lua.h>
-#include <lualib.h>
-
-#include "tree_sitter/api.h"
+#include <lua.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/treesitter.h.generated.h"

src/nvim/lua/xdiff.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <lauxlib.h>
-#include <lua.h>
-#include <lualib.h>
+#include <lua.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "lua/xdiff.h.generated.h"

src/nvim/match.h

@@ -1,7 +1,9 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "match.h.generated.h"

src/nvim/memfile.h

@@ -4,10 +4,12 @@
 #include "nvim/memfile_defs.h"  // IWYU pragma: export
 
 /// flags for mf_sync()
-#define MFS_ALL         1       /// also sync blocks with negative numbers
-#define MFS_STOP        2       /// stop syncing when a character is available
-#define MFS_FLUSH       4       /// flushed file to disk
-#define MFS_ZERO        8       /// only write block 0
+enum {
+  MFS_ALL   = 1,  ///< also sync blocks with negative numbers
+  MFS_STOP  = 2,  ///< stop syncing when a character is available
+  MFS_FLUSH = 4,  ///< flushed file to disk
+  MFS_ZERO  = 8,  ///< only write block 0
+};
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "memfile.h.generated.h"

src/nvim/memory.c

@@ -577,7 +577,9 @@ void alloc_block(Arena *arena)
 
 static size_t arena_align_offset(uint64_t off)
 {
+#define ARENA_ALIGN MAX(sizeof(void *), sizeof(double))
   return ((off + (ARENA_ALIGN - 1)) & ~(ARENA_ALIGN - 1));
+#undef ARENA_ALIGN
 }
 
 /// @param arena if NULL, do a global allocation. caller must then free the value!

src/nvim/memory.h

@@ -6,6 +6,7 @@
 #include <time.h>
 
 #include "nvim/macros.h"
+#include "nvim/memory_defs.h"  // IWYU pragma: export
 
 /// `malloc()` function signature
 typedef void *(*MemMalloc)(size_t);
@@ -40,20 +41,6 @@ extern bool entered_free_all_mem;
 
 EXTERN size_t arena_alloc_count INIT( = 0);
 
-typedef struct consumed_blk {
-  struct consumed_blk *prev;
-} *ArenaMem;
-
-#define ARENA_ALIGN MAX(sizeof(void *), sizeof(double))
-
-typedef struct {
-  char *cur_blk;
-  size_t pos, size;
-} Arena;
-
-// inits an empty arena.
-#define ARENA_EMPTY { .cur_blk = NULL, .pos = 0, .size = 0 }
-
 #define kv_fixsize_arena(a, v, s) \
   ((v).capacity = (s), \
    (v).items = (void *)arena_alloc(a, sizeof((v).items[0]) * (v).capacity, true))

src/nvim/memory_defs.h

@@ -0,0 +1,15 @@
+#pragma once
+
+#include <stddef.h>
+
+typedef struct consumed_blk {
+  struct consumed_blk *prev;
+} *ArenaMem;
+
+typedef struct {
+  char *cur_blk;
+  size_t pos, size;
+} Arena;
+
+// inits an empty arena.
+#define ARENA_EMPTY { .cur_blk = NULL, .pos = 0, .size = 0 }

src/nvim/move.h

@@ -2,6 +2,9 @@
 
 #include <stdbool.h>
 
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/types.h"
 #include "nvim/vim.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS

src/nvim/msgpack_rpc/channel.h

@@ -1,16 +1,16 @@
 #pragma once
 
-#include <stdbool.h>
-#include <uv.h>
+#include <stdint.h>  // IWYU pragma: keep
 
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 #include "nvim/channel.h"
 #include "nvim/event/multiqueue.h"
 #include "nvim/event/process.h"
 #include "nvim/event/socket.h"
+#include "nvim/event/wstream.h"
 #include "nvim/macros.h"
+#include "nvim/memory_defs.h"  // IWYU pragma: keep
 #include "nvim/msgpack_rpc/channel_defs.h"  // IWYU pragma: export
-#include "nvim/vim.h"
 
 #define METHOD_MAXLEN 512
 

src/nvim/msgpack_rpc/channel_defs.h

@@ -4,10 +4,12 @@
 #include <stdbool.h>
 #include <uv.h>
 
+#include "klib/kvec.h"
 #include "nvim/api/private/defs.h"
 #include "nvim/api/private/dispatch.h"
 #include "nvim/event/process.h"
 #include "nvim/event/socket.h"
+#include "nvim/map.h"
 #include "nvim/vim.h"
 
 typedef struct Channel Channel;

src/nvim/msgpack_rpc/server.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <stdio.h>
+#include <stddef.h>  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "msgpack_rpc/server.h.generated.h"

src/nvim/msgpack_rpc/unpacker.h

@@ -10,7 +10,7 @@
 #include "nvim/api/private/dispatch.h"
 #include "nvim/api/private/helpers.h"
 #include "nvim/grid_defs.h"
-#include "nvim/memory.h"
+#include "nvim/memory_defs.h"
 #include "nvim/msgpack_rpc/channel_defs.h"
 #include "nvim/types.h"
 #include "nvim/ui_client.h"

src/nvim/ops.h

@@ -1,9 +1,9 @@
 #pragma once
 
+#include <lauxlib.h>
 #include <stdbool.h>
 #include <stddef.h>
 
-#include "lauxlib.h"
 #include "nvim/ascii.h"
 #include "nvim/eval/typval_defs.h"
 #include "nvim/ex_cmds_defs.h"

src/nvim/option.h

@@ -2,12 +2,14 @@
 
 #include <stdint.h>
 
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 #include "nvim/api/private/helpers.h"
 #include "nvim/cmdexpand_defs.h"  // IWYU pragma: keep
 #include "nvim/eval/typval_defs.h"
 #include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 #include "nvim/option_defs.h"  // IWYU pragma: export
 #include "nvim/search.h"
+#include "nvim/types.h"
 
 /// The options that are local to a window or buffer have "indir" set to one of
 /// these values.  Special values:
@@ -94,13 +96,6 @@ enum {
   SOPT_BUF    = 0x20,  ///< Option has buffer-local value
 };
 
-/// Requested option scopes for various functions in option.c
-typedef enum {
-  kOptReqGlobal = 0,  ///< Request global option value
-  kOptReqWin    = 1,  ///< Request window-local option value
-  kOptReqBuf    = 2,  ///< Request buffer-local option value
-} OptReqScope;
-
 // OptVal helper macros.
 #define NIL_OPTVAL ((OptVal) { .type = kOptValTypeNil })
 #define BOOLEAN_OPTVAL(b) ((OptVal) { .type = kOptValTypeBoolean, .data.boolean = b })

src/nvim/option_defs.h

@@ -114,3 +114,10 @@ typedef struct {
 /// Note: If returned FAIL or *numMatches is 0, *matches will NOT be freed by
 /// caller.
 typedef int (*opt_expand_cb_T)(optexpand_T *args, int *numMatches, char ***matches);
+
+/// Requested option scopes for various functions in option.c
+typedef enum {
+  kOptReqGlobal = 0,  ///< Request global option value
+  kOptReqWin    = 1,  ///< Request window-local option value
+  kOptReqBuf    = 2,  ///< Request buffer-local option value
+} OptReqScope;

src/nvim/optionstr.h

@@ -1,8 +1,10 @@
 #pragma once
 
-#include "nvim/buffer_defs.h"
-#include "nvim/cmdexpand_defs.h"
-#include "nvim/option_defs.h"
+#include <stdint.h>  // IWYU pragma: keep
+
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/cmdexpand_defs.h"  // IWYU pragma: keep
+#include "nvim/option_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "optionstr.h.generated.h"

src/nvim/os/dl.h

@@ -1,8 +1,5 @@
 #pragma once
 
-#include <stdbool.h>
-#include <stdint.h>
-
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "os/dl.h.generated.h"
 #endif

src/nvim/os/fs.h

@@ -1,5 +1,10 @@
 #pragma once
 
+#include <stddef.h>  // IWYU pragma: keep
+#include <stdint.h>  // IWYU pragma: keep
+#include <stdio.h>  // IWYU pragma: keep
+#include <uv.h>  // IWYU pragma: keep
+
 #include "nvim/os/fs_defs.h"  // IWYU pragma: export
 #include "nvim/types.h"
 

src/nvim/os/input.h

@@ -1,9 +1,9 @@
 #pragma once
 
 #include <stdbool.h>
-#include <stdint.h>
+#include <stdint.h>  // IWYU pragma: keep
 
-#include "nvim/api/private/defs.h"
+#include "nvim/api/private/defs.h"  // IWYU pragma: keep
 #include "nvim/event/multiqueue.h"
 #include "nvim/macros.h"
 

src/nvim/os/shell.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <stdio.h>
-
-#include "nvim/types.h"
+#include <stddef.h>  // IWYU pragma: keep
 
 // Flags for os_call_shell() second argument
 typedef enum {

src/nvim/os/time.h

@@ -1,8 +1,8 @@
 #pragma once
 
-#include <stdbool.h>
+#include <stddef.h>  // IWYU pragma: keep
 #include <stdint.h>
-#include <time.h>
+#include <time.h>  // IWYU pragma: keep
 
 typedef uint64_t Timestamp;
 

src/nvim/os/tty.h

@@ -1,5 +1,5 @@
 #pragma once
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
-# include "os/tty.h.generated.h"
+# include "os/tty.h.generated.h"  // IWYU pragma: export
 #endif

src/nvim/path.h

@@ -1,7 +1,9 @@
 #pragma once
 
+#include <stddef.h>  // IWYU pragma: keep
+
 #include "nvim/func_attr.h"
-#include "nvim/garray_defs.h"
+#include "nvim/garray_defs.h"  // IWYU pragma: keep
 #include "nvim/types.h"
 
 // Flags for expand_wildcards()

src/nvim/popupmenu.h

@@ -2,10 +2,10 @@
 
 #include <stdbool.h>
 
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
 #include "nvim/grid_defs.h"
 #include "nvim/macros.h"
-#include "nvim/types.h"
-#include "nvim/vim.h"
+#include "nvim/menu_defs.h"  // IWYU pragma: keep
 
 /// Used for popup menu items.
 typedef struct {

src/nvim/profile.h

@@ -1,10 +1,10 @@
 #pragma once
 
-#include <stdint.h>
+#include <stdint.h>  // IWYU pragma: keep
 #include <time.h>
 
-#include "nvim/cmdexpand_defs.h"
-#include "nvim/ex_cmds_defs.h"
+#include "nvim/cmdexpand_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 #include "nvim/runtime.h"
 
 #define TIME_MSG(s) do { \

src/nvim/quickfix.h

@@ -1,7 +1,9 @@
 #pragma once
 
-#include "nvim/ex_cmds_defs.h"
-#include "nvim/option_defs.h"
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/option_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 #include "nvim/types.h"
 
 // flags for skip_vimgrep_pat()

src/nvim/regexp.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/pos.h"
 #include "nvim/regexp_defs.h"  // IWYU pragma: export
 #include "nvim/types.h"
 

src/nvim/sha256.h

@@ -1,10 +1,8 @@
 #pragma once
 
-#include <stddef.h>
+#include <stddef.h>  // IWYU pragma: keep
 #include <stdint.h>
 
-#include "nvim/types.h"
-
 #define SHA256_BUFFER_SIZE 64
 #define SHA256_SUM_SIZE    32
 

src/nvim/shada.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <msgpack.h>
+#include <msgpack.h>  // IWYU pragma: keep
 
 /// Flags for shada_read_file and children
 typedef enum {

src/nvim/sign.h

@@ -1,11 +1,10 @@
 #pragma once
 
-#include <stdbool.h>
-
 #include "nvim/buffer_defs.h"  // IWYU pragma: keep
 #include "nvim/cmdexpand_defs.h"  // IWYU pragma: keep
 #include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
 #include "nvim/sign_defs.h"  // IWYU pragma: export
+#include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "sign.h.generated.h"

src/nvim/sign_defs.h

@@ -1,10 +1,5 @@
 #pragma once
 
-#include <stdbool.h>
-
-#include "nvim/pos.h"
-#include "nvim/types.h"
-
 /// Sign attributes. Used by the screen refresh routines.
 typedef struct {
   char *text;
@@ -22,6 +17,6 @@ typedef struct sign {
   int sn_num_hl;   // highlight ID for line number
 } sign_T;
 
-#define SIGN_WIDTH 2      // Number of display cells for a sign in the signcolumn
-#define SIGN_SHOW_MAX 9   // Maximum number of signs shown on a single line
-#define SIGN_DEF_PRIO 10  // Default sign highlight priority
+enum { SIGN_WIDTH = 2, };  ///< Number of display cells for a sign in the signcolumn
+enum { SIGN_SHOW_MAX = 9, };  ///< Maximum number of signs shown on a single line
+enum { SIGN_DEF_PRIO = 10, };  ///< Default sign highlight priority

src/nvim/spell.h

@@ -7,6 +7,21 @@
 #include "nvim/spell_defs.h"  // IWYU pragma: export
 #include "nvim/vim.h"
 
+/// First language that is loaded, start of the linked list of loaded languages.
+extern slang_T *first_lang;
+
+/// file used for "zG" and "zW"
+extern char *int_wordlist;
+
+extern spelltab_T spelltab;
+extern int did_set_spelltab;
+
+extern char *e_format;
+
+// Remember what "z?" replaced.
+extern char *repl_from;
+extern char *repl_to;
+
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "spell.h.generated.h"
 #endif

src/nvim/spell_defs.h

@@ -5,8 +5,8 @@
 
 #include "nvim/buffer_defs.h"
 #include "nvim/garray_defs.h"
+#include "nvim/hashtab.h"
 #include "nvim/regexp_defs.h"
-#include "nvim/types.h"
 
 #define MAXWLEN 254             // Assume max. word len is this many bytes.
                                 // Some places assume a word length fits in a
@@ -221,18 +221,6 @@ typedef struct {
 
 #define SPELL_ISUPPER(c) ((c) >= 128 ? mb_isupper(c) : spelltab.st_isu[c])
 
-// First language that is loaded, start of the linked list of loaded
-// languages.
-extern slang_T *first_lang;
-
-// file used for "zG" and "zW"
-extern char *int_wordlist;
-
-extern spelltab_T spelltab;
-extern int did_set_spelltab;
-
-extern char *e_format;
-
 // Values for "what" argument of spell_add_word()
 typedef enum {
   SPELL_ADD_GOOD = 0,
@@ -248,7 +236,3 @@ typedef struct wordcount_S {
 #define WC_KEY_OFF   offsetof(wordcount_T, wc_word)
 #define HI2WC(hi)    ((wordcount_T *)((hi)->hi_key - WC_KEY_OFF))
 #define MAXWORDCOUNT 0xffff
-
-// Remember what "z?" replaced.
-extern char *repl_from;
-extern char *repl_to;

src/nvim/spellfile.h

@@ -1,10 +1,7 @@
 #pragma once
 
-#include <stdbool.h>
-
-#include "nvim/ex_cmds_defs.h"
-#include "nvim/spell_defs.h"
-#include "nvim/types.h"
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/spell_defs.h"  // IWYU pragma: keep
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "spellfile.h.generated.h"

src/nvim/state.c

@@ -1,5 +1,4 @@
 #include <stdbool.h>
-#include <stddef.h>
 #include <string.h>
 
 #include "nvim/ascii.h"

src/nvim/state.h

@@ -1,9 +1,5 @@
 #pragma once
 
-#include <stddef.h>
-
-struct vim_state;
-
 typedef struct vim_state VimState;
 
 typedef int (*state_check_callback)(VimState *state);

src/nvim/statusline_defs.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <stdbool.h>
 #include <stddef.h>
 
 #include "nvim/fold_defs.h"

src/nvim/tag.h

@@ -1,39 +1,42 @@
 #pragma once
 
-#include "nvim/ex_cmds_defs.h"
-#include "nvim/option_defs.h"
-#include "nvim/types.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/ex_cmds_defs.h"  // IWYU pragma: keep
+#include "nvim/option_defs.h"  // IWYU pragma: keep
 
-// Values for do_tag().
-#define DT_TAG          1       // jump to newer position or same tag again
-#define DT_POP          2       // jump to older position
-#define DT_NEXT         3       // jump to next match of same tag
-#define DT_PREV         4       // jump to previous match of same tag
-#define DT_FIRST        5       // jump to first match of same tag
-#define DT_LAST         6       // jump to first match of same tag
-#define DT_SELECT       7       // jump to selection from list
-#define DT_HELP         8       // like DT_TAG, but no wildcards
-#define DT_JUMP         9       // jump to new tag or selection from list
-#define DT_LTAG         11      // tag using location list
-#define DT_FREE         99      // free cached matches
+/// Values for do_tag().
+enum {
+  DT_TAG    = 1,   ///< jump to newer position or same tag again
+  DT_POP    = 2,   ///< jump to older position
+  DT_NEXT   = 3,   ///< jump to next match of same tag
+  DT_PREV   = 4,   ///< jump to previous match of same tag
+  DT_FIRST  = 5,   ///< jump to first match of same tag
+  DT_LAST   = 6,   ///< jump to first match of same tag
+  DT_SELECT = 7,   ///< jump to selection from list
+  DT_HELP   = 8,   ///< like DT_TAG, but no wildcards
+  DT_JUMP   = 9,   ///< jump to new tag or selection from list
+  DT_LTAG   = 11,  ///< tag using location list
+  DT_FREE   = 99,  ///< free cached matches
+};
 
-// flags for find_tags().
-#define TAG_HELP        1       // only search for help tags
-#define TAG_NAMES       2       // only return name of tag
-#define TAG_REGEXP      4       // use tag pattern as regexp
-#define TAG_NOIC        8       // don't always ignore case
-#define TAG_VERBOSE     32      // message verbosity
-#define TAG_INS_COMP    64      // Currently doing insert completion
-#define TAG_KEEP_LANG   128     // keep current language
-#define TAG_NO_TAGFUNC  256     // do not use 'tagfunc'
+/// flags for find_tags().
+enum {
+  TAG_HELP       = 1,    ///< only search for help tags
+  TAG_NAMES      = 2,    ///< only return name of tag
+  TAG_REGEXP     = 4,    ///< use tag pattern as regexp
+  TAG_NOIC       = 8,    ///< don't always ignore case
+  TAG_VERBOSE    = 32,   ///< message verbosity
+  TAG_INS_COMP   = 64,   ///< Currently doing insert completion
+  TAG_KEEP_LANG  = 128,  ///< keep current language
+  TAG_NO_TAGFUNC = 256,  ///< do not use 'tagfunc'
+  TAG_MANY       = 300,  ///< When finding many tags (for completion), find up to this many tags
+};
 
-#define TAG_MANY        300     // When finding many tags (for completion),
-                                // find up to this many tags
-
-// Structure used for get_tagfname().
+/// Structure used for get_tagfname().
 typedef struct {
-  char *tn_tags;           // value of 'tags' when starting
-  char *tn_np;             // current position in tn_tags
+  char *tn_tags;           ///< value of 'tags' when starting
+  char *tn_np;             ///< current position in tn_tags
   int tn_did_filefind_init;
   int tn_hf_idx;
   void *tn_search_ctx;

src/nvim/terminal.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ -9,7 +8,7 @@ typedef void (*terminal_write_cb)(char *buffer, size_t size, void *data);
 typedef void (*terminal_resize_cb)(uint16_t width, uint16_t height, void *data);
 typedef void (*terminal_close_cb)(void *data);
 
-#include "nvim/buffer_defs.h"
+#include "nvim/buffer_defs.h"  // IWYU pragma: keep
 
 typedef struct {
   void *data;  // PTY process channel

src/nvim/testing.h

@@ -1,6 +1,7 @@
 #pragma once
 
-#include "nvim/eval/typval_defs.h"
+#include "nvim/eval/typval_defs.h"  // IWYU pragma: keep
+#include "nvim/types.h"
 
 #ifdef INCLUDE_GENERATED_DECLARATIONS
 # include "testing.h.generated.h"