From 68d91985013f046b9dd160932781825e3856cf9f Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Mon, 8 Aug 2016 01:04:20 -0400 Subject: [PATCH 1/2] XXX: CI: Disable hanging test on Travis OSX. Temporary change to avoid frequent hangs on Travis macOS/OSX builds. Hang does not occur on Quickbuild OSX (Yosemite) build. Reverting e9061117a5b8f195c3f26a5cb94e18ddd7752d86 avoids the hang, but causes more serious regressions on many more systems. Note that the job_spec hang only happens with the gcc-4.9 Travis OSX build. References #5002 References #5029 --- test/functional/api/server_requests_spec.lua | 6 ++++++ test/functional/core/job_spec.lua | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/test/functional/api/server_requests_spec.lua b/test/functional/api/server_requests_spec.lua index 54095112fb..eb63834cb0 100644 --- a/test/functional/api/server_requests_spec.lua +++ b/test/functional/api/server_requests_spec.lua @@ -137,6 +137,12 @@ describe('server -> client', function() end) describe('when the client is a recursive vim instance', function() + if os.getenv("TRAVIS") and helpers.os_name() == "osx" then + -- XXX: Hangs Travis OSX since e9061117a5b8f195c3f26a5cb94e18ddd7752d86. + pending("[Hangs on Travis OSX. #5002]", function() end) + return + end + before_each(function() nvim('command', "let vim = rpcstart('"..nvim_prog.."', ['-u', 'NONE', '-i', 'NONE', '--cmd', 'set noswapfile', '--embed'])") neq(0, eval('vim')) diff --git a/test/functional/core/job_spec.lua b/test/functional/core/job_spec.lua index 61ecdd1835..1d11374e4d 100644 --- a/test/functional/core/job_spec.lua +++ b/test/functional/core/job_spec.lua @@ -105,6 +105,13 @@ describe('jobs', function() end) it("will not buffer data if it doesn't end in newlines", function() + if os.getenv("TRAVIS") and os.getenv("CC") == "gcc-4.9" + and helpers.os_name() == "osx" then + -- XXX: Hangs Travis OSX since e9061117a5b8f195c3f26a5cb94e18ddd7752d86. + pending("[Hangs on Travis OSX. #5002]", function() end) + return + end + nvim('command', "let j = jobstart(['cat', '-'], g:job_opts)") nvim('command', 'call jobsend(j, "abc\\nxyz")') eq({'notification', 'stdout', {0, {'abc', 'xyz'}}}, next_msg()) From 348fcee5fb5c9abb0bbe86e1a018abd6fb0d8074 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Mon, 8 Aug 2016 01:16:08 -0400 Subject: [PATCH 2/2] test: Fix os_name() call. --- test/functional/legacy/file_perm_spec.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/legacy/file_perm_spec.lua b/test/functional/legacy/file_perm_spec.lua index 98bdf630dd..9ebbfd25e4 100644 --- a/test/functional/legacy/file_perm_spec.lua +++ b/test/functional/legacy/file_perm_spec.lua @@ -21,7 +21,7 @@ describe('Test getting and setting file permissions', function() eq(9, call('len', call('getfperm', tempfile))) eq(1, call('setfperm', tempfile, 'rwx------')) - if helpers.os_name == 'windows' then + if helpers.os_name() == 'windows' then eq('rw-rw-rw-', call('getfperm', tempfile)) else eq('rwx------', call('getfperm', tempfile))