kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-01-01 17:23:36 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings: message.c: copy_hotkeys_and_msg: Garbage value: FP. #2062

Browse Source 
Problem    : Branch condition evaluates to a garbage value @ 2868.
Diagnostic : False positive.
Rationale  : Array has_hotkey, declared at 2812, is initialized by
             console_dialog_alloc (only the needed number of elements).
             That same number of elements is used by
             copy_hotkeys_and_msg.
             Suggested path error is impossible, because it involves a
             different number of elements in those functions.
Resolution : Above condition is cumbersome to prove through assertions.
             Thus, we prefer to just initialize the array to all-false
             at declaration point before calling console_dialog_alloc.
This commit is contained in:
Eliseo Martínez 2015-02-25 22:37:38 +01:00
parent 61c98e7e35
commit 36092f3a0c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/message.c
View File

@ -2809,7 +2809,7 @@ static char_u * console_dialog_alloc(const char_u *message,
static char_u *msg_show_console_dialog(char_u *message, char_u *buttons, int dfltbutton) static char_u *msg_show_console_dialog(char_u *message, char_u *buttons, int dfltbutton)
FUNC_ATTR_NONNULL_RET FUNC_ATTR_NONNULL_RET
{ {
bool has_hotkey[HAS_HOTKEY_LEN]; bool has_hotkey[HAS_HOTKEY_LEN] = {false};
char_u *hotk = console_dialog_alloc(message, buttons, has_hotkey); char_u *hotk = console_dialog_alloc(message, buttons, has_hotkey);
copy_hotkeys_and_msg(message, buttons, dfltbutton, has_hotkey, hotk); copy_hotkeys_and_msg(message, buttons, dfltbutton, has_hotkey, hotk);