kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-19 10:45:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

perf: remove redundant strlen in skipwhite (#26177)

Browse Source 
skipwhite was iterating over the input twice and scanning for the null
byte character with strlen. this is redundant, because it's already
covered by ascii_iswhite that accepts only space or tab character.

Co-authored-by: ii14 <ii14@users.noreply.github.com>
This commit is contained in:
ii14 2023-11-23 22:26:33 +01:00 committed by GitHub
parent df399ea0d2
commit 32a4c9f4f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/nvim/charset.c
View File

@ -903,11 +903,14 @@ bool vim_isprintc_strict(int c)
/// @param[in] p String to skip in. /// @param[in] p String to skip in.
/// ///
/// @return Pointer to character after the skipped whitespace. /// @return Pointer to character after the skipped whitespace.
char *skipwhite(const char *const p) char *skipwhite(const char *p)
FUNC_ATTR_PURE FUNC_ATTR_WARN_UNUSED_RESULT FUNC_ATTR_NONNULL_ALL FUNC_ATTR_PURE FUNC_ATTR_WARN_UNUSED_RESULT FUNC_ATTR_NONNULL_ALL
FUNC_ATTR_NONNULL_RET FUNC_ATTR_NONNULL_RET
{ {
return skipwhite_len(p, strlen(p)); while (ascii_iswhite(*p)) {
p++;
}
return (char *)p;
} }
/// Like `skipwhite`, but skip up to `len` characters. /// Like `skipwhite`, but skip up to `len` characters.