kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-20 03:05:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.1444: crash when passing NULL to setcmdline() (#23048)

Browse Source 
Problem:    Crash when passing NULL to setcmdline(). (Andreas Louv)
Solution:   Use tv_get_string() instead of using v_string directly.
            (closes vim/vim#12231, closes vim/vim#12227)

ac6cd31afc
This commit is contained in:
zeertzjq 2023-04-12 23:51:43 +08:00 committed by GitHub
parent cdc028e97d
commit 23e9d625cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/nvim/ex_getln.c
View File

@ -4209,7 +4209,8 @@ void f_setcmdline(typval_T *argvars, typval_T *rettv, EvalFuncData fptr)
} }
} }
rettv->vval.v_number = set_cmdline_str(argvars[0].vval.v_string, pos); // Use tv_get_string() to handle a NULL string like an empty string.
rettv->vval.v_number = set_cmdline_str(tv_get_string(&argvars[0]), pos);
} }
/// "setcmdpos()" function /// "setcmdpos()" function

8
test/old/testdir/test_cmdline.vim
View File

@ -3532,6 +3532,14 @@ endfunc
func Test_setcmdline() func Test_setcmdline()
func SetText(text, pos) func SetText(text, pos)
call assert_equal(0, setcmdline(v:_null_string))
call assert_equal('', getcmdline())
call assert_equal(1, getcmdpos())
call assert_equal(0, setcmdline(''[: -1]))
call assert_equal('', getcmdline())
call assert_equal(1, getcmdpos())
autocmd CmdlineChanged * let g:cmdtype = expand('<afile>') autocmd CmdlineChanged * let g:cmdtype = expand('<afile>')
call assert_equal(0, setcmdline(a:text)) call assert_equal(0, setcmdline(a:text))
call assert_equal(a:text, getcmdline()) call assert_equal(a:text, getcmdline())