kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-29 14:41:06 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(tui): grid_clear properly clears the screen

Browse Source 
Problem:    When setting a shell size smaller than the containing
            terminal window through `:winsize` or `:set lines/columns`
            the screen is not properly cleared.
Solution:   Clear the tui dimensions rather than the grid dimensions.
This commit is contained in:
Luuk van Baal 2023-05-01 20:08:25 +02:00
parent 066db5e7cd
commit 197827321a
3 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/tui/tui.c
View File

@ -977,7 +977,7 @@ void tui_grid_clear(TUIData *tui, Integer g)
UGrid *grid = &tui->grid;
ugrid_clear(grid);
kv_size(tui->invalid_regions) = 0;
clear_region(tui, 0, grid->height, 0, grid->width, 0);
clear_region(tui, 0, tui->height, 0, tui->width, 0);
}
void tui_grid_cursor_goto(TUIData *tui, Integer grid, Integer row, Integer col)

8
test/functional/terminal/api_spec.lua
View File

@ -66,10 +66,10 @@ describe('api', function()
screen:expect([[
[tui] insert-mode |
[socket 1] this is more t{4: }|
han 25 columns {4: }|
[socket 2] input{1: } {4: }|
{4:~ }|
[socket 1] this is more t |
han 25 columns |
[socket 2] input{1: } |
{4:~ } |
{3:-- INSERT --} |
{3:-- TERMINAL --} |
]])

13
test/functional/terminal/tui_spec.lua
View File

@ -2422,6 +2422,19 @@ describe("TUI as a client", function()
{3:-- TERMINAL --} |
]]}
-- grid smaller than containing terminal window is cleared properly
feed_data(":call setline(1,['a'->repeat(&columns)]->repeat(&lines))\n")
feed_data("0:set lines=2\n")
screen_server:expect{grid=[[
{1:a}aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa|
{5:[No Name] [+] }|
|
|
|
|
{3:-- TERMINAL --} |
]]}
feed_data(":q!\n")
server_super:close()