kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-23 20:55:18 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(coverity): error handling (CHECKED_RETURN)

Browse Source 
CID 516406:  Error handling issues  (CHECKED_RETURN)
    /src/nvim/api/vimscript.c: 284 in nvim_call_dict_function()
    278       Object rv = OBJECT_INIT;
    279
    280       typval_T rettv;
    281       bool mustfree = false;
    282       switch (dict.type) {
    283       case kObjectTypeString:
    >>>     CID 516406:  Error handling issues  (CHECKED_RETURN)
    >>>     Calling "eval0" without checking return value (as is done elsewhere 10 out of 12 times).
    284         TRY_WRAP(err, {
    285           eval0(dict.data.string.data, &rettv, NULL, &EVALARG_EVALUATE);
    286           clear_evalarg(&EVALARG_EVALUATE, NULL);
    287         });
    288         if (ERROR_SET(err)) {
    289           return rv;
This commit is contained in:
Justin M. Keyes 2024-12-18 01:52:02 +01:00
parent 51c380238c
commit 0d08aeccad
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/nvim/api/vimscript.c
View File

@ -282,7 +282,10 @@ Object nvim_call_dict_function(Object dict, String fn, Array args, Arena *arena,
switch (dict.type) {
case kObjectTypeString:
TRY_WRAP(err, {
eval0(dict.data.string.data, &rettv, NULL, &EVALARG_EVALUATE);
int rv = eval0(dict.data.string.data, &rettv, NULL, &EVALARG_EVALUATE);
if (rv != OK && !ERROR_SET(err)) {
abort();
}
clear_evalarg(&EVALARG_EVALUATE, NULL);
});
if (ERROR_SET(err)) {