From 0288ba6e3820ffa05fbb435a678cbc66e1ac730d Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Thu, 8 Aug 2019 16:02:59 +0200 Subject: [PATCH] build: Makefile: use _opt_pylint [ci skip] (#10720) A separate rule it clearer, and allows for `make --keep-going lint` in general later. Ref: https://github.com/neovim/neovim/pull/10714 --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 97bb3f43ae..fff0ffef28 100644 --- a/Makefile +++ b/Makefile @@ -141,6 +141,11 @@ lualint: | build/.ran-cmake deps pylint: flake8 contrib/ scripts/ src/ test/ +# Run pylint only if flake8 is installed. +_opt_pylint: + @command -v flake8 && { $(MAKE) pylint; exit $$?; } \ + || echo "SKIP: pylint (flake8 not found)" + unittest: | nvim +$(BUILD_CMD) -C build unittest @@ -182,11 +187,7 @@ appimage: appimage-%: bash scripts/genappimage.sh $* -lint: check-single-includes clint lualint - @# Run pylint only if flake8 is installed. - @command -v flake8 \ - && { $(MAKE) pylint; exit $$?; } \ - || echo "SKIP: pylint (flake8 not found)" +lint: check-single-includes clint lualint _opt_pylint # Generic pattern rules, allowing for `make build/bin/nvim` etc. # Does not work with "Unix Makefiles".