kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-26 14:11:15 -07:00
Code Issues Packages Projects Releases Wiki Activity
8ba73f0e4c
neovim/cmake.deps/cmake/BuildLuv.cmake

44 lines
1.3 KiB
CMake
Raw Normal View History

build: various cmake fixes (#21902) * build: various cmake refactors and simplifications - Add STATUS keyword to message to ensure messages are shown in the correct order. - Remove DEPS_CXX_COMPILER as we don't rely on C++ for any of our dependencies. - Simplify how msgpack and luv configure options are constructed. - Rely on the default installation for luv instead of manually passing configure, build and install commands. - Simplify return code conditional. * build: remove CMAKE_OSX_ARCHITECTURES_ALT_SEP workaround CMAKE_OSX_ARCHITECTURES_ALT_SEP was defined as a workaround to prevent the shell from interpreting `;`, which CMake uses as a list separator. However, the same thing can be achieved by instead passing CMAKE_OSX_ARCHITECTURES as a cache variable instead, which is a more idiomatic way of achieving the same thing. * build: define CMAKE_BUILD_TYPE before adding it to BUILD_TYPE_STRING The problem with the current setup is that CMAKE_BUILD_TYPE is defined after BUILD_TYPE_STRING. BUILD_TYPE_STRING will then be empty on the first run, meaning that dependencies are built without a build type. However, since CMAKE_BUILD_TYPE is a cache variable its value will persist in subsequent runs. On the second run BUILD_TYPE_STRING will have the correct value, but it's a different value from the ones the dependencies were built with. This will force some dependencies to be built again. Fixes https://github.com/neovim/neovim/issues/21672.
2023-01-20 15:48:46 -07:00
set(LUV_CMAKE_ARGS
build: prefer -D <variable>=<value> over -D<variable>=<value> (#22164) This makes it easier to see that -D is referring to the entire "<variable>=<value>", rather than only <variable>. It also help syntax highlighters highlight built-in variables.
2023-02-08 03:00:16 -07:00
-D LUA_BUILD_TYPE=System
build: introduce variable DEPS_IGNORE_SHA for skipping dependency hash check This will reduce friction as developers no longer need to provide a hash when testing out different commits. To skip the hash check, set `DEPS_IGNORE_SHA` to `TRUE` in `cmake.deps/CMakeLists.txt`.
2024-03-18 05:29:24 -07:00
-D LUA_COMPAT53_DIR=${DEPS_BUILD_DIR}/src/lua_compat53
build: prefer -D <variable>=<value> over -D<variable>=<value> (#22164) This makes it easier to see that -D is referring to the entire "<variable>=<value>", rather than only <variable>. It also help syntax highlighters highlight built-in variables.
2023-02-08 03:00:16 -07:00
-D WITH_SHARED_LIBUV=ON
-D BUILD_STATIC_LIBS=ON
-D BUILD_MODULE=OFF)
Add luv as a third party dependency Luv is a simple lua binding to libuv, which is now used by neovim lua client. The bundled luv installation a bit different from other dependencies in that it is installed two times: - The "BuildLuv.cmake" script downloads and installs a static version of luv using its normal cmake build script. This static version will be used later. - Luv default rockspec is replaced with the alternate under the "rockspecs" directory(the alternate rockspec plays nicer with neovim build system) - The alternate rockspec is used to build/install the lua module and make it available to lua scripts.
2016-04-10 19:49:23 -07:00
build: various build improvements - remove "ran-" prefix from touch files as it's redundant since the they're already in the directory named `touches`. - Include `contrib` when formatting with `make formatlua`. - Use TARGET_FILE generator expression instead of assuming the executable location. - reuse logic that determines whether to use lua or luajit. - add translations to the `nvim` target. Makefile improvements: - rename variable `CMAKE_PRG` to `CMAKE` to make it more consistent with the builtin `MAKE` variable. - stop propagating flags to generator. Users should use cmake for non-standard use cases. - remove `+` prefix from targets. If the user for whatever reason wants to dry-run a target then they should be able to.
2024-01-01 05:08:56 -07:00
list(APPEND LUV_CMAKE_ARGS -D WITH_LUA_ENGINE=${LUA_ENGINE})
build: BuildLuv: set/pass WITH_LUA_ENGINE (#10449) Ref: https://github.com/neovim/neovim/pull/10438
2019-07-09 12:55:01 -07:00
Change to use bundled libuv to build luv
2018-05-27 02:16:29 -07:00
if(USE_BUNDLED_LIBUV)
build: cmake cleanup (#22251) - Remove unused code - Use consistent casing. Variable names such as LibLuV_LIBRARIES is needlessly jarring, even if the name might be technically correct. - Use title casing for packages. find_package(unibilium) requires the find_module to be named "Findunibilium.cmake", which makes it harder to spot when scanning the files. Instead, use "Unibilium".
2023-03-02 14:50:43 -07:00
list(APPEND LUV_CMAKE_ARGS -D CMAKE_PREFIX_PATH=${DEPS_INSTALL_DIR})
Change to use bundled libuv to build luv
2018-05-27 02:16:29 -07:00
endif()
build: disable all compiler warnings from dependencies
2023-11-19 18:01:39 -07:00
list(APPEND LUV_CMAKE_ARGS "-DCMAKE_C_FLAGS:STRING=${DEPS_INCLUDE_FLAGS} -w")
build: use CMAKE_POSITION_INDEPENDENT_CODE instead of -fPIC (#21947) It's simpler to let cmake figure out what flags to add to each platforms to create position independent code rather than handling it ourselves. Also remove code that sets POSITION_INDEPENDENT_CODE property on SHARED and MODULE libraries, as it's already on by default.
2023-01-22 10:02:02 -07:00
if(CMAKE_GENERATOR MATCHES "Unix Makefiles" AND
(CMAKE_SYSTEM_NAME MATCHES ".*BSD" OR CMAKE_SYSTEM_NAME MATCHES "DragonFly"))
build: prefer -D <variable>=<value> over -D<variable>=<value> (#22164) This makes it easier to see that -D is referring to the entire "<variable>=<value>", rather than only <variable>. It also help syntax highlighters highlight built-in variables.
2023-02-08 03:00:16 -07:00
list(APPEND LUV_CMAKE_ARGS -D CMAKE_MAKE_PROGRAM=gmake)
Add luv as a third party dependency Luv is a simple lua binding to libuv, which is now used by neovim lua client. The bundled luv installation a bit different from other dependencies in that it is installed two times: - The "BuildLuv.cmake" script downloads and installs a static version of luv using its normal cmake build script. This static version will be used later. - Luv default rockspec is replaced with the alternate under the "rockspecs" directory(the alternate rockspec plays nicer with neovim build system) - The alternate rockspec is used to build/install the lua module and make it available to lua scripts.
2016-04-10 19:49:23 -07:00
endif()
build: use `GIT_REPOSITORY` for local URLs `GIT_REPOSITORY` will cause cmake to rebuild if local dependency changes, which isn't the case for `URL`. Also document how to test a different commits of a dependency.
2024-03-18 04:23:53 -07:00
get_externalproject_options(lua_compat53 ${DEPS_IGNORE_SHA})
build: introduce variable DEPS_IGNORE_SHA for skipping dependency hash check This will reduce friction as developers no longer need to provide a hash when testing out different commits. To skip the hash check, set `DEPS_IGNORE_SHA` to `TRUE` in `cmake.deps/CMakeLists.txt`.
2024-03-18 05:29:24 -07:00
ExternalProject_Add(lua_compat53
DOWNLOAD_DIR ${DEPS_DOWNLOAD_DIR}/lua_compat53
build: remove unnecessary build functions These functions serve no purpose if they're only used as intermediary functions that passes on arguments to ExternalProject_Add.
2022-08-29 07:57:46 -07:00
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
fixup: quick update, squash later
2023-11-20 04:42:54 -07:00
INSTALL_COMMAND ""
${EXTERNALPROJECT_OPTIONS})
Add luv as a third party dependency Luv is a simple lua binding to libuv, which is now used by neovim lua client. The bundled luv installation a bit different from other dependencies in that it is installed two times: - The "BuildLuv.cmake" script downloads and installs a static version of luv using its normal cmake build script. This static version will be used later. - Luv default rockspec is replaced with the alternate under the "rockspecs" directory(the alternate rockspec plays nicer with neovim build system) - The alternate rockspec is used to build/install the lua module and make it available to lua scripts.
2016-04-10 19:49:23 -07:00
build: use `GIT_REPOSITORY` for local URLs `GIT_REPOSITORY` will cause cmake to rebuild if local dependency changes, which isn't the case for `URL`. Also document how to test a different commits of a dependency.
2024-03-18 04:23:53 -07:00
get_externalproject_options(luv ${DEPS_IGNORE_SHA})
build: cmake cleanup - Simplify error checking when using execute_process. - Set BUILD_SHARED_LIBS to OFF when building dependencies. This is normally not needed, but msgpack interprets an unset BUILD_SHARED_LIBS to build a shared library, which is the opposite of the cmake behavior. - Move function check_lua_module to Util.cmake. - Remove unnecessary code. - Make variable naming more consistent
2023-05-13 03:12:29 -07:00
ExternalProject_Add(luv
build: introduce variable DEPS_IGNORE_SHA for skipping dependency hash check This will reduce friction as developers no longer need to provide a hash when testing out different commits. To skip the hash check, set `DEPS_IGNORE_SHA` to `TRUE` in `cmake.deps/CMakeLists.txt`.
2024-03-18 05:29:24 -07:00
DEPENDS lua_compat53
build: remove unnecessary build functions These functions serve no purpose if they're only used as intermediary functions that passes on arguments to ExternalProject_Add.
2022-08-29 07:57:46 -07:00
DOWNLOAD_DIR ${DEPS_DOWNLOAD_DIR}/luv
build: rely on builtin cmake downloading rather than custom script DownloadAndExtractFile.cmake was initially introduced as a workaround to avoid the massive amounts of logs generated by the download progress. This is not a problem anymore as ExternalProject_Add has had the DOWNLOAD_NO_PROGRESS option since cmake version 3.1.
2022-09-29 12:46:14 -07:00
SOURCE_DIR ${DEPS_BUILD_DIR}/src/luv
build: introduce default build variables (#21991) There are a number of cmake variables and cache variables that need to be passed to all dependencies. This is not only cumbersome, but also fragile as it's easy to miss adding or removing a flag from a dependency by accident. Introducing a global variable that controls all builds makes it much easier to handle our dependencies. Also fixes the currently broken release workflow as we need to pass the CMAKE_OSX_ARCHITECTURES variable to all dependencies built with cmake.
2023-01-25 06:36:17 -07:00
CMAKE_ARGS ${DEPS_CMAKE_ARGS} ${LUV_CMAKE_ARGS}
fixup: quick update, squash later
2023-11-20 04:42:54 -07:00
${EXTERNALPROJECT_OPTIONS})
Add luv as a third party dependency Luv is a simple lua binding to libuv, which is now used by neovim lua client. The bundled luv installation a bit different from other dependencies in that it is installed two times: - The "BuildLuv.cmake" script downloads and installs a static version of luv using its normal cmake build script. This static version will be used later. - Luv default rockspec is replaced with the alternate under the "rockspecs" directory(the alternate rockspec plays nicer with neovim build system) - The alternate rockspec is used to build/install the lua module and make it available to lua scripts.
2016-04-10 19:49:23 -07:00
build: Do not ref `libuv` CMake target if USE_BUNDLED_LIBUV=OFF. (#6363) CMake Warning: The dependency target "libuv" of target "luv-static" does not exist. (CMP0046) Closes #6355
2017-03-25 16:22:15 -07:00
if(USE_BUNDLED_LUAJIT)
build: cmake cleanup - Simplify error checking when using execute_process. - Set BUILD_SHARED_LIBS to OFF when building dependencies. This is normally not needed, but msgpack interprets an unset BUILD_SHARED_LIBS to build a shared library, which is the opposite of the cmake behavior. - Move function check_lua_module to Util.cmake. - Remove unnecessary code. - Make variable naming more consistent
2023-05-13 03:12:29 -07:00
add_dependencies(luv luajit)
build libuv cmake (#19632) Co-authored-by: Daniel Hahler <git@thequod.de>
2022-08-12 08:59:40 -07:00
elseif(USE_BUNDLED_LUA)
build: cmake cleanup - Simplify error checking when using execute_process. - Set BUILD_SHARED_LIBS to OFF when building dependencies. This is normally not needed, but msgpack interprets an unset BUILD_SHARED_LIBS to build a shared library, which is the opposite of the cmake behavior. - Move function check_lua_module to Util.cmake. - Remove unnecessary code. - Make variable naming more consistent
2023-05-13 03:12:29 -07:00
add_dependencies(luv lua)
build: Do not ref `libuv` CMake target if USE_BUNDLED_LIBUV=OFF. (#6363) CMake Warning: The dependency target "libuv" of target "luv-static" does not exist. (CMP0046) Closes #6355
2017-03-25 16:22:15 -07:00
endif()
if(USE_BUNDLED_LIBUV)
build: cmake cleanup - Simplify error checking when using execute_process. - Set BUILD_SHARED_LIBS to OFF when building dependencies. This is normally not needed, but msgpack interprets an unset BUILD_SHARED_LIBS to build a shared library, which is the opposite of the cmake behavior. - Move function check_lua_module to Util.cmake. - Remove unnecessary code. - Make variable naming more consistent
2023-05-13 03:12:29 -07:00
add_dependencies(luv libuv)
build: Do not ref `libuv` CMake target if USE_BUNDLED_LIBUV=OFF. (#6363) CMake Warning: The dependency target "libuv" of target "luv-static" does not exist. (CMP0046) Closes #6355
2017-03-25 16:22:15 -07:00
endif()
Reference in New Issue Copy Permalink