kevin/neovim
1
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2024-12-22 04:05:09 -07:00
Code Issues Packages Projects Releases Wiki Activity
04d951685b
neovim/test/old/testdir/test_history.vim

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

266 lines
8.3 KiB
VimL
Raw Normal View History

vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
" Tests for the history functions
vim-patch:8.1.{1524,1544}: tests are silently skipped (#19276) This is a port of these two patches combined: vim-patch:8.1.1524: tests are silently skipped Problem: Tests are silently skipped. Solution: Throw an exception for skipped tests in more places. https://github.com/vim/vim/commit/b0f94c1ff34d27d33aa9f96204985ea29c2eb0a1 vim-patch:8.1.1544: some balloon tests don't run when they can Problem: Some balloon tests don't run when they can. Solution: Split GUI balloon tests off into a separate file. (Ozaki Kiichi, closes vim/vim#4538) Change the feature check into a command for consistency. https://github.com/vim/vim/commit/b46fecd3454399f8ebdc5055302e4bfc5a10f98b Omit test_lua.vim: previous patches are N/A Omit test_memory_usage.vim: previous patches are N/A Omit test_textprop.vim: previous patches are N/A Omit test_winbar.vim: previous patches are N/A Omit test_termcodes.vim: mostly N/A Skip Test_mouse_positon() because it uses test_setmouse(). Cannot throw error in a Test_nocatch_ test. Use latest `CheckFeature clipboard_working` for test_quotestar.vim
2022-07-07 17:26:25 -07:00
source check.vim
CheckFeature cmdline_hist
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
set history=7
function History_Tests(hist)
" First clear the history
call histadd(a:hist, 'dummy')
call assert_true(histdel(a:hist))
call assert_equal(-1, histnr(a:hist))
call assert_equal('', histget(a:hist))
feat(eval/method): partially port v8.1.1953 Adds method call support for all functions in the patch, but it cannot be fully ported due to missing tests for: - index(): requires Blobs from v8.1.0735. Note that index() was already added as a method in v8.1.1803; this patch only adds a test. - iconv(): requires v8.1.1136 for test_termcodes.vim. Nvim deprecated inputdialog(), so it no longer has an eval.txt entry. Keep the test for hlexists() commented-out, just like previously. (Nvim always defines the Number group, so it always returns 1 instead) Cannot include both changes to test_syn_attr.vim as Nvim doesn't support ":hi term=..."; however, both test the same ->hlID() syntax anyway.
2021-08-31 14:51:29 -07:00
call assert_true('ls'->histadd(a:hist))
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
call assert_true(histadd(a:hist, 'buffers'))
call assert_equal('buffers', histget(a:hist))
call assert_equal('ls', histget(a:hist, -2))
call assert_equal('ls', histget(a:hist, 1))
call assert_equal('', histget(a:hist, 5))
call assert_equal('', histget(a:hist, -5))
call assert_equal(2, histnr(a:hist))
call assert_true(histdel(a:hist, 2))
feat(eval/method): partially port v8.1.1953 Adds method call support for all functions in the patch, but it cannot be fully ported due to missing tests for: - index(): requires Blobs from v8.1.0735. Note that index() was already added as a method in v8.1.1803; this patch only adds a test. - iconv(): requires v8.1.1136 for test_termcodes.vim. Nvim deprecated inputdialog(), so it no longer has an eval.txt entry. Keep the test for hlexists() commented-out, just like previously. (Nvim always defines the Number group, so it always returns 1 instead) Cannot include both changes to test_syn_attr.vim as Nvim doesn't support ":hi term=..."; however, both test the same ->hlID() syntax anyway.
2021-08-31 14:51:29 -07:00
call assert_false(a:hist->histdel(7))
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
call assert_equal(1, histnr(a:hist))
call assert_equal('ls', histget(a:hist, -1))
call assert_true(histadd(a:hist, 'buffers'))
call assert_true(histadd(a:hist, 'ls'))
feat(eval/method): partially port v8.1.1953 Adds method call support for all functions in the patch, but it cannot be fully ported due to missing tests for: - index(): requires Blobs from v8.1.0735. Note that index() was already added as a method in v8.1.1803; this patch only adds a test. - iconv(): requires v8.1.1136 for test_termcodes.vim. Nvim deprecated inputdialog(), so it no longer has an eval.txt entry. Keep the test for hlexists() commented-out, just like previously. (Nvim always defines the Number group, so it always returns 1 instead) Cannot include both changes to test_syn_attr.vim as Nvim doesn't support ":hi term=..."; however, both test the same ->hlID() syntax anyway.
2021-08-31 14:51:29 -07:00
call assert_equal('ls', a:hist->histget(-1))
call assert_equal(4, a:hist->histnr())
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
vim-patch:8.0.0111 (#7090) Problem: The :history command is not tested. Solution: Add tests. (Dominique Pelle) https://github.com/vim/vim/commit/eebd84eb94ed7f59a06a52cb4863563642f58899
2017-08-06 14:42:52 -07:00
let a=execute('history ' . a:hist)
call assert_match("^\n # \\S* history\n 3 buffers\n> 4 ls$", a)
let a=execute('history all')
call assert_match("^\n # .* history\n 3 buffers\n> 4 ls", a)
if len(a:hist) > 0
let a=execute('history ' . a:hist . ' 2')
call assert_match("^\n # \\S* history$", a)
let a=execute('history ' . a:hist . ' 3')
call assert_match("^\n # \\S* history\n 3 buffers$", a)
let a=execute('history ' . a:hist . ' 4')
call assert_match("^\n # \\S* history\n> 4 ls$", a)
let a=execute('history ' . a:hist . ' 3,4')
call assert_match("^\n # \\S* history\n 3 buffers\n> 4 ls$", a)
let a=execute('history ' . a:hist . ' -1')
call assert_match("^\n # \\S* history\n> 4 ls$", a)
let a=execute('history ' . a:hist . ' -2')
call assert_match("^\n # \\S* history\n 3 buffers$", a)
let a=execute('history ' . a:hist . ' -2,')
call assert_match("^\n # \\S* history\n 3 buffers\n> 4 ls$", a)
let a=execute('history ' . a:hist . ' -3')
call assert_match("^\n # \\S* history$", a)
endif
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
" Test for removing entries matching a pattern
for i in range(1, 3)
call histadd(a:hist, 'text_' . i)
endfor
call assert_true(histdel(a:hist, 'text_\d\+'))
call assert_equal('ls', histget(a:hist, -1))
" Test for freeing the entire history list
for i in range(1, 7)
call histadd(a:hist, 'text_' . i)
endfor
call histdel(a:hist)
for i in range(1, 7)
call assert_equal('', histget(a:hist, i))
call assert_equal('', histget(a:hist, i - 7 - 1))
endfor
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
" Test for freeing an entry at the beginning of the history list
for i in range(1, 4)
call histadd(a:hist, 'text_' . i)
endfor
call histdel(a:hist, 1)
call assert_equal('', histget(a:hist, 1))
call assert_equal('text_4', histget(a:hist, 4))
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
endfunction
function Test_History()
for h in ['cmd', ':', '', 'search', '/', '?', 'expr', '=', 'input', '@', 'debug', '>']
call History_Tests(h)
endfor
" Negative tests
call assert_false(histdel('abc'))
call assert_equal('', histget('abc'))
call assert_fails('call histdel([])', 'E730:')
call assert_equal('', histget(10))
call assert_fails('call histget([])', 'E730:')
call assert_equal(-1, histnr('abc'))
call assert_fails('call histnr([])', 'E730:')
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
call assert_fails('history xyz', 'E488:')
call assert_fails('history ,abc', 'E488:')
vim-patch:8.2.3421: a bit of code is not covered by tests (#19895) Problem: A bit of code is not covered by tests. Solution: Add a few more test cases. (Dominique Pellé, closes vim/vim#8857) https://github.com/vim/vim/commit/d176ca3dde47c11aae0376c31b7e1ba0939c8c6c Cherry-pick Test_trim() change from patch 8.2.0448. Cherry-pick Test_History() change from patch 8.2.1736. Cherry-pick charidx() and trim() type checks from patch 8.2.3135.
2022-08-22 07:09:53 -07:00
call assert_fails('call histdel(":", "\\%(")', 'E53:')
endfunction
function Test_history_truncates_long_entry()
" History entry short enough to fit on the screen should not be truncated.
call histadd(':', 'echo x' .. repeat('y', &columns - 17) .. 'z')
let a = execute('history : -1')
call assert_match("^\n # cmd history\n"
\ .. "> *\\d\\+ echo x" .. repeat('y', &columns - 17) .. 'z$', a)
" Long history entry should be truncated to fit on the screen, with, '...'
" inserted in the string to indicate the that there is truncation.
call histadd(':', 'echo x' .. repeat('y', &columns - 16) .. 'z')
let a = execute('history : -1')
call assert_match("^\n # cmd history\n"
\ .. "> *\\d\\+ echo xy\\+\.\.\.y\\+z$", a)
vim-patch:7.4.1494 Problem: clr_history() does not work properly. Solution: Increment hisptr. Add a test. (Yegappan Lakshmanan) https://github.com/vim/vim/commit/119d4693e06e68d4f099aa7287e375ae3d265fd0 Note: Only added a test. The change to `histptr` had already been made.
2016-07-11 20:05:43 -07:00
endfunction
vim-patch:8.0.0172 Problem: The command selected in the command line window is not executed. (Andrey Starodubtsev) Solution: Save and restore the command line at a lower level. (closes vim/vim#1370) https://github.com/vim/vim/commit/1d669c233c97486555a34f7d3f069068d9ebdb63
2017-03-21 15:17:10 -07:00
function Test_Search_history_window()
new
call setline(1, ['a', 'b', 'a', 'b'])
1
call feedkeys("/a\<CR>", 'xt')
call assert_equal('a', getline('.'))
1
call feedkeys("/b\<CR>", 'xt')
call assert_equal('b', getline('.'))
1
" select the previous /a command
call feedkeys("q/kk\<CR>", 'x!')
call assert_equal('a', getline('.'))
call assert_equal('a', @/)
bwipe!
endfunc
vim-patch:8.1.0559: command line completion not sufficiently tested Problem: Command line completion not sufficiently tested. Solution: Add more tests. (Dominique Pelle, closes vim/vim#3622) https://github.com/vim/vim/commit/b513d3079bbe3f59a1f1a3d6931939a76cd7e54a
2018-12-03 20:46:11 -07:00
vim-patch:8.2.0342: some code in ex_getln.c not covered by tests Problem: Some code in ex_getln.c not covered by tests. Solution: Add more tests. (Yegappan Lakshmanan, closes vim/vim#5717) https://github.com/vim/vim/commit/0546d7df13b041833121b2d56036e1c62ea3b0c1 Nvim doesn't support imsearch=2, commenting out that line is enough. Test_Ex_append() is not applicable to Vim enhanced Ex mode. Omit test_iminsert.vim as previous patches to that file are N/A.
2022-07-13 06:14:08 -07:00
" Test for :history command option completion
vim-patch:8.1.0559: command line completion not sufficiently tested Problem: Command line completion not sufficiently tested. Solution: Add more tests. (Dominique Pelle, closes vim/vim#3622) https://github.com/vim/vim/commit/b513d3079bbe3f59a1f1a3d6931939a76cd7e54a
2018-12-03 20:46:11 -07:00
function Test_history_completion()
call feedkeys(":history \<C-A>\<C-B>\"\<CR>", 'tx')
call assert_equal('"history / : = > ? @ all cmd debug expr input search', @:)
endfunc
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
" Test for increasing the 'history' option value
func Test_history_size()
let save_histsz = &history
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
set history=10
vim-patch:8.2.0342: some code in ex_getln.c not covered by tests Problem: Some code in ex_getln.c not covered by tests. Solution: Add more tests. (Yegappan Lakshmanan, closes vim/vim#5717) https://github.com/vim/vim/commit/0546d7df13b041833121b2d56036e1c62ea3b0c1 Nvim doesn't support imsearch=2, commenting out that line is enough. Test_Ex_append() is not applicable to Vim enhanced Ex mode. Omit test_iminsert.vim as previous patches to that file are N/A.
2022-07-13 06:14:08 -07:00
call histadd(':', 'ls')
call histdel(':')
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
for i in range(1, 5)
call histadd(':', 'cmd' .. i)
endfor
call assert_equal(5, histnr(':'))
call assert_equal('cmd5', histget(':', -1))
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
set history=15
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
for i in range(6, 10)
call histadd(':', 'cmd' .. i)
endfor
call assert_equal(10, histnr(':'))
call assert_equal('cmd1', histget(':', 1))
call assert_equal('cmd10', histget(':', -1))
set history=5
call histadd(':', 'abc')
call assert_equal('', histget(':', 6))
call assert_equal('', histget(':', 12))
call assert_equal('cmd7', histget(':', 7))
call assert_equal('abc', histget(':', -1))
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
" This test works only when the language is English
if v:lang == "C" || v:lang =~ '^[Ee]n'
set history=0
redir => v
call feedkeys(":history\<CR>", 'xt')
redir END
call assert_equal(["'history' option is zero"], split(v, "\n"))
endif
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
let &history=save_histsz
endfunc
" Test for recalling old search patterns in /
func Test_history_search()
call histdel('/')
let g:pat = []
func SavePat()
call add(g:pat, getcmdline())
return ''
endfunc
cnoremap <F2> <C-\>eSavePat()<CR>
call histadd('/', 'pat1')
call histadd('/', 'pat2')
let @/ = ''
call feedkeys("/\<Up>\<F2>\<Up>\<F2>\<Down>\<Down>\<F2>\<Esc>", 'xt')
call assert_equal(['pat2', 'pat1', ''], g:pat)
cunmap <F2>
delfunc SavePat
vim-patch:8.2.0342: some code in ex_getln.c not covered by tests Problem: Some code in ex_getln.c not covered by tests. Solution: Add more tests. (Yegappan Lakshmanan, closes vim/vim#5717) https://github.com/vim/vim/commit/0546d7df13b041833121b2d56036e1c62ea3b0c1 Nvim doesn't support imsearch=2, commenting out that line is enough. Test_Ex_append() is not applicable to Vim enhanced Ex mode. Omit test_iminsert.vim as previous patches to that file are N/A.
2022-07-13 06:14:08 -07:00
vim-patch:8.2.0347: various code not covered by tests Problem: Various code not covered by tests. Solution: Add more test coverage. (Yegappan Lakshmanan, closes vim/vim#5720) https://github.com/vim/vim/commit/91ffc8a5f5c7b1c6979b3352a12ed779d11173a9 Test_Ex_echo_backslash() is not applicable to Vim enhanced Ex mode.
2022-07-13 06:21:14 -07:00
" Search for a pattern that is not present in the history
call assert_beeps('call feedkeys("/a1b2\<Up>\<CR>", "xt")')
vim-patch:8.2.0342: some code in ex_getln.c not covered by tests Problem: Some code in ex_getln.c not covered by tests. Solution: Add more tests. (Yegappan Lakshmanan, closes vim/vim#5717) https://github.com/vim/vim/commit/0546d7df13b041833121b2d56036e1c62ea3b0c1 Nvim doesn't support imsearch=2, commenting out that line is enough. Test_Ex_append() is not applicable to Vim enhanced Ex mode. Omit test_iminsert.vim as previous patches to that file are N/A.
2022-07-13 06:14:08 -07:00
" Recall patterns with 'history' set to 0
set history=0
let @/ = 'abc'
let cmd = 'call feedkeys("/\<Up>\<Down>\<S-Up>\<S-Down>\<CR>", "xt")'
call assert_fails(cmd, 'E486:')
set history&
vim-patch:8.2.0347: various code not covered by tests Problem: Various code not covered by tests. Solution: Add more test coverage. (Yegappan Lakshmanan, closes vim/vim#5720) https://github.com/vim/vim/commit/91ffc8a5f5c7b1c6979b3352a12ed779d11173a9 Test_Ex_echo_backslash() is not applicable to Vim enhanced Ex mode.
2022-07-13 06:21:14 -07:00
" Recall patterns till the end of history
set history=4
call histadd('/', 'pat')
call histdel('/')
call histadd('/', 'pat1')
call histadd('/', 'pat2')
call assert_beeps('call feedkeys("/\<Up>\<Up>\<Up>\<C-U>\<cr>", "xt")')
call assert_beeps('call feedkeys("/\<Down><cr>", "xt")')
" Test for wrapping around the history list
for i in range(3, 7)
call histadd('/', 'pat' .. i)
endfor
let upcmd = "\<up>\<up>\<up>\<up>\<up>"
let downcmd = "\<down>\<down>\<down>\<down>\<down>"
try
call feedkeys("/" .. upcmd .. "\<cr>", 'xt')
catch /E486:/
endtry
call assert_equal('pat4', @/)
try
call feedkeys("/" .. upcmd .. downcmd .. "\<cr>", 'xt')
catch /E486:/
endtry
call assert_equal('pat4', @/)
" Test for changing the search command separator in the history
call assert_fails('call feedkeys("/def/\<cr>", "xt")', 'E486:')
call assert_fails('call feedkeys("?\<up>\<cr>", "xt")', 'E486:')
call assert_equal('def?', histget('/', -1))
call assert_fails('call feedkeys("/ghi?\<cr>", "xt")', 'E486:')
call assert_fails('call feedkeys("?\<up>\<cr>", "xt")', 'E486:')
call assert_equal('ghi\?', histget('/', -1))
set history&
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
endfunc
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
" Test for making sure the key value is not stored in history
func Test_history_crypt_key()
CheckFeature cryptv
vim-patch:9.0.1968: cmdline completion should consider key option Problem: cmdline completion should consider key option Solution: Disable cmdline completion for key option, slightly refactor how P_NO_CMD_EXPAND is handled Harden crypto 'key' option: turn off cmdline completion, disable set-= "set-=" can be used maliciously with a crypto key, as it allows an attacker (who either has access to the computer or a plugin author) to guess a substring by observing the modified state. Simply turn off set+=/-=/^= for this option as there is no good reason for them to be used. Update docs to make that clear as well. Also, don't allow cmdline completion for 'key' as it just shows ***** which is not useful and confusing to the user what it means (if the user accidentally hits enter they will have replaced their key with "*****" instead). Move logic to better location, don't use above 32-bit for flags Move P_NO_CMD_EXPAND to use the unused 0x20 instead of going above 32-bits, as currently the flags parameter is only 32-bits on some systems. Left a comment to warn that future additions will need to change how the flags work either by making it 64-bit or split into two member vars. Also, move the logic for detecting P_NO_CMD_EXPAND earlier so it's not up to each handler to decide, and you won't see the temporary "..." that Vim shows while waiting for completion handler to complete. closes: vim/vim#13224 https://github.com/vim/vim/commit/6ee7b521fa7531ef356ececc8be7575c3800f872 Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
2023-10-01 03:26:14 -07:00
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
call feedkeys(":set bs=2 key=abc ts=8\<CR>", 'xt')
call assert_equal('set bs=2 key= ts=8', histget(':'))
vim-patch:9.0.1968: cmdline completion should consider key option Problem: cmdline completion should consider key option Solution: Disable cmdline completion for key option, slightly refactor how P_NO_CMD_EXPAND is handled Harden crypto 'key' option: turn off cmdline completion, disable set-= "set-=" can be used maliciously with a crypto key, as it allows an attacker (who either has access to the computer or a plugin author) to guess a substring by observing the modified state. Simply turn off set+=/-=/^= for this option as there is no good reason for them to be used. Update docs to make that clear as well. Also, don't allow cmdline completion for 'key' as it just shows ***** which is not useful and confusing to the user what it means (if the user accidentally hits enter they will have replaced their key with "*****" instead). Move logic to better location, don't use above 32-bit for flags Move P_NO_CMD_EXPAND to use the unused 0x20 instead of going above 32-bits, as currently the flags parameter is only 32-bits on some systems. Left a comment to warn that future additions will need to change how the flags work either by making it 64-bit or split into two member vars. Also, move the logic for detecting P_NO_CMD_EXPAND earlier so it's not up to each handler to decide, and you won't see the temporary "..." that Vim shows while waiting for completion handler to complete. closes: vim/vim#13224 https://github.com/vim/vim/commit/6ee7b521fa7531ef356ececc8be7575c3800f872 Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
2023-10-01 03:26:14 -07:00
call assert_fails("call feedkeys(':set bs=2 key-=abc ts=8\<CR>', 'xt')")
call assert_equal('set bs=2 key-= ts=8', histget(':'))
vim-patch:8.2.0325: ex_getln.c code not covered by tests Problem: Ex_getln.c code not covered by tests. Solution: Add a few more tests. (Yegappan Lakshmanan, closes vim/vim#5702) https://github.com/vim/vim/commit/578fe947e3ad0cc7313c798cf76cc43dbf9b4ea6 Cherry-pick Test_Ex_global() from patch 8.2.0293. Test_rightleftcmd() fails if incsearch is enabled, so disable it.
2022-07-08 06:13:30 -07:00
set key& bs& ts&
endfunc
vim-patch:9.0.2068: [security] overflow in :history (#25794) Problem: [security] overflow in :history Solution: Check that value fits into int The get_list_range() function, used to parse numbers for the :history and :clist command internally uses long variables to store the numbers. However function arguments are integer pointers, which can then overflow. Check that the return value from the vim_str2nr() function is not larger than INT_MAX and if yes, bail out with an error. I guess nobody uses a cmdline/clist history that needs so many entries... (famous last words). It is only a moderate vulnerability, so impact should be low. Github Advisory: https://github.com/vim/vim/security/advisories/GHSA-q22m-h7m2-9mgm https://github.com/vim/vim/commit/9198c1f2b1ddecde22af918541e0de2a32f0f45a N/A patch: vim-patch:9.0.2073: typo in quickfix.c comments Co-authored-by: Christian Brabandt <cb@256bit.org>
2023-10-26 15:37:52 -07:00
" The following used to overflow and causing an use-after-free
func Test_history_max_val()
set history=10
call assert_fails(':history 2147483648', 'E1510:')
set history&
endfunc
vim-patch:8.2.0316: ex_getln.c code has insufficient test coverage Problem: ex_getln.c code has insufficient test coverage. Solution: Add more tests. Fix a problem. (Yegappan Lakshmanan, closes vim/vim#5693) https://github.com/vim/vim/commit/8d588ccee57390aa01c2395fc599bbe6506ee13a
2022-07-01 18:40:06 -07:00
" vim: shiftwidth=2 sts=2 expandtab
Reference in New Issue Copy Permalink