Ben Hutchings 4acd4945cd ipv6: addrconf: Avoid calling netdevice notifiers with RCU read-side lock ... Cong Wang reports that lockdep detected suspicious RCU usage while enabling IPV6 forwarding: [ 1123.310275] =============================== [ 1123.442202] [ INFO: suspicious RCU usage. ] [ 1123.558207] 3.6.0-rc1+ #109 Not tainted [ 1123.665204] ------------------------------- [ 1123.768254] include/linux/rcupdate.h:430 Illegal context switch in RCU read-side critical section! [ 1123.992320] [ 1123.992320] other info that might help us debug this: [ 1123.992320] [ 1124.307382] [ 1124.307382] rcu_scheduler_active = 1, debug_locks = 0 [ 1124.522220] 2 locks held by sysctl/5710: [ 1124.648364] #0: (rtnl_mutex){+.+.+.}, at: [<ffffffff81768498>] rtnl_trylock+0x15/0x17 [ 1124.882211] #1: (rcu_read_lock){.+.+.+}, at: [<ffffffff81871df8>] rcu_lock_acquire+0x0/0x29 [ 1125.085209] [ 1125.085209] stack backtrace: [ 1125.332213] Pid: 5710, comm: sysctl Not tainted 3.6.0-rc1+ #109 [ 1125.441291] Call Trace: [ 1125.545281] [<ffffffff8109d915>] lockdep_rcu_suspicious+0x109/0x112 [ 1125.667212] [<ffffffff8107c240>] rcu_preempt_sleep_check+0x45/0x47 [ 1125.781838] [<ffffffff8107c260>] __might_sleep+0x1e/0x19b [...] [ 1127.445223] [<ffffffff81757ac5>] call_netdevice_notifiers+0x4a/0x4f [...] [ 1127.772188] [<ffffffff8175e125>] dev_disable_lro+0x32/0x6b [ 1127.885174] [<ffffffff81872d26>] dev_forward_change+0x30/0xcb [ 1128.013214] [<ffffffff818738c4>] addrconf_forward_change+0x85/0xc5 [...] addrconf_forward_change() uses RCU iteration over the netdev list, which is unnecessary since it already holds the RTNL lock. We also cannot reasonably require netdevice notifier functions not to sleep. Reported-by: Cong Wang <amwang@redhat.com> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2012-08-14 17:02:12 -07:00
..
netfilter	netfilter: nf_conntrack: generalize nf_ct_l4proto_net	2012-07-04 19:37:22 +02:00
addrconf_core.c	net: cleanup unsigned to unsigned int	2012-04-15 12:44:40 -04:00
addrconf.c	ipv6: addrconf: Avoid calling netdevice notifiers with RCU read-side lock	2012-08-14 17:02:12 -07:00
addrlabel.c	ipv6: bool/const conversions phase2	2012-05-19 01:08:16 -04:00
af_inet6.c	ipv6: bool conversions phase1	2012-05-18 02:24:13 -04:00
ah6.c	ipv6: Add redirect support to all protocol icmp error handlers.	2012-07-12 00:25:15 -07:00
anycast.c	ipv6: bool/const conversions phase2	2012-05-19 01:08:16 -04:00
datagram.c	ipv6: bool/const conversions phase2	2012-05-19 01:08:16 -04:00
esp6.c	ipv6: Add redirect support to all protocol icmp error handlers.	2012-07-12 00:25:15 -07:00
exthdrs_core.c	ipv6: bool/const conversions phase2	2012-05-19 01:08:16 -04:00
exthdrs.c	net: Remove casts to same type	2012-06-04 11:45:11 -04:00
fib6_rules.c	net/ipv6/fib6_rules.c: Checkpatch cleanup	2012-04-02 04:33:46 -04:00
icmp.c	ipv6: Use icmpv6_notify() to propagate redirect, instead of rt6_redirect().	2012-07-12 00:33:37 -07:00
inet6_connection_sock.c	ipv6: fix inet6_csk_xmit()	2012-07-18 08:59:58 -07:00
inet6_hashtables.c
ip6_fib.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2012-06-25 15:50:32 -07:00
ip6_flowlabel.c	ipv6: bool/const conversions phase2	2012-05-19 01:08:16 -04:00
ip6_input.c	net: TCP early demux cleanup	2012-07-30 14:53:21 -07:00
ip6_output.c	inet: Minimize use of cached route inetpeer.	2012-07-10 22:40:11 -07:00
ip6_tunnel.c	ipv6: add ipv6_addr_hash() helper	2012-07-18 11:28:46 -07:00
ip6mr.c	ip6mr: Do not use RTA_PUT() macros	2012-06-27 15:36:44 -07:00
ipcomp6.c	ipv6: Add redirect support to all protocol icmp error handlers.	2012-07-12 00:25:15 -07:00
ipv6_sockglue.c	net: cleanup unsigned to unsigned int	2012-04-15 12:44:40 -04:00
Kconfig	xfrm: make xfrm_algo.c a module	2012-05-15 13:13:34 -04:00
Makefile
mcast.c	ipv6: fix unappropriate errno returned for non-multicast address	2012-07-17 01:35:03 -07:00
mip6.c	ipv6: correct the ipv6 option name - Pad0 to Pad1	2012-05-17 15:49:51 -04:00
ndisc.c	ipv6: Use icmpv6_notify() to propagate redirect, instead of rt6_redirect().	2012-07-12 00:33:37 -07:00
netfilter.c
proc.c	net: ipv6: proc: Fix error handling	2012-08-14 14:45:07 -07:00
protocol.c	inet: Sanitize inet{,6} protocol demux.	2012-06-19 18:56:21 -07:00
raw.c	ipv6: Add redirect support to all protocol icmp error handlers.	2012-07-12 00:25:15 -07:00
reassembly.c	ipv6: use skb coalescing in reassembly	2012-05-19 18:34:57 -04:00
route.c	ipv6: fix incorrect route 'expires' value passed to userspace	2012-07-29 23:18:31 -07:00
sit.c	net: Pass optional SKB and SK arguments to dst_ops->{update_pmtu,redirect}()	2012-07-17 03:29:28 -07:00
syncookies.c	net-tcp: Fast Open base	2012-07-19 10:55:36 -07:00
sysctl_net_ipv6.c	net: Delete all remaining instances of ctl_path	2012-04-20 21:22:30 -04:00
tcp_ipv6.c	net: tcp: ipv6_mapped needs sk_rx_dst_set method	2012-08-09 20:56:09 -07:00
tunnel6.c	net: ipv6: Standardize prefixes for message logging	2012-05-16 01:01:03 -04:00
udp_impl.h
udp.c	ipv6: Add redirect support to all protocol icmp error handlers.	2012-07-12 00:25:15 -07:00
udplite.c
xfrm6_input.c
xfrm6_mode_beet.c	ipsec: be careful of non existing mac headers	2012-02-23 16:50:45 -05:00
xfrm6_mode_ro.c
xfrm6_mode_transport.c
xfrm6_mode_tunnel.c	ipsec: be careful of non existing mac headers	2012-02-23 16:50:45 -05:00
xfrm6_output.c	xfrm6: remove unneeded NULL check in __xfrm6_output()	2012-02-01 02:52:48 -05:00
xfrm6_policy.c	net: Pass optional SKB and SK arguments to dst_ops->{update_pmtu,redirect}()	2012-07-17 03:29:28 -07:00
xfrm6_state.c
xfrm6_tunnel.c	net: cleanup unsigned to unsigned int	2012-04-15 12:44:40 -04:00