1
linux/drivers/usb
Ming Lei eeb1b2a4a9 usb: musb: gadget: fix bulk IN infinit hangs in double buffer case
This patch fixes one infinite hang of bulk IN transfer in double buffer
case, the hang can be observed easily by test #6 of usbtest if musb is
configured as g_zero and fifo mode 3 is taken to enable double fifo.

In fact, the patch only removes the check for non-empty fifo before
loading data from new request into fifo since the check is not correct:

	-in double buffer case, fifo may accommodate more than one packet,
	even though it has contained one packet already and is non-empty

	-since last DMA is completed before calling musb_g_tx, it is sure
	that fifo may accommodate at least one packet

Without applying the patch, new requst enqueued from .complte may not
have a chance to be loaded into fifo, then will never be completed and
cause infinite hangs.

With the patch, on my beagle B5, test#6(queued bulk in) can be passed and
test result may go beyond 33Mbyte/s if musb is configured as g_zero and
fifo mode 3 is taken, follows the test command:

	#testusb -D DEV_NAME -c 1024 -t 6 -s 32768 -g 8   [1]

[1],
    -source of testusb : tools/usb/testusb.c under linux kernel;

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Anand Gadiyar <gadiyar@ti.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Anand Gadiyar <gadiyar@ti.com>
Cc: Mike Frysinger <vapier@gentoo.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-09-24 11:05:00 -07:00
..
atm USB: cxacru: Use a bulk/int URB to access the command endpoint 2010-09-03 17:33:41 -07:00
c67x00 USB: convert usb_hcd bitfields into atomic flags 2010-08-10 14:35:37 -07:00
class USB: cdc-acm: Fixing crash when ACM probing interfaces with no endpoint descriptors. 2010-09-03 17:33:41 -07:00
core USB: fix bug in initialization of interface minor numbers 2010-09-24 11:05:00 -07:00
early echi-dbgp: Add kernel debugger support for the usb debug port 2010-05-20 21:04:31 -05:00
gadget USB: Fix kernel oops with g_ether and Windows 2010-09-03 17:33:40 -07:00
host USB: EHCI: Disable langwell/penwell LPM capability 2010-09-20 16:04:59 -07:00
image
misc USB: adutux: fix misuse of return value of copy_to_user() 2010-08-23 20:50:17 -07:00
mon USB: resizing usbmon binary interface buffer causes protection faults 2010-08-10 14:35:41 -07:00
musb usb: musb: gadget: fix bulk IN infinit hangs in double buffer case 2010-09-24 11:05:00 -07:00
otg USB: otg: twl4030: fix phy initialization(v1) 2010-09-20 16:05:00 -07:00
serial USB: serial/mos*: prevent reading uninitialized stack memory 2010-09-20 16:05:00 -07:00
storage USB: usb-storage: implement autosuspend 2010-08-10 14:35:44 -07:00
wusbcore fix typos concerning "initiali[zs]e" 2010-06-16 18:05:05 +02:00
Kconfig USB: Add JZ4740 OHCI support 2010-08-05 13:26:19 +01:00
Makefile USB: drivers/usb/Makefile: conditionally descend to 'early' 2010-08-10 14:35:38 -07:00
README
usb-skeleton.c USB: usb-skeleton: Remove unnecessary casts of private_data 2010-08-10 14:35:39 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("khubd").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.