1
linux/sound/isa
Julia Lawall fcb2954b96 ALSA: sound/isa: convert nested spin_lock_irqsave to spin_lock
If spin_lock_irqsave is called twice in a row with the same second
argument, the interrupt state at the point of the second call overwrites
the value saved by the first call.  Indeed, the second call does not need
to save the interrupt state, so it is changed to a simple spin_lock.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression lock1,lock2;
expression flags;
@@

*spin_lock_irqsave(lock1,flags)
... when != flags
*spin_lock_irqsave(lock2,flags)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2009-07-19 14:02:29 +02:00
..
ad1816a Merge branch 'topic/snd_card_new-err' into topic/cs423x-merge 2009-02-16 23:03:57 +01:00
ad1848 ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
cs423x ALSA: cs4236 - Merge snd-cs4236-lib module into snd-cs4236 2009-02-17 08:10:54 +01:00
es1688 ALSA: Add missing __devexit_p() markers 2009-06-04 10:52:16 +02:00
gus ALSA: sound/isa: convert nested spin_lock_irqsave to spin_lock 2009-07-19 14:02:29 +02:00
msnd ALSA: Add missing SNDRV_PCM_INFO_BATCH flag to some drivers 2009-04-28 15:06:44 +02:00
opti9xx Merge branch 'topic/snd_card_new-err' into topic/cs423x-merge 2009-02-16 23:03:57 +01:00
sb ALSA: clean up the logic for building sequencer modules 2009-05-29 11:49:42 +02:00
wavefront Merge branch 'topic/memdup_user' into for-linus 2009-04-15 11:24:27 +02:00
wss Merge branch 'topic/sscape-fix' into for-linus 2009-03-24 00:36:21 +01:00
adlib.c ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
als100.c ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
azt2320.c ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
cmi8330.c ALSA: cmi8330: fix MPU-401 PnP init copy&paste bug 2009-06-29 08:06:10 +02:00
dt019x.c ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
es18xx.c ALSA: Return proper error code at probe in sound/isa/* 2009-01-12 15:21:54 +01:00
Kconfig Merge branch 'topic/sc6000' into for-linus 2009-06-10 07:26:45 +02:00
Makefile ALSA: enable build of snd-msnd-* drivers 2009-01-28 09:02:52 +01:00
opl3sa2.c ALSA: opl3sa2: add ZV port control 2009-04-06 03:46:17 +02:00
sc6000.c ALSA: sc6000: enable joystick port 2009-05-04 09:08:22 +02:00
sgalaxy.c ALSA: Convert to snd_card_create() in sound/isa/* 2009-01-12 15:20:26 +01:00
sscape.c Merge branch 'topic/sscape-fix' into for-linus 2009-03-24 00:36:21 +01:00